linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Carsten Otte <cotte@de.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: npiggin@suse.de, torvalds@linux-foundation.org,
	jaredeh@gmail.com, mschwid2@linux.vnet.ibm.com,
	heicars2@linux.vnet.ibm.com, linux-mm@kvack.org
Subject: Re: [patch 1/7] mm: introduce VM_MIXEDMAP
Date: Tue, 01 Apr 2008 16:20:33 +0200	[thread overview]
Message-ID: <1207059633.7075.1.camel@cotte.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20080331150426.20d57ddb.akpm@linux-foundation.org>

Am Montag, den 31.03.2008, 15:04 -0700 schrieb Andrew Morton:
> [7/7] needs to be redone please - git-s390 makes functional changes to
> add_shared_memory().

This patch removes struct page entries for DCSS segments that are being loaded.
They can still be accessed correctly, thanks to the struct page-less XIP work
of previous patches.

Signed-off-by: Carsten Otte <cotte@de.ibm.com>
---
 arch/s390/mm/vmem.c |   18 +-----------------
 1 files changed, 1 insertion(+), 17 deletions(-)

Index: linux-2.6-marist/arch/s390/mm/vmem.c
===================================================================
--- linux-2.6-marist.orig/arch/s390/mm/vmem.c
+++ linux-2.6-marist/arch/s390/mm/vmem.c
@@ -343,8 +343,6 @@ out:
 int add_shared_memory(unsigned long start, unsigned long size)
 {
 	struct memory_segment *seg;
-	struct page *page;
-	unsigned long pfn, num_pfn, end_pfn;
 	int ret;
 
 	mutex_lock(&vmem_mutex);
@@ -359,24 +357,10 @@ int add_shared_memory(unsigned long star
 	if (ret)
 		goto out_free;
 
-	ret = vmem_add_mem(start, size, 0);
+	ret = vmem_add_range(start, size, 0);
 	if (ret)
 		goto out_remove;
 
-	pfn = PFN_DOWN(start);
-	num_pfn = PFN_DOWN(size);
-	end_pfn = pfn + num_pfn;
-
-	page = pfn_to_page(pfn);
-	memset(page, 0, num_pfn * sizeof(struct page));
-
-	for (; pfn < end_pfn; pfn++) {
-		page = pfn_to_page(pfn);
-		init_page_count(page);
-		reset_page_mapcount(page);
-		SetPageReserved(page);
-		INIT_LIST_HEAD(&page->lru);
-	}
 	goto out;
 
 out_remove:


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2008-04-01 14:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-28  1:52 [patch 0/7] 2.6.25-rc5-mm1: VM_MIXEDMAP, pte_special, xip series npiggin
2008-03-28  1:52 ` [patch 1/7] mm: introduce VM_MIXEDMAP npiggin, Jared Hulbert
2008-03-31 22:04   ` Andrew Morton
2008-04-01  6:25     ` Nick Piggin
2008-04-01 14:20     ` Carsten Otte [this message]
2008-03-28  1:52 ` [patch 2/7] mm: introduce pte_special pte bit npiggin
2008-03-28  1:52 ` [patch 3/7] mm: add vm_insert_mixed npiggin
2008-03-28  1:52 ` [patch 4/7] return pfn from direct_access, for XIP npiggin, Jared Hulbert
2008-03-28  1:52 ` [patch 5/7] xip: support non-struct page backed memory npiggin
2008-03-28  1:52 ` [patch 6/7] s390: implement pte special bit npiggin
2008-03-28  1:52 ` [patch 7/7] s390: remove struct page entries for DCSS memory segments npiggin, Carsten Otte
  -- strict thread matches above, loose matches on Subject: below --
2008-03-11 10:46 [patch 0/7] [rfc] VM_MIXEDMAP, pte_special, xip work npiggin
2008-03-11 10:46 ` [patch 1/7] mm: introduce VM_MIXEDMAP npiggin, Jared Hulbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1207059633.7075.1.camel@cotte.boeblingen.de.ibm.com \
    --to=cotte@de.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=heicars2@linux.vnet.ibm.com \
    --cc=jaredeh@gmail.com \
    --cc=linux-mm@kvack.org \
    --cc=mschwid2@linux.vnet.ibm.com \
    --cc=npiggin@suse.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox