From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C75C2C32772 for ; Tue, 23 Aug 2022 13:28:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53F028D0001; Tue, 23 Aug 2022 09:28:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EF276B0074; Tue, 23 Aug 2022 09:28:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 390008D0001; Tue, 23 Aug 2022 09:28:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2A7DD6B0073 for ; Tue, 23 Aug 2022 09:28:01 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 00DC41A09D2 for ; Tue, 23 Aug 2022 13:28:00 +0000 (UTC) X-FDA: 79830935562.07.3947258 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 91CF0C0074 for ; Tue, 23 Aug 2022 13:28:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661261280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xEnBNd4+cIp13UQCQJVZGzjaWrbYja7AskgIKoRiLmQ=; b=GY3kFW2fKGx/b4/XXFoRWGj9/2NJV70O/tFPgYqPc+7wcfEhxlpaKaJialNFf8Y1DRdkea T1dNB8PGqNxdFSa3qO4liSyIy5XEblgOk5l4N0ntKNZrzmXuJv+01RrnhJmXKvCpwMMV4h rQnlsnKg58jJVQ/BMcFk1ZPw1verSVQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-281-6VS04F37OR-IHuvs6GwsoQ-1; Tue, 23 Aug 2022 09:27:56 -0400 X-MC-Unique: 6VS04F37OR-IHuvs6GwsoQ-1 Received: by mail-wr1-f70.google.com with SMTP id r8-20020adfbb08000000b00225239ce4deso2225361wrg.1 for ; Tue, 23 Aug 2022 06:27:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=xEnBNd4+cIp13UQCQJVZGzjaWrbYja7AskgIKoRiLmQ=; b=AxnCyRd3WWE5ommjScrYoQd4gqcxVpvHaNNU3cSePJM+gZC9GltuQakJkyrOGABdZZ qSdPtj48ZE0hDKYjp2K5ofmDQyp3ki6Pe6Ulg/5y9oZwOVUfgYx1m45YHEqXtMp8Bkou HJPK/OEJSzLrKmbd3poKYH79wTZQG18yyhZzzt26m7IoYOrpsL74pyZk8HiMNUIE+F3Z yF0y0t4Ke1auI7iC1Oix9s2OJowGqj2t/yBrkAVkGMM+B8c3ndCWwX5xSd9mI68RUwls drPNYgKx+JYU3jTVzNo/1gxino3/J3pQ39vSieSmymTnraP3PF0Ig5FxiGenCOOaTeOD Oj3w== X-Gm-Message-State: ACgBeo0tC7yQ1nWqUG+bVOQ39iUyUkeQPaMW/o1EBiEs4F5AT+7FkIU5 oV62Jc1OCD+RuHHOHAaCUK4VJ4Q6HoJKtSoLJaUkueSEFxvPSkhqoql1W4hdS9337ZDCh6EhQ9r THamQfqypqJE= X-Received: by 2002:a05:600c:214d:b0:3a5:ce18:bb71 with SMTP id v13-20020a05600c214d00b003a5ce18bb71mr2314053wml.1.1661261275672; Tue, 23 Aug 2022 06:27:55 -0700 (PDT) X-Google-Smtp-Source: AA6agR5cTxOYtyt12dFDB/n905jeqB8HL8PdTX4iMu3IGDvk0bXNH/Hnnk6Ga8iSPemsrOsGCAwQrw== X-Received: by 2002:a05:600c:214d:b0:3a5:ce18:bb71 with SMTP id v13-20020a05600c214d00b003a5ce18bb71mr2314040wml.1.1661261275387; Tue, 23 Aug 2022 06:27:55 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:1600:c48b:1fab:a330:5182? (p200300cbc70b1600c48b1faba3305182.dip0.t-ipconnect.de. [2003:cb:c70b:1600:c48b:1fab:a330:5182]) by smtp.gmail.com with ESMTPSA id k13-20020a7bc30d000000b003a5c75bd36fsm20997519wmj.10.2022.08.23.06.27.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Aug 2022 06:27:54 -0700 (PDT) Message-ID: <1206b559-2917-2ce0-6c54-ec78727b826d@redhat.com> Date: Tue, 23 Aug 2022 15:27:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v6 2/2] mm: fix the handling Non-LRU pages returned by follow_page To: "Wang, Haiyue" , Miaohe Lin , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Cc: "akpm@linux-foundation.org" , "apopple@nvidia.com" , "Huang, Ying" , "songmuchun@bytedance.com" , "naoya.horiguchi@linux.dev" , "alex.sierra@amd.com" , Felix Kuehling References: <20220812084921.409142-1-haiyue.wang@intel.com> <20220816022102.582865-1-haiyue.wang@intel.com> <20220816022102.582865-3-haiyue.wang@intel.com> <36925544-8127-fe0c-76e5-49138dff45ae@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661261280; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xEnBNd4+cIp13UQCQJVZGzjaWrbYja7AskgIKoRiLmQ=; b=ePTTRnuxXvqZtA2uph/lcD9OoZK21+i3rB//GyL2NtfCYJCGMLsVrXQkLxt2eqQlpXSo81 QbCGmajbwDdBcLPD/yGpEq+hE5NnIFJJq+I2mPUAPtdCBwj1nXp514IDk+FxmBFA0t1vyM 6SX8sR8FzYjsz+dk7OpwTKVmQd66gfQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GY3kFW2f; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661261280; a=rsa-sha256; cv=none; b=AEC828lmhcNYmahR6i5kPHLQTQBK42osDSzl6PmFQ+LdScHx1Mn3nI3qnTxctnk0G6IXAv WLhFUlxIGNcbxxI85y02gl17QBG33qP74s+x1XAin8mpGb5zvx5O9oVj+WYULjUmrPMWIa E2ifs+pdQhPnyIJh+Fu4gw0qlfsiI+g= X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GY3kFW2f; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 91CF0C0074 X-Stat-Signature: gcfgchztq6fnxyjeme67tetwid735upm X-HE-Tag: 1661261280-91734 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 23.08.22 15:26, Wang, Haiyue wrote: >> -----Original Message----- >> From: David Hildenbrand >> Sent: Tuesday, August 23, 2022 18:07 >> To: Miaohe Lin ; Wang, Haiyue ; linux-mm@kvack.org; >> linux-kernel@vger.kernel.org >> Cc: akpm@linux-foundation.org; apopple@nvidia.com; Huang, Ying ; >> songmuchun@bytedance.com; naoya.horiguchi@linux.dev; alex.sierra@amd.com; Felix Kuehling >> >> Subject: Re: [PATCH v6 2/2] mm: fix the handling Non-LRU pages returned by follow_page >> >> On 17.08.22 04:34, Miaohe Lin wrote: >>> On 2022/8/16 10:21, Haiyue Wang wrote: >>>> The handling Non-LRU pages returned by follow_page() jumps directly, it >>>> doesn't call put_page() to handle the reference count, since 'FOLL_GET' >>>> flag for follow_page() has get_page() called. Fix the zone device page >>>> check by handling the page reference count correctly before returning. >>>> >>>> And as David reviewed, "device pages are never PageKsm pages". Drop this >>>> zone device page check for break_ksm(). >>>> >>>> Fixes: 3218f8712d6b ("mm: handling Non-LRU pages returned by vm_normal_pages") >>>> Signed-off-by: Haiyue Wang >>>> Reviewed-by: "Huang, Ying" >>>> Reviewed-by: Felix Kuehling >>> >>> Thanks for your fixing. LGTM with one nit below. But I have no strong opinion on it. >>> So with or without fixing below nit: >>> >>> Reviewed-by: Miaohe Lin >>> >>>> --- >>>> mm/huge_memory.c | 4 ++-- >>>> mm/ksm.c | 12 +++++++++--- >>>> mm/migrate.c | 19 ++++++++++++------- >>>> 3 files changed, 23 insertions(+), 12 deletions(-) >>>> >>>> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >>>> index 8a7c1b344abe..b2ba17c3dcd7 100644 >>>> --- a/mm/huge_memory.c >>>> +++ b/mm/huge_memory.c >>>> @@ -2963,10 +2963,10 @@ static int split_huge_pages_pid(int pid, unsigned long vaddr_start, >>>> /* FOLL_DUMP to ignore special (like zero) pages */ >>>> page = follow_page(vma, addr, FOLL_GET | FOLL_DUMP); >>>> >>>> - if (IS_ERR_OR_NULL(page) || is_zone_device_page(page)) >>>> + if (IS_ERR_OR_NULL(page)) >>>> continue; >>>> >>>> - if (!is_transparent_hugepage(page)) >>>> + if (is_zone_device_page(page) || !is_transparent_hugepage(page)) >>> >>> !is_transparent_hugepage should already do the work here? IIRC, zone_device_page can't be >>> a transhuge page anyway. And only transparent_hugepage is cared here. >> >> I agree. > > OK, will remove it in next version. > >> >> Can we avoid sending a new version of a patch series as reply to another >> patch series (previous version)? > > Don't use '--in-reply-to=' when running 'git send-email' ? Yes. That makes it easier top identify versions of patch series, without having to dig down into an ever-growing thread. -- Thanks, David / dhildenb