From: Dave Hansen <haveblue@us.ibm.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Carsten Otte <cotte@de.ibm.com>,
virtualization@lists.linux-foundation.org,
kvm-devel@lists.sourceforge.net, Avi Kivity <avi@qumranet.com>,
Linux Memory Management List <linux-mm@kvack.org>,
aliguori@us.ibm.com, EHRHARDT@de.ibm.com, arnd@arndb.de,
hollisb@us.ibm.com, heiko.carstens@de.ibm.com,
jeroney@us.ibm.com, borntraeger@de.ibm.com,
schwidefsky@de.ibm.com, rvdheij@gmail.com, os@de.ibm.com,
jblunck@suse.de, "Zhang, Xiantao" <xiantao.zhang@intel.com>
Subject: Re: [RFC/PATCH 01/15] preparation: provide hook to enable pgstes in user pagetable
Date: Thu, 20 Mar 2008 12:13:25 -0700 [thread overview]
Message-ID: <1206040405.8232.24.camel@nimitz.home.sr71.net> (raw)
In-Reply-To: <47E29EC6.5050403@goop.org>
On Thu, 2008-03-20 at 10:28 -0700, Jeremy Fitzhardinge wrote:
> Carsten Otte wrote:
> > +struct mm_struct *dup_mm(struct task_struct *tsk);
>
> No prototypes in .c files. Put this in an appropriate header.
Well, and more fundamentally: do we really want dup_mm() able to be
called from other code?
Maybe we need a bit more detailed justification why fork() itself isn't
good enough. It looks to me like they basically need an arch-specific
argument to fork, telling the new process's page tables to take the
fancy new bit.
I'm really curious how this new stuff is going to get used. Are you
basically replacing fork() when creating kvm guests?
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-03-20 19:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1206028710.6690.21.camel@cotte.boeblingen.de.ibm.com>
2008-03-20 16:24 ` Carsten Otte, Martin Schwidefsky
2008-03-20 17:28 ` Jeremy Fitzhardinge
2008-03-20 19:13 ` Dave Hansen [this message]
2008-03-20 20:35 ` [kvm-devel] " Carsten Otte
2008-03-21 18:29 ` Dave Hansen
2008-03-21 19:03 ` Carsten Otte
2008-03-22 17:57 ` Heiko Carstens
2008-03-23 10:15 ` Avi Kivity
2008-03-23 18:23 ` Martin Schwidefsky
2008-03-24 6:57 ` Avi Kivity
2008-03-25 6:08 ` Carsten Otte
2008-03-25 6:12 ` Avi Kivity
2008-03-25 15:37 ` Carsten Otte
2008-03-20 16:24 ` [RFC/PATCH 02/15] preparation: host memory management changes for s390 kvm Carsten Otte, Heiko Carstens, Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206040405.8232.24.camel@nimitz.home.sr71.net \
--to=haveblue@us.ibm.com \
--cc=EHRHARDT@de.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=arnd@arndb.de \
--cc=avi@qumranet.com \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hollisb@us.ibm.com \
--cc=jblunck@suse.de \
--cc=jeremy@goop.org \
--cc=jeroney@us.ibm.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-mm@kvack.org \
--cc=os@de.ibm.com \
--cc=rvdheij@gmail.com \
--cc=schwidefsky@de.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox