From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Anton Salikhmetov <salikhmetov@gmail.com>
Cc: linux-mm@kvack.org, jakob@unthought.net,
linux-kernel@vger.kernel.org, Valdis.Kletnieks@vt.edu,
riel@redhat.com, ksm@42.dk, staubach@redhat.com,
jesper.juhl@gmail.com
Subject: Re: [PATCH 2/2][RFC][BUG] msync: updating ctime and mtime at syncing
Date: Sat, 12 Jan 2008 10:40:44 +0100 [thread overview]
Message-ID: <1200130844.7999.12.camel@lappy> (raw)
In-Reply-To: <1200130565.7999.8.camel@lappy>
On Sat, 2008-01-12 at 10:36 +0100, Peter Zijlstra wrote:
> On Fri, 2008-01-11 at 03:44 +0300, Anton Salikhmetov wrote:
>
> > +/*
> > + * Update the ctime and mtime stamps after checking if they are to be updated.
> > + */
> > +void mapped_file_update_time(struct file *file)
> > +{
> > + if (test_and_clear_bit(AS_MCTIME, &file->f_mapping->flags)) {
> > + get_file(file);
> > + file_update_time(file);
> > + fput(file);
> > + }
> > +}
> > +
>
> I don't think you need the get/put file stuff here, because
BTW, the reason for me noticing this is that if it would be needed there
is a race condition right there, who is to say that the file pointer
you're deref'ing in your test condition isn't a dead one already.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-01-12 9:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1200006638.19293.42.camel@codedot>
2008-01-11 0:38 ` [PATCH 1/2][RFC][BUG] msync: massive code cleanup of sys_msync() Anton Salikhmetov, Anton Salikhmetov
2008-01-11 15:55 ` Rik van Riel
2008-01-11 0:44 ` [PATCH 2/2][RFC][BUG] msync: updating ctime and mtime at syncing Anton Salikhmetov, Anton Salikhmetov
2008-01-11 18:55 ` Peter Staubach
2008-01-11 19:29 ` Anton Salikhmetov
2008-01-11 18:59 ` Peter Staubach
2008-01-11 21:40 ` Anton Salikhmetov
2008-01-11 21:59 ` Peter Staubach
2008-01-11 22:15 ` Anton Salikhmetov
2008-01-12 2:24 ` Anton Salikhmetov
2008-01-12 9:36 ` Peter Zijlstra
2008-01-12 9:40 ` Peter Zijlstra [this message]
2008-01-12 12:38 ` Anton Salikhmetov
2008-01-12 13:09 ` Peter Zijlstra
2008-01-12 13:51 ` Anton Salikhmetov
2008-01-12 12:17 ` Anton Salikhmetov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200130844.7999.12.camel@lappy \
--to=a.p.zijlstra@chello.nl \
--cc=Valdis.Kletnieks@vt.edu \
--cc=jakob@unthought.net \
--cc=jesper.juhl@gmail.com \
--cc=ksm@42.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=salikhmetov@gmail.com \
--cc=staubach@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox