From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABCABC433EF for ; Tue, 7 Jun 2022 12:57:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1ED888D000D; Tue, 7 Jun 2022 08:57:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19CC68D0003; Tue, 7 Jun 2022 08:57:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03CE58D000D; Tue, 7 Jun 2022 08:57:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E69398D0003 for ; Tue, 7 Jun 2022 08:57:38 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id B5F73120008 for ; Tue, 7 Jun 2022 12:57:38 +0000 (UTC) X-FDA: 79551441396.05.7F539BE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id EE2408000D for ; Tue, 7 Jun 2022 12:57:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654606657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4QSRH8DM0EWIFp4tvv53kVC06dJu/u/EgMkz7xegTNs=; b=JwuA4sJ0ipqJqvtOSSqgvTrwxX3OkcAsIAdGvsxHVkzrDfil504yLgE9AVQAfpq/N+FlBC nzh0vXS+19ZhKEzWNY+cNMUjuu8bI3lFHz0FmxriHNWUOLbqUnieem899bqzsobd0KX8mm u1ja7zKIOc1o8EU6KwR2OQzQjBFfhfA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-176-YTvC7bC6OiC23jwcwzrIIg-1; Tue, 07 Jun 2022 08:57:36 -0400 X-MC-Unique: YTvC7bC6OiC23jwcwzrIIg-1 Received: by mail-wr1-f69.google.com with SMTP id w8-20020adfde88000000b00213b7fa3a37so3110232wrl.2 for ; Tue, 07 Jun 2022 05:57:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=4QSRH8DM0EWIFp4tvv53kVC06dJu/u/EgMkz7xegTNs=; b=SaTTgUWik2JLlDcdcEzs1eglmyzNFpdmB9dUvGCpuK3AwGuEQAuvUUOBrN7K/ocVGW N+Ryn8IeLbjuMHoSclpgR8bT7ilAt+nSmOMgsBHYsEJ2bR2e5i0RLfm+P910ljJlMV3V 2IICMc07j6L4cPEnZEjdzpUFI64qjoY2qYrxQYRMTTOsTAd0JihCois9wh7kAoqS0TvT jLGujvfIxXnqux4NkX1B+JYCGDzfsZymV7YhyobZDGxhE9jXobkTG+022dBiSHgOS7nz SI76Xl28vhj7aOv5PF4XC5mBk+uPnaKhWqOPxV3hLmwYjg1cRQmbgkFidwUsYbPKIVAD i4nQ== X-Gm-Message-State: AOAM532zTSrGMdozoQDRV0kgl/FbT6tsMKTwk8S4FO2iEuRDv6sWIg5p HanWWppeJhUlY5msoJ70kpZlXDCZNe8zAXfa0tl6JrIWHnRtrBqbLBN5wTZDzfoF9XEQHQAWwCp ed0LdzK2jDIE= X-Received: by 2002:a05:600c:4f90:b0:397:89b1:539b with SMTP id n16-20020a05600c4f9000b0039789b1539bmr54389408wmq.149.1654606654439; Tue, 07 Jun 2022 05:57:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyUkMuPhmF8WVpmZThM74o1w4iOAEeqbYNAVijCPByVKvmwU21f0ZJXPf9IJ4t1pum0BoCPxA== X-Received: by 2002:a05:600c:4f90:b0:397:89b1:539b with SMTP id n16-20020a05600c4f9000b0039789b1539bmr54389386wmq.149.1654606654169; Tue, 07 Jun 2022 05:57:34 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:500:4c8d:4886:f874:7b6f? (p200300cbc70905004c8d4886f8747b6f.dip0.t-ipconnect.de. [2003:cb:c709:500:4c8d:4886:f874:7b6f]) by smtp.gmail.com with ESMTPSA id n20-20020a7bc5d4000000b0039aef592ca0sm20181432wmk.35.2022.06.07.05.57.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jun 2022 05:57:33 -0700 (PDT) Message-ID: <11e5905b-f3a9-dced-d5dc-1446a3334f7f@redhat.com> Date: Tue, 7 Jun 2022 14:57:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 1/3] mm/page_alloc: use might_alloc() To: Daniel Vetter , LKML Cc: DRI Development , Daniel Vetter , Andrew Morton , linux-mm@kvack.org References: <20220605152539.3196045-1-daniel.vetter@ffwll.ch> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220605152539.3196045-1-daniel.vetter@ffwll.ch> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JwuA4sJ0; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf02.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: px3b6n1imqf1ozxssje87rdsnb57199u X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EE2408000D X-HE-Tag: 1654606650-557396 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05.06.22 17:25, Daniel Vetter wrote: > ... instead of open codding it. Completely equivalent code, just > a notch more meaningful when reading. > > Signed-off-by: Daniel Vetter > Cc: Andrew Morton > Cc: linux-mm@kvack.org > --- > mm/page_alloc.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 2db95780e003..277774d170cb 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5177,10 +5177,7 @@ static inline bool prepare_alloc_pages(gfp_t gfp_mask, unsigned int order, > *alloc_flags |= ALLOC_CPUSET; > } > > - fs_reclaim_acquire(gfp_mask); > - fs_reclaim_release(gfp_mask); > - > - might_sleep_if(gfp_mask & __GFP_DIRECT_RECLAIM); > + might_alloc(gfp_mask); > > if (should_fail_alloc_page(gfp_mask, order)) > return false; Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb