From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FB58C433F5 for ; Tue, 14 Dec 2021 14:28:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6C1B6B0073; Tue, 14 Dec 2021 09:28:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B1CA56B0074; Tue, 14 Dec 2021 09:28:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E4196B0078; Tue, 14 Dec 2021 09:28:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0009.hostedemail.com [216.40.44.9]) by kanga.kvack.org (Postfix) with ESMTP id 8F0816B0073 for ; Tue, 14 Dec 2021 09:28:09 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 56F108249980 for ; Tue, 14 Dec 2021 14:27:59 +0000 (UTC) X-FDA: 78916629078.21.C599B39 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf02.hostedemail.com (Postfix) with ESMTP id EAAA980007 for ; Tue, 14 Dec 2021 14:27:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1A26A212B6; Tue, 14 Dec 2021 14:27:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1639492077; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=afwLggD4Snr2QFuVXkU4+5D1cUnL8xMB0CBSJI6vyFM=; b=HgK85HiFH90CWfiW0rF577kQP+aA76PfgMIlYz4L/yzYjxPxQYQiolNOuceyvFfitMWekZ 6IzVd4qVCfbyp+q1kftAZeiD4Z4mzWMxV4uiW2Qd7mizAmS3cSgQosRj2OQem9l4ZwjMPr t0tKBmwXDGfkhg5/dHuE9qXQ7Wai2Oc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1639492077; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=afwLggD4Snr2QFuVXkU4+5D1cUnL8xMB0CBSJI6vyFM=; b=evpWjB3DVagYW1OumfE/KLs6cHhsi+bLP9Q5Rnho64RjoE/st+Miv4pthNEc9kQg89sDYb JBi/g+oPkLd57VDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E84F813EA2; Tue, 14 Dec 2021 14:27:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wy2dN+ypuGGcRwAAMHmgww (envelope-from ); Tue, 14 Dec 2021 14:27:56 +0000 Message-ID: <11e44db8-3d01-743b-7bb2-2ef0317864d8@suse.cz> Date: Tue, 14 Dec 2021 15:27:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2 01/33] mm: add virt_to_folio() and folio_address() Content-Language: en-US To: Johannes Weiner Cc: Matthew Wilcox , Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , linux-mm@kvack.org, Andrew Morton , patches@lists.linux.dev References: <20211201181510.18784-1-vbabka@suse.cz> <20211201181510.18784-2-vbabka@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: EAAA980007 X-Stat-Signature: 359muxx1bmoq49k8pb6xdhjqsn1wiohz Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=HgK85HiF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=evpWjB3D; dmarc=none; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-HE-Tag: 1639492076-668684 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/14/21 15:20, Johannes Weiner wrote: > On Wed, Dec 01, 2021 at 07:14:38PM +0100, Vlastimil Babka wrote: >> These two wrappers around their respective struct page variants will be useful >> in the following patches. >> >> Signed-off-by: Vlastimil Babka > > Acked-by: Johannes Weiner Thanks! > Slight reviewer preference: introduce helpers when they're first used, > as it's a little easier to understand the application without having > to chase new folio_address() -> new slab_address() -> first user of > slab_address() through the patchset. Yeah would normally do that but with the current folio work going on there was a chance the helpers would be useful to somebody else too and cherry-picking a patch that adds them without user is simpler. And indeed Matthew just asked about virt_to_folio() few days ago :)