From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90C57C5B549 for ; Fri, 30 May 2025 09:30:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31AA06B009F; Fri, 30 May 2025 05:30:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CB396B00A0; Fri, 30 May 2025 05:30:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E15D6B00A1; Fri, 30 May 2025 05:30:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F3E006B009F for ; Fri, 30 May 2025 05:30:16 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9BDAE82BC2 for ; Fri, 30 May 2025 09:30:16 +0000 (UTC) X-FDA: 83499053232.03.18FC62F Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf08.hostedemail.com (Postfix) with ESMTP id B29CE160005 for ; Fri, 30 May 2025 09:30:14 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="kjI/MZ6/"; spf=pass (imf08.hostedemail.com: domain of libo.gcs85@bytedance.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=libo.gcs85@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748597414; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=flixYT7qZa2BQQysi97LfHe75SLaTmZqxePIcANrNj8=; b=oQ7vCmVMJa3kIOOzXlAXk9YO1zrBGSE6ObmW9niC7vgjhisjM9//G+Y78Pvq3LpJy4sh4I XmwtW00rn2j4cTzcHAm4G9zIIlqBbr04iTJak0ST/qg/PgVQkc83ibsWEGg03eOJkCH1tt SzW1+j2Eu3TRwRrSsP5cLuncmjq1F/k= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="kjI/MZ6/"; spf=pass (imf08.hostedemail.com: domain of libo.gcs85@bytedance.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=libo.gcs85@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748597414; a=rsa-sha256; cv=none; b=xRxpDeVRDIOEKOX0NA0MpG9TLYE8wshksZx95YHbAMRvI+r1i4aEDmc6l88xhMoJ0QbfjP 67ivyYQcL4bAwa57GBe4EYyS3Ysa6Te5sn77jp20SDT5S0fEXlGuDidV8aYXCjiY0HEpa8 vkyI6+q5h/PuIMl590Q1K5etmRyy2pM= Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-742c46611b6so2211180b3a.1 for ; Fri, 30 May 2025 02:30:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1748597413; x=1749202213; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=flixYT7qZa2BQQysi97LfHe75SLaTmZqxePIcANrNj8=; b=kjI/MZ6/lRQ14xxXvPckoS1cQh48k+V/S3ubo0iqv8A8U3TgJI9UW4VRVt9XDtTKF1 46OEPbirexeH/8Zm2alfZ6H2molLjHycjpLm/nLSRMV1a15Uu/Qzh7jIZi1zEHe6Jr+b O5+1RWr0eOb29Upo1bNAsZTMVqWH0NkTAX8t8lUwb6HZ6qAgNkvUd0CjVHoy425fs0u2 FC61UWyLydHwsn1hr0faVYQ47tS9fP9OTOKkS6pIyV3zaMuUWmi8HRrJCjFY5+MorPeM +YoPniK7jOVG+9hAiLWH9+4eKIltfsUDFx0pMjzJTmjE2QmKM4OyCroA/ho3DTTrfdHf sUiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748597413; x=1749202213; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=flixYT7qZa2BQQysi97LfHe75SLaTmZqxePIcANrNj8=; b=vUZp9hCyvw5bxTryD+Bt01wRTieYYQuyoRIruKfyP2zgVKxo6LOaxansJndqhlfFHc LxUYEhG/K7o3/+EfxWbd/Qh/fTPDU98pYsWFN5arb1saOz4L/ohw6317fjLBvoupqQ9I 7w6E90G6ehvh1mvxvggMmDtbZHPJTSTSW6DlbQn1H9cVlbFjJIIZAcCF/n3s2bNdtj8p 5B53tiFdQFpKZA5X39Pbif+gWOygTFbgNn738f9DhDs7ROTRbSDtBO9iYyyiTWuuFaML pd59OsrK+K0HeG/J2+v1s0toXy6gYK7riCwFxVNHHdII90FfsScfYb/0QNtdIb9SLeRv muUw== X-Forwarded-Encrypted: i=1; AJvYcCWZ3Zthl/ddp2k0me4xycTGBs7d8gML32s4MfrW7LlUq7IJb7n0BHxD1kRmO/E+ush7lApeKoQYEg==@kvack.org X-Gm-Message-State: AOJu0Yy0QiXyq7qd07SiiMjcQz2F5D33GFQJxPbeHdBfPbaEBYLnEea9 EWqaRXWKniMwH8wKJyT/lEfLcLGoa8Vl1zjRd+U2FHL/j0p7tr7sESu9jBJ4YskFsX4= X-Gm-Gg: ASbGncuA0ydzr+oUmVtSvtJoyPIo9vzs57rDgRLaEKY566CIG6exqPL34cVUEwUrED6 4KyPs2b8ar/IQieGZz/O46VAgqQNjlGGeqWW0YWmT6fsCsa13tSoW+sfuK5cPu310NVssFGof+v xRrzqEkA76YZ0yVFJNGjC6mXKgwlynDhTGnuEu8Hoywd0VzYK10tWq8N96mUUqKGo5OUg6sOlMO 4nQVH4dokcEuydgtb6kRDvKcVrDZqUBbeorba09Lk0mK3J0cvGvzLx6os3wRFtqyo6b0LlScXQf eefW6f3fjW+p2qy9KWsDgaBOxw+tVqBk/hvu2S34xPCZjzwkhU7561LqmrFK7TsPfnru3CHDn7A LnLT30BDK5BPLbauC37K5 X-Google-Smtp-Source: AGHT+IHA2yGD8wMUj4lSxB67R095/h8/6O6yJ7zAmlSwm5/Pic/viWYeW3kwOjE2By4p9s+RPQhz5w== X-Received: by 2002:a17:90b:1d50:b0:311:fde5:c4b6 with SMTP id 98e67ed59e1d1-31250344995mr2204788a91.6.1748597413513; Fri, 30 May 2025 02:30:13 -0700 (PDT) Received: from FQ627FTG20.bytedance.net ([63.216.146.178]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3124e29f7b8sm838724a91.2.2025.05.30.02.29.58 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 30 May 2025 02:30:13 -0700 (PDT) From: Bo Li To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, luto@kernel.org, kees@kernel.org, akpm@linux-foundation.org, david@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, peterz@infradead.org Cc: dietmar.eggemann@arm.com, hpa@zytor.com, acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, kan.liang@linux.intel.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, jannh@google.com, pfalcato@suse.de, riel@surriel.com, harry.yoo@oracle.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, yinhongbo@bytedance.com, dengliang.1214@bytedance.com, xieyongji@bytedance.com, chaiwen.cc@bytedance.com, songmuchun@bytedance.com, yuanzhu@bytedance.com, chengguozhu@bytedance.com, sunjiadong.lff@bytedance.com, Bo Li Subject: [RFC v2 07/35] RPAL: enable shared page mmap Date: Fri, 30 May 2025 17:27:35 +0800 Message-Id: <11d4a94318efc8af41f77235f5117aabb8795afe.1748594840.git.libo.gcs85@bytedance.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B29CE160005 X-Stat-Signature: n97kz4mita4yz1hxboz3d5garns7x8or X-Rspam-User: X-HE-Tag: 1748597414-669337 X-HE-Meta: U2FsdGVkX19rCizwCjZDhy3wJVqigLXcN9W4vs5983VDRUYSTLHeQVDxNVKAWH9ma+MHJu0UBD/Bz6OvqmMWJoXOeTH48lCTsH6mIp+d5HkSPgR2JJ80LoxEuJwAshSYg2a4Dquq5K1iIb8sM+VGZDzOX7HbSB8AjSmaSWgAgB0CT6OqlBwERb7qFyqN/QZR5cvSKnX8LhChIsQQYPhHwv5StwdoQrRfPt/3u9LJBbNWNuiCN5RyDTbT+kCBO3OyehK/Zjy83wM/gU+DoaybV4xknb4BP+5d1m7dVDPHOs/Cft/xXNIetYlT88b2+OV6fjwB2iJnfNHGhYU76lvzcUap4naMOGzzU1qb5BuiXedey/dEKxvGy5vtSNrUZhDrtJKpubhHoMTyCVeFPurxc+5Ufept/+iUas5Vk1inCDg7I9H+xPNSBO64F/nLgM1xcheYxJMbdGVvyNqOSqBwhXwcO7jPFXYGNPZsU+dynQlDTAkY0IAhkfQ+7aqL0IvV501cY1iY7Ffb4rQ9hqRK1PD6ngxUI7coTVsLFMYT0+yfXoJDL2Oj9OYRv7pmXhLy2fJIviwZpavn/vvRVRQtTUbH8sWx6HF9xGVCrea5yidSbflprpHTOFPy1vfvlvFhThZ9w+Y4f0sNY3TzUVDLASYV6V/nmtLN/u/ycGR8EAaykLw0+2yESiUZUjf4jUz2AWuTUUqjw+kDUccn4bDAMZzeYaghhfPTTQXoS73dghUMwauvaNVBaa/6c4pLC2DL/aF5TtBZSJeTPSnRDemO4LUCKJAd+yVekhjkOriBlhlbTZSJpKOjFXyfd3kJNkj6o2tVnxMXOzfaFJ8Vboxmcjg2cCqj5gFMKq49rdZK/+ldzlgloAYRfd8VqeHbUhhzEW+PM+a+WiVhg/Hs3etj7YBhrP/E9Api++xSJM1qoG7orhLmTJiiQlwrN0ZFdHlxIT6s3GTDjxzEBZ6LPdE vEQwzaA+ FnLjMMxRTeOXLBD3HqvxHbyZUXWG4kvxINXBhDrpnY2V2vcMN1TQSepDuB6OugT+6rHmqQ4JEa1iT1LQykCnKefVBcsr2KYqtHClO9xRk82MLSNkwUt1Z/3vHb3PBe+w+LPYiZ0EBoHbK23wtAS/7Ad09m905K8y8tscMid0NmEUm1LBW5bPs56JW/8y+Xx7Wm5+V7/sbSupqlZMwmn+PmvhvjeDvJl6WFP5r8mrC6JQRFD/mLxHAkfHxXVjAqnv26AADO+inqZY2SUuV8DQTxjuva2CWowdXCKAapqLjHcwv+tGTT1O5ycgbdg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: RPAL needs to create shared memory between the kernel and user space for the transfer of states and data. This patch implements the rpal_mmap() interface. User processes can create shared memory by calling mmap() on /proc/rpal. To prevent users from creating excessive memory, rpal_mmap() limits the total size of the shared memory that can be created. The shared memory is maintained through reference counting, and rpal_munmap() is implemented for the release of the shared memory. Signed-off-by: Bo Li --- arch/x86/rpal/internal.h | 20 ++++++ arch/x86/rpal/mm.c | 147 +++++++++++++++++++++++++++++++++++++++ arch/x86/rpal/proc.c | 1 + arch/x86/rpal/service.c | 4 ++ include/linux/rpal.h | 15 ++++ mm/mmap.c | 4 ++ 6 files changed, 191 insertions(+) diff --git a/arch/x86/rpal/internal.h b/arch/x86/rpal/internal.h index c102a4c50515..65fd14a26f0e 100644 --- a/arch/x86/rpal/internal.h +++ b/arch/x86/rpal/internal.h @@ -9,8 +9,28 @@ #define RPAL_COMPAT_VERSION 1 #define RPAL_API_VERSION 1 +#include +#include + extern bool rpal_inited; /* service.c */ int __init rpal_service_init(void); void __init rpal_service_exit(void); + +/* mm.c */ +static inline struct rpal_shared_page * +rpal_get_shared_page(struct rpal_shared_page *rsp) +{ + atomic_inc(&rsp->refcnt); + return rsp; +} + +static inline void rpal_put_shared_page(struct rpal_shared_page *rsp) +{ + atomic_dec(&rsp->refcnt); +} + +int rpal_mmap(struct file *filp, struct vm_area_struct *vma); +struct rpal_shared_page *rpal_find_shared_page(struct rpal_service *rs, + unsigned long addr); diff --git a/arch/x86/rpal/mm.c b/arch/x86/rpal/mm.c index f469bcf57b66..8a738c502d1d 100644 --- a/arch/x86/rpal/mm.c +++ b/arch/x86/rpal/mm.c @@ -11,6 +11,8 @@ #include #include +#include "internal.h" + static inline int rpal_balloon_mapping(unsigned long base, unsigned long size) { struct vm_area_struct *vma; @@ -68,3 +70,148 @@ int rpal_balloon_init(unsigned long base) return ret; } + +static void rpal_munmap(struct vm_area_struct *area) +{ + struct mm_struct *mm = area->vm_mm; + struct rpal_service *rs = mm->rpal_rs; + struct rpal_shared_page *rsp = area->vm_private_data; + + if (!rs) { + rpal_err( + "free shared page after exit_mmap or fork a child process\n"); + return; + } + + mutex_lock(&rs->mutex); + if (unlikely(!atomic_dec_and_test(&rsp->refcnt))) { + rpal_err("refcnt(%d) of shared page is not 0\n", atomic_read(&rsp->refcnt)); + send_sig_info(SIGKILL, SEND_SIG_PRIV, rs->group_leader); + } + + list_del(&rsp->list); + rs->nr_shared_pages -= rsp->npage; + __free_pages(virt_to_page(rsp->kernel_start), get_order(rsp->npage)); + kfree(rsp); + mutex_unlock(&rs->mutex); +} + +const struct vm_operations_struct rpal_vm_ops = { .close = rpal_munmap }; + +#define RPAL_MAX_SHARED_PAGES 8192 + +int rpal_mmap(struct file *filp, struct vm_area_struct *vma) +{ + struct rpal_service *cur = rpal_current_service(); + struct rpal_shared_page *rsp; + struct page *page = NULL; + unsigned long size = (unsigned long)(vma->vm_end - vma->vm_start); + int npage; + int order = -1; + int ret = 0; + + if (!cur) { + ret = -EINVAL; + goto out; + } + + /* + * Check whether the vma is aligned and whether the page number + * is power of 2. This makes shared pages easy to manage. + */ + if (!IS_ALIGNED(size, PAGE_SIZE) || + !IS_ALIGNED(vma->vm_start, PAGE_SIZE)) { + ret = -EINVAL; + goto out; + } + + npage = size >> PAGE_SHIFT; + if (!is_power_of_2(npage)) { + ret = -EINVAL; + goto out; + } + + order = get_order(size); + + mutex_lock(&cur->mutex); + + /* make sure user does not alloc too much pages */ + if (cur->nr_shared_pages + npage > RPAL_MAX_SHARED_PAGES) { + ret = -ENOMEM; + goto unlock; + } + + rsp = kmalloc(sizeof(*rsp), GFP_KERNEL); + if (!rsp) { + ret = -EAGAIN; + goto unlock; + } + + page = alloc_pages(GFP_KERNEL | __GFP_ZERO, order); + if (!page) { + ret = -ENOMEM; + goto free_rsp; + } + + rsp->user_start = vma->vm_start; + rsp->kernel_start = (unsigned long)page_address(page); + rsp->npage = npage; + atomic_set(&rsp->refcnt, 1); + INIT_LIST_HEAD(&rsp->list); + list_add(&rsp->list, &cur->shared_pages); + + vma->vm_ops = &rpal_vm_ops; + vma->vm_private_data = rsp; + + /* map to shared pages userspace */ + ret = remap_pfn_range(vma, vma->vm_start, page_to_pfn(page), size, + vma->vm_page_prot); + if (ret) + goto free_page; + + cur->nr_shared_pages += npage; + mutex_unlock(&cur->mutex); + + return 0; + +free_page: + __free_pages(page, order); + list_del(&rsp->list); +free_rsp: + kfree(rsp); +unlock: + mutex_unlock(&cur->mutex); +out: + return ret; +} + +struct rpal_shared_page *rpal_find_shared_page(struct rpal_service *rs, + unsigned long addr) +{ + struct rpal_service *cur = rpal_current_service(); + struct rpal_shared_page *rsp, *ret = NULL; + + mutex_lock(&cur->mutex); + list_for_each_entry(rsp, &rs->shared_pages, list) { + if (rsp->user_start <= addr && + addr < rsp->user_start + rsp->npage * PAGE_SIZE) { + ret = rpal_get_shared_page(rsp); + break; + } + } + mutex_unlock(&cur->mutex); + + return ret; +} + +void rpal_exit_mmap(struct mm_struct *mm) +{ + struct rpal_service *rs = mm->rpal_rs; + + if (rs) { + mm->rpal_rs = NULL; + /* all shared pages should be freed at this time */ + WARN_ON_ONCE(rs->nr_shared_pages != 0); + rpal_put_service(rs); + } +} diff --git a/arch/x86/rpal/proc.c b/arch/x86/rpal/proc.c index 1ced30e25c15..86947dc233d0 100644 --- a/arch/x86/rpal/proc.c +++ b/arch/x86/rpal/proc.c @@ -61,6 +61,7 @@ static long rpal_ioctl(struct file *file, unsigned int cmd, unsigned long arg) const struct proc_ops proc_rpal_operations = { .proc_open = rpal_open, .proc_ioctl = rpal_ioctl, + .proc_mmap = rpal_mmap, }; static int __init proc_rpal_init(void) diff --git a/arch/x86/rpal/service.c b/arch/x86/rpal/service.c index caa4afa5a2c6..f29a046fc22f 100644 --- a/arch/x86/rpal/service.c +++ b/arch/x86/rpal/service.c @@ -173,6 +173,10 @@ struct rpal_service *rpal_register_service(void) if (unlikely(rs->key == RPAL_INVALID_KEY)) goto key_fail; + mutex_init(&rs->mutex); + rs->nr_shared_pages = 0; + INIT_LIST_HEAD(&rs->shared_pages); + rs->bad_service = false; rs->base = calculate_base_address(rs->id); diff --git a/include/linux/rpal.h b/include/linux/rpal.h index 3bc2a2a44265..986dfbd16fc9 100644 --- a/include/linux/rpal.h +++ b/include/linux/rpal.h @@ -110,6 +110,12 @@ struct rpal_service { * Fields above should never change after initialization. * Fields below may change after initialization. */ + /* Mutex for time consuming operations */ + struct mutex mutex; + + /* pinned pages */ + int nr_shared_pages; + struct list_head shared_pages; /* delayed service put work */ struct delayed_work delayed_put_work; @@ -135,6 +141,14 @@ struct rpal_version_info { /* End */ +struct rpal_shared_page { + unsigned long user_start; + unsigned long kernel_start; + int npage; + atomic_t refcnt; + struct list_head list; +}; + enum rpal_command_type { RPAL_CMD_GET_API_VERSION_AND_CAP, RPAL_CMD_GET_SERVICE_KEY, @@ -196,6 +210,7 @@ struct rpal_service *rpal_get_service_by_key(u64 key); void copy_rpal(struct task_struct *p); void exit_rpal(bool group_dead); int rpal_balloon_init(unsigned long base); +void rpal_exit_mmap(struct mm_struct *mm); extern void rpal_pick_mmap_base(struct mm_struct *mm, struct rlimit *rlim_stack); diff --git a/mm/mmap.c b/mm/mmap.c index bd210aaf7ebd..98bb33d2091e 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -48,6 +48,7 @@ #include #include #include +#include #include #include @@ -1319,6 +1320,9 @@ void exit_mmap(struct mm_struct *mm) __mt_destroy(&mm->mm_mt); mmap_write_unlock(mm); vm_unacct_memory(nr_accounted); +#if IS_ENABLED(CONFIG_RPAL) + rpal_exit_mmap(mm); +#endif } /* Insert vm structure into process list sorted by address -- 2.20.1