From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAC69C7EE2C for ; Thu, 25 May 2023 06:31:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49C1B6B0074; Thu, 25 May 2023 02:31:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 423DA6B0075; Thu, 25 May 2023 02:31:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C549900002; Thu, 25 May 2023 02:31:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1A3176B0074 for ; Thu, 25 May 2023 02:31:48 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DA0AD160542 for ; Thu, 25 May 2023 06:31:47 +0000 (UTC) X-FDA: 80827806654.23.25BC3CB Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf15.hostedemail.com (Postfix) with ESMTP id 13DEAA0008 for ; Thu, 25 May 2023 06:31:45 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf15.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684996306; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vjahUor65oLfmRG2kQkvneR7faoQ6HYMm6HzdtgG/dU=; b=hUarVHf9kUHFdLpo2pyVXoXFG/nlefwgmaLAI2Hfk+vq887f/yodaIf8LAfkd08TFPoVSS bjQAzmqLcdCaj7tse079Yz8AKte8bZkefRrdSCMUQI+kLGqeoi7AnYd49go5FVz4iAaloz U4fCiSZtYSeUc/KwEW6F9eTqyeMCfzA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf15.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684996306; a=rsa-sha256; cv=none; b=yJ3TcKQrjXVXknAz0CiPPlh5hRlFszZTQltGRpVrnTcnNfAH9lZu1os6p0GlqcpFSdV5OF Tdo6BcqcKhu8C+dkf6LfawDljGZum5jH4u+RtlH6FhbTsJnLD1Cf+MJnaI3o7gHBAthOku oJWSatM+sj7mBCmubvYoESzXJ/jAv0c= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1631E1042; Wed, 24 May 2023 23:32:30 -0700 (PDT) Received: from [10.162.43.6] (unknown [10.162.43.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8A4C43F762; Wed, 24 May 2023 23:31:43 -0700 (PDT) Message-ID: <11c02123-4fd5-1f70-2791-2c793d45cef2@arm.com> Date: Thu, 25 May 2023 12:01:40 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 32/36] mm: Use flush_icache_pages() in do_set_pmd() Content-Language: en-US To: "Matthew Wilcox (Oracle)" , linux-arch@vger.kernel.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-33-willy@infradead.org> From: Anshuman Khandual In-Reply-To: <20230315051444.3229621-33-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 13DEAA0008 X-Stat-Signature: psqhw9rhgigi78mn76wm4xxdxqt5kiyc X-Rspam-User: X-HE-Tag: 1684996305-381088 X-HE-Meta: U2FsdGVkX1+P4i2OgP3tp6zCS9iKGObZXUJnnxXp2NDD56sQeFurlyu8vQcODVGXj3FalFkeB/XcwHnn+JQOvuDaOh2W/KdApI72bu8Prgb3/7eZNsUhybgGJHBQYe/9eme2kYaSVE/fA1W6/TeT36BvwxKgBi37laAlIVYHFPhMSYIk9wE1jPBvwgiNQWie6iZxdjH/l2H/dbTd4Un0u5O4t3pjeU96tYFwqDbTdzPoLnyLcbF3cRhfXx8XxJ3pdrezxXXTqmqE5+Cld0s7xlWQ52/0q2IphvU/ag0riWKSR9H4zFeyzCYK1yVH7LMFwMsvxjY4qIqkvZhXnNtzsL9Vce5qwez90qhUA+nLTSEWUynpycA5m0a+gWyHDsv8J+y+b6nK2pOGO2oK5x4SoIT+9LTHxSQV2uK0KZZtrMy0f/JqMF5ErYJb3ZgbSNjPCByx+z/3MKiN/CjgBSNCl+8etBJKH2snjvXokm3ea/vXO4u7tN3qKJDD0J7ytuin4qxYwXr/0RSNiRGw8s7Hg9norvWrWvMguUkR0F2cp1O9HgGlw5JR7Wz3zIPNT2mgw7wD69TntOT/p5fNmRCYqZsiPIuKvb3z3Z6Ih6/4vrgt2i7ihupZ2ILiDNPRDVu3SXxNpaHwpyau+TpLu2txnaPP4g41MFNbESslAkMYay8bLv8XcacjCupr9ryCQkByDpXiKuHz7q/tdCWIM7ziF1onLhHjZjRyTF6Oeh1OnUVKahrpNINpGENgtneO/2db5DADbSyAARBMbCtm+XB/smyX1jne3exHMD/Z6WZr8++WoVCjytbMM4BzJiNFDyYr7I8Qk6A5RTmmr/NH2iY+oqdUGMT4zrB1PKyFP+zVlpm4fnaN9zek4C+ZbckTvH3GMR1ETcE3s1lG83XpixEiB660NIf8bdIK1Os5zA3QklUaZTMkqQkeF6wVwplrqnMqBEWIhC68jxoW/iDjPGw R9/X4z0H oeDf9gM+6FDssOuX5BV9oSev4X/qclYp3YDSwMxCLWqK2MjoI8zwiL1v6y4ASzdlFkhJuTiuYTkwfJ+ORv/3pXxOSip5mV00nTaUqFJinuNMtgjv9InsC4jSCbS2Fj2DlrS5ADuo3Vi2xuOk8R1YCuIwUhIo7UOCgMVX+JAl/NT4pk8O0IDbvcJqqznHwxgUy4QiniPaQkFgG/4JqgEABQU81qQSpCQ3qjP713YMKudyYbc/NvdT4225IK/q4g4jhPFy4Dac0eoV5c0lN1vs6FX8+lA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/15/23 10:44, Matthew Wilcox (Oracle) wrote: > Push the iteration over each page down to the architectures (many > can flush the entire THP without iteration). > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Anshuman Khandual > --- > mm/memory.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index c5f1bf906d0c..6aa21e8f3753 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4209,7 +4209,6 @@ vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page) > bool write = vmf->flags & FAULT_FLAG_WRITE; > unsigned long haddr = vmf->address & HPAGE_PMD_MASK; > pmd_t entry; > - int i; > vm_fault_t ret = VM_FAULT_FALLBACK; > > if (!transhuge_vma_suitable(vma, haddr)) > @@ -4242,8 +4241,7 @@ vm_fault_t do_set_pmd(struct vm_fault *vmf, struct page *page) > if (unlikely(!pmd_none(*vmf->pmd))) > goto out; > > - for (i = 0; i < HPAGE_PMD_NR; i++) > - flush_icache_page(vma, page + i); > + flush_icache_pages(vma, page, HPAGE_PMD_NR); > > entry = mk_huge_pmd(page, vma->vm_page_prot); > if (write)