From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70B67EB64DA for ; Tue, 13 Jun 2023 23:15:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E6006B0074; Tue, 13 Jun 2023 19:15:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 797408E0003; Tue, 13 Jun 2023 19:15:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65D608E0002; Tue, 13 Jun 2023 19:15:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 53EDD6B0074 for ; Tue, 13 Jun 2023 19:15:33 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2B910120629 for ; Tue, 13 Jun 2023 23:15:33 +0000 (UTC) X-FDA: 80899283346.19.45D396F Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf21.hostedemail.com (Postfix) with ESMTP id 635BF1C000C for ; Tue, 13 Jun 2023 23:15:30 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ZU1TKS+C; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of rientjes@google.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686698130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8uyQg9FJf1ujfXr9f268eDNpOT0Va/5nApJsu9c/ceI=; b=Q+Ie4R5vpXKHcTNCwE/ZaxDnzJTD/JKAFVLg4JNNklN0pc9pFQ50UE66fwlBhmScJT2LQ+ UmN6JVzNVZH3BfI131AMyhLkDYXYDiLOiPFXekM44xPW2HRDqJWa7R3+a5mWKuREhaR25/ IYA2IbZYyC7/ripljgbCm0vBbs6Ec1M= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=ZU1TKS+C; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of rientjes@google.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=rientjes@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686698130; a=rsa-sha256; cv=none; b=orkjXkXWbb/KobOaj/29KFHWVROb9MYQeZf4xBhterV/2RXAXPYPjVAsuZhQVwfChun6hB I8UPwjEPDNmA3YvNYivukrcLnr9VG3XiAeXe3g+PFo5F/Z0pi31Nch1PXY5PC+kBkr0RhZ aE8mWX3WwjYZKWW/Rzc8WXeOAwIXgAk= Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1b3b9413baaso34615ad.1 for ; Tue, 13 Jun 2023 16:15:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686698129; x=1689290129; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=8uyQg9FJf1ujfXr9f268eDNpOT0Va/5nApJsu9c/ceI=; b=ZU1TKS+Chn34vLFJwibDHRoEMvmMiSzpf0ZDVkri5ROYoqs8V2zaY2gNqlFnh3FM9W DAfgIDaZfN+2aLQtYCYtmoYPiN7JOh7oTfXWyO/zsl4jhbkkwuJgb7gGO9atdO9mcjGz xeycv9Kjlo2A2wW73U+OW03nshU6dNBbPmU1NS9CvyIgiPMHPEkbB3U9BtZlVx5oqvMj 6fLUMYeML4SdpsgO8ChyciHmoZnlyyxqL8fsGl8FExrKWpb+z83m0JOw3AxJdvkM//Yd UgEAXqhcEFtsBq5fHl5j1MGD/WK2Vg/xSiB3L6ZdStIV9vrh9oia48S+bPbcnTMZg0cp LA9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686698129; x=1689290129; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8uyQg9FJf1ujfXr9f268eDNpOT0Va/5nApJsu9c/ceI=; b=a6tJ71dbVInJ1391SCPruIJnBvhYSpHNyA6v/1sNZaQ3P8QbvNd/Mgr1kFtPX3tGEh 0AQhE6NuhjxqKIUWPtib73Z7MnX+mrqys6M2Ssy5MOhxMIDUSx1qR1sgnQNTWhFLY823 jij275egGeiX/jArlcqt52mcWrWkb4cBdUQa8KzS3pqhAa1Y6okjkbrJI6ncaAgWDccW fTH0VGQ4BspKOx2qA08VNpECe2LbCYisZnwD2JqjfcesNilzSIjLvXrChqXPU0kXCXJF yQSuKK8mdUBwdDppuTRpgdpRwd9EJjfPrggEGgV8a1BH0icig+PdpRFd8StfPrJtAvXb MmJA== X-Gm-Message-State: AC+VfDy5CBVPx7m09kS9k5xnoAIN1E22BMXH1n39oqaByCI4R0IL9VqI vZxLdgVZKjDtF1Thl87EnSv8hw== X-Google-Smtp-Source: ACHHUZ48GxbxKpQWOMS+G+8jVGNcR3YlGU7DNqyZtqK/fyTpBYFnk38p2ckYqoGkswYn/FM3bj+NDA== X-Received: by 2002:a17:902:cf0b:b0:1b3:c97a:1e90 with SMTP id i11-20020a170902cf0b00b001b3c97a1e90mr98471plg.4.1686698129085; Tue, 13 Jun 2023 16:15:29 -0700 (PDT) Received: from [2620:0:1008:15:18be:6c84:11a2:b54] ([2620:0:1008:15:18be:6c84:11a2:b54]) by smtp.gmail.com with ESMTPSA id rj6-20020a17090b3e8600b002599ef80ab9sm11613374pjb.3.2023.06.13.16.15.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 16:15:28 -0700 (PDT) Date: Tue, 13 Jun 2023 16:15:27 -0700 (PDT) From: David Rientjes To: Vlastimil Babka cc: Christoph Lameter , Pekka Enberg , Joonsoo Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/slab_common: use SLAB_NO_MERGE instead of negative refcount In-Reply-To: <20230613102820.19153-2-vbabka@suse.cz> Message-ID: <11b6e080-8820-87bb-2686-1c78debad4c5@google.com> References: <20230613102820.19153-2-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 635BF1C000C X-Stat-Signature: cy84nxtgjson4u6kqijncbexri5n7cqu X-Rspam-User: X-HE-Tag: 1686698130-421164 X-HE-Meta: U2FsdGVkX18iPZnbnwgT/HjLHvcgONk+reDyhAkJZ1qDseECngrd0zvuIiDzrewtPWV0bRCi1JZuC2y1Eg1Pu5z3HKLByiuJk6VRupPK79S0yE129ZvN+2UqTEK8cG9tvovlGqc0RAma5aYN3+TqjPIMyp3Iyqoc/dtQUewt1bndmitb9OezAswfP3/4Zwl+pZ3nxS553YhqSgLhdfDV/S5rUNcbOQy/L4EJzrxDaJEbNWVfckqUOgmZ6o8obCPUcMOtZRiGxC2ozatjJIUdeK6h96SbbkucExFDNOXJ9e0etwAOChhSYjCVNO2IZT+a1TcFV7L2jHDGi7Rr1V1e6b8E3dB62UNUSghGWlF9blfmNCBxwATtnyriatLw4SWRJOQuDh0gZA407y0HxpGj/E9Db8wTEaUnhX6tUu728y4rZ2Zadi+Xeuv9OE97ls8KadtoL3WNr+NwE+6dvAeD8AD6ffJQQUcf7yBpkhBKkrS9//fqVK63vfqoItMygZdYyOejk464KcqAJZzfCKDWO/mW0TM4d2o/8/SKpguwd2ISMLNDhUB79+MlRxdr6lOZIuU3spqbT+mve44fkN3157yiEBpg2wXRYJfw7kT75/ZA8PqLgUno0uLW3cEQkXgibmudSN0HE6BJs5wIpHr/W2jym6Sc2gBkGM3YOKnGXdsuWrUrRIVnAtqQnLEPJOtt+TJa8/KS4hzX2xYbFQxxoKevkHK1+rvr2LNrRDiebBMOKcwTD9fSC1pp9zRzpjhEHFWuKtB8UWTMAvn0WlvvxWmKQfGXFGQFZf+5Qpy1aLrPIleiFByAvuubptF6yd/XzJS33Xt6klHTXB3Xy5F58t5nkicuwvDFdP0OLDzd8//AsxxdhG3mu2sxU5Qr4XRJCPjLqU5Y6CF161tWKxojIfWuYUH3K9F/dcTbaiz+KQ+In9mIrKU+izzewIhM1O92fNJbgAAJG4NT4Pe/Ivd mZSQsw70 bZKG86HfUkOaf35OS38fGfL9VpteJV9/pgTxHkyR/T1lfkVSjfwUeV++RijVIlWnR314j+OiA5Mdtdh5EqQhWLZ7+tNfbE48hKhTLroKxmT0jO2MmKyLle1Ptz43w6EIeJaYgA+m4BrC4E2OxBdu/NptOG22u8VSPn946dcWgs4/AGcd+ghYOp/cy74+8A9Op4+ZFGCN9Lw1rzcdgPGiFhbuw3JwIQF2vim0DdNWrYF2p8+lkxFDwg6UjEJ2fGfh6/HCKu7vZJNuhmdPuUfKSR/SoZ7Y6yE+tZ7/eN1iif9Cwru1vAZcx+EKGsVsvQKdObMFnOgnAPWzMth9h5VjdLBOIxX2Tc6f8zCQRqt79lJxESqLETqVmCVnfrO9adNvr0peRa862WbrbN+WQhTxlD4dolat3gFhm8/iRr54E3wcEDE6UDMHBmGxIDGVmgNtLsnoDfWa/8bh9Yve9eHiAbCPUcfKqKCGyEmBYjotKaMIySanwLU11v3hFVZxqEjC0eGWiXomAJy0xPbOxZE/p5Sv/BA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 13 Jun 2023, Vlastimil Babka wrote: > When CONFIG_MEMCG_KMEM is enabled, we disable cache merging for > KMALLOC_NORMAL so they don't end up merged with a cache that uses ad-hoc > __GFP_ACCOUNT. This was implemented by setting refcount to -1, but now > we have a proper SLAB_NO_MERGE flag, so use that instead. > > Signed-off-by: Vlastimil Babka Acked-by: David Rientjes