From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6ADEC43334 for ; Tue, 12 Jul 2022 10:19:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C36E46B0118; Tue, 12 Jul 2022 06:19:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE6266B0119; Tue, 12 Jul 2022 06:19:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AADE594005D; Tue, 12 Jul 2022 06:19:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 982736B0118 for ; Tue, 12 Jul 2022 06:19:15 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5F4BA3461F for ; Tue, 12 Jul 2022 10:19:15 +0000 (UTC) X-FDA: 79678050270.20.C60CF9B Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf15.hostedemail.com (Postfix) with ESMTP id 767C1A0067 for ; Tue, 12 Jul 2022 10:19:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657621153; x=1689157153; h=subject:references:to:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=OXP6Gxel4X0zznGtnqnbKidJ5RmTORG6fk87YX9MpEo=; b=UTM8EfakAwQbqj4CzBfIRB6ZWR6Fvd2180pbmugNmcAcyX7Hk28pCWRp kJU0yk0VSpoWTTtCRkO+iWZmigz6M0lirOvwj4Ih63xl8aYrlxvJL6O/y TBT1C4b2HVUsQL4NN5MB8HW1Ylc0w/NGgGNgs/JzBK9qhfFWNvoiDiWQF HPYUmCbHGGpgcwy6ItlTdRFGaKsN2v4n9mEGqIZ7ReBqpB5bwiNMXYfVY 49mVqSJaIxQ1jbs9n2yloEK19E8Z68ZGktM8i7tE3+bNU2oWDdC10N1BT wC7QHr/Y5F7UXPSJRCOKMAowWEwvN77n475itoeZjev+L/8rYzywAh+S+ A==; X-IronPort-AV: E=McAfee;i="6400,9594,10405"; a="282447086" X-IronPort-AV: E=Sophos;i="5.92,265,1650956400"; d="scan'208";a="282447086" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2022 03:19:11 -0700 X-IronPort-AV: E=Sophos;i="5.92,265,1650956400"; d="scan'208";a="570137438" Received: from rongch2-mobl.ccr.corp.intel.com (HELO [10.255.28.234]) ([10.255.28.234]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2022 03:19:09 -0700 Subject: [linux-next:master 3411/9472] drivers/net/wireless/ath/ath9k/hif_usb.c:251:57: warning: suggest braces around empty body in an 'else' statement References: <202207121528.5ZfB3AVz-lkp@intel.com> To: Pavel Skripkin Cc: "kbuild-all@lists.01.org" , Linux Memory Management List , Kalle Valo From: kernel test robot X-Forwarded-Message-Id: <202207121528.5ZfB3AVz-lkp@intel.com> Message-ID: <11b2e14e-2218-97ff-6298-d99fc644fd69@intel.com> Date: Tue, 12 Jul 2022 18:19:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <202207121528.5ZfB3AVz-lkp@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657621154; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O187KyxBKaxymYIHQJLzsbgg0TvlgYlh61douDFHoZ0=; b=IlGUUds5ih6BAPLyZLVe4+1mecQkTv+NazVZ3SDOT8n2z5AN6eTuPgxWTnFlDDNyurJ2qa aSCQgLlOaFKXf66ZS64zOSYX947k7pD/oiUFUp92IFZn6YZjBwiam1oHzg6GgbzWvt8Z6k 2uOMWPw0nAQZUhZikQp6zGGuMsXNPug= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UTM8Efak; spf=none (imf15.hostedemail.com: domain of rong.a.chen@intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=rong.a.chen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657621154; a=rsa-sha256; cv=none; b=f3TAjtqgl2roKKlPuzlj1vBkRTrLxvcJmfSCQ6W3zEEhyCoxaQow2LxFgZJ5wFKbt9QbVt mif7QKasOACL8ovBPYSrRBUAtP+XLDurXnoVjgk8ulFBQqJw9hB/dKfZ7HmZteOzlxE6QZ MrU6+4g9obTqdh/aYa3jdO/vrDe1sgQ= X-Rspamd-Server: rspam02 X-Stat-Signature: syh6yadmao8pyr1sesoa8ayj6xnimwe4 X-Rspamd-Queue-Id: 767C1A0067 X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UTM8Efak; spf=none (imf15.hostedemail.com: domain of rong.a.chen@intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=rong.a.chen@intel.com; dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1657621153-306188 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Pavel, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 4112a8699ae2eac797415b9be1d7901b3f79e772 commit: d7fc76039b74ad37b7056d5607b05d7cb31a5404 [3411/9472] ath9k: htc: clean up statistics macros config: arc-randconfig-r043-20220711 (https://download.01.org/0day-ci/archive/20220712/202207121528.5ZfB3AVz-lkp@intel.com/config) compiler: arceb-elf-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=d7fc76039b74ad37b7056d5607b05d7cb31a5404 git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git fetch --no-tags linux-next master git checkout d7fc76039b74ad37b7056d5607b05d7cb31a5404 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/net/wireless/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/net/wireless/ath/ath9k/hif_usb.c: In function 'ath9k_skb_queue_complete': >> drivers/net/wireless/ath/ath9k/hif_usb.c:251:57: warning: suggest braces around empty body in an 'else' statement [-Wempty-body] 251 | TX_STAT_INC(hif_dev, skb_failed); | ^ vim +/else +251 drivers/net/wireless/ath/ath9k/hif_usb.c b587fc81a80b965 Sujith Manoharan 2011-04-13 233 b587fc81a80b965 Sujith Manoharan 2011-04-13 234 static inline void ath9k_skb_queue_complete(struct hif_device_usb *hif_dev, b587fc81a80b965 Sujith Manoharan 2011-04-13 235 struct sk_buff_head *queue, b587fc81a80b965 Sujith Manoharan 2011-04-13 236 bool txok) b587fc81a80b965 Sujith Manoharan 2011-04-13 237 { b587fc81a80b965 Sujith Manoharan 2011-04-13 238 struct sk_buff *skb; b587fc81a80b965 Sujith Manoharan 2011-04-13 239 b587fc81a80b965 Sujith Manoharan 2011-04-13 240 while ((skb = __skb_dequeue(queue)) != NULL) { 68185a4b37d8790 Ben Greear 2013-06-19 241 #ifdef CONFIG_ATH9K_HTC_DEBUGFS 68185a4b37d8790 Ben Greear 2013-06-19 242 int ln = skb->len; 68185a4b37d8790 Ben Greear 2013-06-19 243 #endif b587fc81a80b965 Sujith Manoharan 2011-04-13 244 ath9k_htc_txcompletion_cb(hif_dev->htc_handle, b587fc81a80b965 Sujith Manoharan 2011-04-13 245 skb, txok); 68185a4b37d8790 Ben Greear 2013-06-19 246 if (txok) { d7fc76039b74ad3 Pavel Skripkin 2022-06-13 247 TX_STAT_INC(hif_dev, skb_success); d7fc76039b74ad3 Pavel Skripkin 2022-06-13 248 TX_STAT_ADD(hif_dev, skb_success_bytes, ln); 68185a4b37d8790 Ben Greear 2013-06-19 249 } dfa8fc69d92f841 John W. Linville 2011-04-14 250 else d7fc76039b74ad3 Pavel Skripkin 2022-06-13 @251 TX_STAT_INC(hif_dev, skb_failed); c11d8f89d3b785f Sujith 2010-04-23 252 } c11d8f89d3b785f Sujith 2010-04-23 253 } c11d8f89d3b785f Sujith 2010-04-23 254 -- 0-DAY CI Kernel Test Service https://01.org/lkp