From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1681CC27C4F for ; Thu, 13 Jun 2024 05:16:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11E166B0089; Thu, 13 Jun 2024 01:16:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CE1F6B008A; Thu, 13 Jun 2024 01:16:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB00F6B008C; Thu, 13 Jun 2024 01:16:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CC2F26B0089 for ; Thu, 13 Jun 2024 01:16:06 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 56A451A04EC for ; Thu, 13 Jun 2024 05:16:06 +0000 (UTC) X-FDA: 82224703932.16.81E981E Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by imf18.hostedemail.com (Postfix) with ESMTP id 63CD61C0004 for ; Thu, 13 Jun 2024 05:16:03 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=igX3C0zn; spf=pass (imf18.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.45 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718255762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=EtfUUHuwzr569t6VOnXEXdZrMXfWjbd0r5DYKCbZN/4=; b=oQb5XUFTCpYqCQ+muyPdRex9UwSjOpVz9rSrKa/cu5ewUBuW3ckw+o1BkHO6pygWmbsW1m izf8bO7vbvX9kYl7CD7+kj7liJBWQjKJXzLO+jsOwVYizURNZifWgIM74lXjWpyHKqMez8 gB/FCA4l3Ho7aSmbYQbY0cSphq/yNog= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718255762; a=rsa-sha256; cv=none; b=lBk62bZbLSDB3qO0g+kdsx1Qlo2QzYTh1MpUc7IGItwlmMJPa1EdhuDc0EswJcmVpXV0M1 IfyG3OA9fjA2AvDRd/lOEC5ZXxMPA2hdI67+Ui0PIb/0DWYc/0HgXXTCplYRlirL1McA/+ LJPirnO7GvIEDLDk4ROJv+6/q2knKx8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=igX3C0zn; spf=pass (imf18.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.221.45 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-35f1a7386d5so658876f8f.3 for ; Wed, 12 Jun 2024 22:16:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718255762; x=1718860562; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=EtfUUHuwzr569t6VOnXEXdZrMXfWjbd0r5DYKCbZN/4=; b=igX3C0zn3tyKccjESsaWN2bfD2hFT+XmtAuMwvaQD46nkRZDLZ3EBAiVOdGNnFIm0Q FVRw/mQVINRypuKzNl3wg9QWqHSQyCyG3cO6MC8N6zV3Q634AbcQBk7HIsuhM8N1PVZi Nwg3fxIWcOl/HpMK3F05cBThHewlP4FrnhWUOcaQFie//au/d7EWQ3WNYStha3rxEAAM jqC1sDKIqsPjfkEHU4HjwXy1joN1J8gElxIURYW6P+U6g8BSYUAkqDfSU9V0/pmYPeIn s3LrPdGEz0K/K/77e6kR1JAhyeglWhu6K0OV1oaYv/H24FFtm7aZWG26nrXg5Rm9O644 39lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718255762; x=1718860562; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EtfUUHuwzr569t6VOnXEXdZrMXfWjbd0r5DYKCbZN/4=; b=ph01mx3mTtKR6CAHQbYV25lFZeQQR2L0EEsjLDNdVrHygBT8ywVwnnvZIlkUGQ3R7u NLwmS70ouu1VNRJfYrLE117xVX1hnA9sO5N4A3X0X71HGlzbpLXaIqLoEuOwd9ATkWca nE2Kh4GYISI5h2up0sOTMPfGrQFCF/fPagGxyeSD3Yt2LQkEQDKmNMtaokTiiOCyPVR8 uuIRHWiYkRaK0275SFpuBR+wsTGgQ7t7ai0gURXfRtE5LEAmNeFdVrUYi65qUuChOAtT skzVUVBntGyQOLFkBmmaVFQPIBQwOyngVukDpNpHL4ELDSi5BiVt9gREeta/CQrPjuID /IXA== X-Forwarded-Encrypted: i=1; AJvYcCV93n1vEbYAbFN+BZV5W1bEMlFBQ4GSIYQw7XKh0OmWwK1qUVDtIaUdwJxTZksJYMCCc0aRAjFCbO7kWqBHtRTVLzE= X-Gm-Message-State: AOJu0Yxe70JKHtddXdzSZW02FammKY7N4D7hZ/htKmZFxe0jH6FOfpLU 8x7usD+9kiji55v9rOwNjQjr47vmsVHcYPG2Nwb7Iqxg5OzMutnJRw0fhjCBKd4= X-Google-Smtp-Source: AGHT+IGmrXsYGyUzIsflUwKvz92KSSMyEjsRe5mE41CKjjBa7BPtXLLftWzXvMVSbKd6KFtd/vOLIg== X-Received: by 2002:a5d:45c1:0:b0:360:73f4:7937 with SMTP id ffacd0b85a97d-36073f479bdmr610203f8f.6.1718255761516; Wed, 12 Jun 2024 22:16:01 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36075104c17sm573903f8f.106.2024.06.12.22.16.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 22:16:01 -0700 (PDT) Date: Thu, 13 Jun 2024 08:15:53 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Martin Oliveira , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Jason Gunthorpe , Leon Romanovsky , Greg Kroah-Hartman , Tejun Heo , Andrew Morton , Linux Memory Management List , Logan Gunthorpe , Martin Oliveira , Mike Marciniszyn , Shiraz Saleem , Michael Guralnik , Artemy Kovalyov Subject: Re: [PATCH v2 1/4] kernfs: remove page_mkwrite() from vm_operations_struct Message-ID: <11acf031-a778-4ed9-8ece-c6d9aa0bce3f@moroto.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240611182732.360317-2-martin.oliveira@eideticom.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 63CD61C0004 X-Stat-Signature: rcz3qz3dqd5kttsm5dj9s5gqs3j835af X-HE-Tag: 1718255763-618159 X-HE-Meta: U2FsdGVkX1+8xC7picg7rBBOGIi4Mvp6adBZE1mnGi23m9pKN7QLp49vnuXoiWjBgcwiO65wVI9ixwRzrsFT0JY7L1iWkk58Ipq+CDsK5KWFahqwO/UneY+hB9AjuMxQu52ppPvMtV8BSoOIEzdcUkgHZ1dqjlhsz+fAu30CJaUEY/FHhFjnnYyb8eFH+o+e1rQYlgjDeiUBnteh42LWzYWcbgMmL31LiJhSWQcpLwT4o0RSeScbJ3p9Fg0phK8kzXUgJV9mZnahnPzIqATGhNfFYizrq7PeLe2X0Njud2VQrUd9toPLNADNGddnkeio4OOhgp6vD6POxiyi/NQwRYRve8yUc0EV9i4HSYkHfs0v8U62U13YOwJKq+G4BT9DmW06NxXdrWlLZlrjTWA7n0+4kSCg/q/yMIr1GkAI/FqIVNKSyVlFcfJjxch2NfBkRHTx/6/zxpfQnu/YeYEWnCLbeKQaZhhIPXetFPFi8dMrWWHa8wz5JXovBLxkVrmdFsk+KJ6gEl5QEHuXINFDtp1TZeCYHMBIFFkGx53pPY9MOMjpGHEB6ZD8Ym65QxYgOk2fpbuuo7I3azv5blycUS1nikQ61QkXQqtIATgf4bdm4RTCJi025sALiOUF6TaCF9JX/UOsvTZbK0+rYm2HZ9fo3KKp+V+eus018CaMNz8l10GgmA4fbrE7XSR66YbGIonA29NGzgyykRSznZBWc7q8vJSqnvqRKShRUNFFeZGRsvcwGVW/sZKp9IdT2pcj5fq0uU8rmqq798df4GuRSRSS1+9P+ZQyxWA1XvTEckIfDOItyZL0/hdMtobIG/HzJ1KL884mrSROSeqbj57ZXGuwlSPSl9W24d/DrHCitja+ye0WW5K1/KgabvzB38MLJjIKgvd/Wf+BfIr+ig+lJ2k4IBZldr1pYo4WQ8p2Ebn+XG9FVgUaXBr2flaXzhzi+LKuyD0MIVMMsLYimLM W5mPv/Dc oxoF/MwV371++/Pq9NdaHKzzpc1+HYBWyYcdOEVuCAz8xNYoRS9ESPuHa2jtY0V2I0ialLXgSEp8WySz7BnkC17Wm8eF71TQcb2ofY8v0lgPa5hG6ZxEB8DyRPmm4SSl6H72fSmXBxKh9OrjRKWiHwlRCKb8Hdawmmx7ZU+lY272c0wNdU2HDzaX4Wp78JOAS1+JVUJYLPU0jPFmkYjhTTg/UkkwxKXendqiWPNvjzxHSBGLiapxUuOFT/pXfD/e7/bMI0HNaDziOAxU0qzN2tHe17HiUwq0LCIQiGeD82Bv0B6AR0UrnHJL42mTEtBgD5dLSSvSzG52sGsHUxeBP+J4Amf3nVq23bl9yOqbiNUZZwF+OfewQXOo/2YtSjWBxNIxrmXZYuyrsw3ASZE9resuo/c41Y1Ox6NnjAABRpViMMotFJ+dPYx/v9lI+B8E8C1J6J1050+sEBsP/WjOiUqIdqPUZft0rTvu/P9jz/k5C9IbZGoCcUFiWEjQgI5Xc0FurJTnIL29VtxU9Fwc4ieMgQLeqncuGw8IwkhgTQuBkSUjnlAjUaGNuXjzpIjg7evaQUUK0DlVeUgqlrSWNINLLFWlHy+OkweP2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Martin, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Martin-Oliveira/kernfs-remove-page_mkwrite-from-vm_operations_struct/20240612-023130 base: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670 patch link: https://lore.kernel.org/r/20240611182732.360317-2-martin.oliveira%40eideticom.com patch subject: [PATCH v2 1/4] kernfs: remove page_mkwrite() from vm_operations_struct config: i386-randconfig-141-20240612 (https://download.01.org/0day-ci/archive/20240613/202406130357.6NmgCbMP-lkp@intel.com/config) compiler: gcc-12 (Ubuntu 12.3.0-9ubuntu2) 12.3.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202406130357.6NmgCbMP-lkp@intel.com/ smatch warnings: fs/kernfs/file.c:462 kernfs_fop_mmap() error: we previously assumed 'vma->vm_ops' could be null (see line 459) vim +462 fs/kernfs/file.c c637b8acbe079e Tejun Heo 2013-12-11 416 static int kernfs_fop_mmap(struct file *file, struct vm_area_struct *vma) 414985ae23c031 Tejun Heo 2013-11-28 417 { c525aaddc366df Tejun Heo 2013-12-11 418 struct kernfs_open_file *of = kernfs_of(file); 414985ae23c031 Tejun Heo 2013-11-28 419 const struct kernfs_ops *ops; 414985ae23c031 Tejun Heo 2013-11-28 420 int rc; 414985ae23c031 Tejun Heo 2013-11-28 421 9b2db6e1894577 Tejun Heo 2013-12-10 422 /* 9b2db6e1894577 Tejun Heo 2013-12-10 423 * mmap path and of->mutex are prone to triggering spurious lockdep 9b2db6e1894577 Tejun Heo 2013-12-10 424 * warnings and we don't want to add spurious locking dependency 9b2db6e1894577 Tejun Heo 2013-12-10 425 * between the two. Check whether mmap is actually implemented 9b2db6e1894577 Tejun Heo 2013-12-10 426 * without grabbing @of->mutex by testing HAS_MMAP flag. See the c810729fe6471a Ahelenia Ziemiańska 2023-12-21 427 * comment in kernfs_fop_open() for more details. 9b2db6e1894577 Tejun Heo 2013-12-10 428 */ df23fc39bce03b Tejun Heo 2013-12-11 429 if (!(of->kn->flags & KERNFS_HAS_MMAP)) 9b2db6e1894577 Tejun Heo 2013-12-10 430 return -ENODEV; 9b2db6e1894577 Tejun Heo 2013-12-10 431 414985ae23c031 Tejun Heo 2013-11-28 432 mutex_lock(&of->mutex); 414985ae23c031 Tejun Heo 2013-11-28 433 414985ae23c031 Tejun Heo 2013-11-28 434 rc = -ENODEV; c637b8acbe079e Tejun Heo 2013-12-11 435 if (!kernfs_get_active(of->kn)) 414985ae23c031 Tejun Heo 2013-11-28 436 goto out_unlock; 414985ae23c031 Tejun Heo 2013-11-28 437 324a56e16e44ba Tejun Heo 2013-12-11 438 ops = kernfs_ops(of->kn); 414985ae23c031 Tejun Heo 2013-11-28 439 rc = ops->mmap(of, vma); b44b2140265ddf Tejun Heo 2014-04-20 440 if (rc) b44b2140265ddf Tejun Heo 2014-04-20 441 goto out_put; 414985ae23c031 Tejun Heo 2013-11-28 442 414985ae23c031 Tejun Heo 2013-11-28 443 /* 414985ae23c031 Tejun Heo 2013-11-28 444 * PowerPC's pci_mmap of legacy_mem uses shmem_zero_setup() 414985ae23c031 Tejun Heo 2013-11-28 445 * to satisfy versions of X which crash if the mmap fails: that 414985ae23c031 Tejun Heo 2013-11-28 446 * substitutes a new vm_file, and we don't then want bin_vm_ops. 414985ae23c031 Tejun Heo 2013-11-28 447 */ 414985ae23c031 Tejun Heo 2013-11-28 448 if (vma->vm_file != file) 414985ae23c031 Tejun Heo 2013-11-28 449 goto out_put; 414985ae23c031 Tejun Heo 2013-11-28 450 414985ae23c031 Tejun Heo 2013-11-28 451 rc = -EINVAL; 414985ae23c031 Tejun Heo 2013-11-28 452 if (of->mmapped && of->vm_ops != vma->vm_ops) 414985ae23c031 Tejun Heo 2013-11-28 453 goto out_put; 414985ae23c031 Tejun Heo 2013-11-28 454 414985ae23c031 Tejun Heo 2013-11-28 455 /* 414985ae23c031 Tejun Heo 2013-11-28 456 * It is not possible to successfully wrap close. 414985ae23c031 Tejun Heo 2013-11-28 457 * So error if someone is trying to use close. 414985ae23c031 Tejun Heo 2013-11-28 458 */ 414985ae23c031 Tejun Heo 2013-11-28 @459 if (vma->vm_ops && vma->vm_ops->close) ^^^^^^^^^^^ If ->vm_ops is NULL 414985ae23c031 Tejun Heo 2013-11-28 460 goto out_put; 414985ae23c031 Tejun Heo 2013-11-28 461 927bb8d619fea4 Martin Oliveira 2024-06-11 @462 if (vma->vm_ops->page_mkwrite) ^^^^^^^^^^^^^^^^^^^^^^^^^ then we're in trouble 927bb8d619fea4 Martin Oliveira 2024-06-11 463 goto out_put; 927bb8d619fea4 Martin Oliveira 2024-06-11 464 414985ae23c031 Tejun Heo 2013-11-28 465 rc = 0; 05d8f255867e31 Neel Natu 2024-01-27 466 if (!of->mmapped) { a1d82aff5df760 Tejun Heo 2016-12-27 467 of->mmapped = true; bdb2fd7fc56e19 Tejun Heo 2022-08-27 468 of_on(of)->nr_mmapped++; 414985ae23c031 Tejun Heo 2013-11-28 469 of->vm_ops = vma->vm_ops; 05d8f255867e31 Neel Natu 2024-01-27 470 } 414985ae23c031 Tejun Heo 2013-11-28 471 vma->vm_ops = &kernfs_vm_ops; 414985ae23c031 Tejun Heo 2013-11-28 472 out_put: c637b8acbe079e Tejun Heo 2013-12-11 473 kernfs_put_active(of->kn); 414985ae23c031 Tejun Heo 2013-11-28 474 out_unlock: 414985ae23c031 Tejun Heo 2013-11-28 475 mutex_unlock(&of->mutex); 414985ae23c031 Tejun Heo 2013-11-28 476 414985ae23c031 Tejun Heo 2013-11-28 477 return rc; 414985ae23c031 Tejun Heo 2013-11-28 478 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki