From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB78AC4332F for ; Sat, 4 Nov 2023 09:27:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2ED78D00D3; Sat, 4 Nov 2023 05:27:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDDC78D000C; Sat, 4 Nov 2023 05:27:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCD048D00D3; Sat, 4 Nov 2023 05:27:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CA32C8D000C for ; Sat, 4 Nov 2023 05:27:39 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9978412014C for ; Sat, 4 Nov 2023 09:27:39 +0000 (UTC) X-FDA: 81419744238.28.AD7A239 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id C8A5FC0005 for ; Sat, 4 Nov 2023 09:27:37 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Jjn28f4Z; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of mpatocka@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mpatocka@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699090057; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KPvHbOHp2mpCRyE6TKuaQPvtvqV9a46GDausHS+rr5w=; b=VhF/C7q4i248hauvPg7LbBgjuxiiEq7hUC+l1IC6miB72Euv5jFxQUvc0vUz2bC0ROa902 +KmTSKBt9pix7PPXaoscnut85XQCo3H1cYGcb4huwvIvlGOAodOJG66YtXvUDboHgNS1dS bFgho96sB1bHU57OTeJ94maeDHVqMN8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Jjn28f4Z; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of mpatocka@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mpatocka@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699090057; a=rsa-sha256; cv=none; b=27N7ERCdl2eRPwjdw54iHgXfo7lL5FqYeAaWGyKkcEtKcboBQZS/vjr5jo23385VhKVhH9 qfyRCLADy7keEgE+NpnP8UnHZD/wuXlgG4TUys4EH6tDTrVoeShQ342JeebuXz27J0N0HU ojANpiLxt7TGBke3R6DvhBSHR89nAKo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699090057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KPvHbOHp2mpCRyE6TKuaQPvtvqV9a46GDausHS+rr5w=; b=Jjn28f4ZRuO//pbfM1kriU345o5lGLUeTmc0bhhFlG/Xg++FB5XjpsiQRALZcX17j2BwLn H6FQifU+aK890OFNBSdRAl2RSjZRpHXBA46C4ZHrgIG+98L0rRiZ6PvUjDKPr4VqOuUyeQ eI6J9khhwhnNik+UVLGqJ4pFSdDXc8w= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-jDavsoSvN169EGXm_kGPPg-1; Sat, 04 Nov 2023 05:27:33 -0400 X-MC-Unique: jDavsoSvN169EGXm_kGPPg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D466180D720; Sat, 4 Nov 2023 09:27:32 +0000 (UTC) Received: from file1-rdu.file-001.prod.rdu2.dc.redhat.com (unknown [10.11.5.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5140D2026D4C; Sat, 4 Nov 2023 09:27:32 +0000 (UTC) Received: by file1-rdu.file-001.prod.rdu2.dc.redhat.com (Postfix, from userid 12668) id 3914B30C2A86; Sat, 4 Nov 2023 09:27:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by file1-rdu.file-001.prod.rdu2.dc.redhat.com (Postfix) with ESMTP id 3564A3FB77; Sat, 4 Nov 2023 10:27:32 +0100 (CET) Date: Sat, 4 Nov 2023 10:27:32 +0100 (CET) From: Mikulas Patocka To: Keith Busch cc: Marek Marczykowski-G'orecki , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Jan Kara , Vlastimil Babka , Andrew Morton , Matthew Wilcox , Michal Hocko , stable@vger.kernel.org, regressions@lists.linux.dev, Alasdair Kergon , Mike Snitzer , dm-devel@lists.linux.dev, linux-mm@kvack.org Subject: Re: Intermittent storage (dm-crypt?) freeze - regression 6.4->6.5 In-Reply-To: Message-ID: <11a9886d-316c-edcd-d6da-24ad0b9a2b4@redhat.com> References: <8a35cdea-3a1a-e859-1f7c-55d1c864a48@redhat.com> <3cb4133c-b6db-9187-a678-11ed8c9456e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C8A5FC0005 X-Stat-Signature: ag7s7itdiy5ip9kw6qjgf3hhujjm1xdr X-Rspam-User: X-HE-Tag: 1699090057-567330 X-HE-Meta: U2FsdGVkX18Jdzhv4xLx8K0ELe8DdDrtnPbp3qJqkpbaYSlS3vb4wI1OYX2sa6gnp9IBwGI+A/5EOyZCFd9DeOGqN3fEcJGrrTwK7rJD5mD5IlT+qK43nHpIGOSVprxNUNJLMUQW9gjYNtyr4aLYSgF+93B+309Egb8cx2tagpXeemkdgqed1M+9FfBaGFmpy6xiaQJquYl5XmN52J1SoWoPW3ZXslJqaKmXh6/UM/umA2InQDWJeJTOOnqlxVKW/uqRZXzsFL8CD44xADPSMuQnSIxaJt6zlvO7j8GZo5BEFVCBl+0iHMXS4i/oNrUGavEE3ujhHRLZPwIFPrdH6kUyncIkw6x+AslB0OtrHYHisuvr5NClW8XCi4Mq6aKH6zNJXS72XU5eb/DVqURzG8DVYPEa9LFAps7F0S4dohIIkyDMUH+FmGIVDGq4CZ7Yph1mL2F3Lx/zWFeMeSi+umsoy/0BnJ+nXz2lIieEPmvK1LkdUC2MyE2Fvp/bF/A521rzqQWnluGfoBMPKjOpkoh11yr4Q5n68oxcqRUR6m4npBFaK29T8Uve5+Hf9Eqo3wsSLI99+dIEhJe5qamILoQoqb+cJKwXtbl9gmWi1mPs2VICP0Xev1Txcjr+SLauG8zyM/Fe2UtvSqg2KSZq6xGCE5RPgf3bu9fRu8SBJVzrUoZ+6QOG2HpkcM5LvL3dFyRBGFasuZQE4hL52iR+UeOI9oQ2uwdNsJxMNnWyDqkCpbW+ZYC+RSW9MxRt9LwudCuw1B0bbYbIrrSlwIYbuqKnh7aZXoBHNUMwjOqu2xiwvY0+qOwVicmsnl5OMZBAg+mzaUmpmlX3RI4t0rdzlXJk9vupj+gK1BLKPzbWwtkhY5eDA4QomNBxJHISj4V2fDm4bBF8H3lguGvrcFYXAhFF7CrWz+lQF+lX7paE20Ohua4w2UsXA13JyRrcbaFGc7fgislXQhSE0Tqvd0Q CAf9V8ls aYAm+/g/iLoETR8ywGLX9i61J81RgU8AajbS/wY9P6jE/Danb4nlUji+ikK+U+CVcf0KRP1r/BrdwMIDwcXDB4AfqQzmTrDb2cJSr/ieVTF84FResY4+e5oLLN768rBr9T/8rsVTLPX5kZFDLhlmLbQaPwO9ygNhFHrl8kBd0qAOOu5/b7VYoYEMwnXQRtqnONaZ+nvsDcsVfMZLb/xh1vj1ZN0I3+mUI7wbbMi50hc/bshBGPBv0yltGBCuP/UhcCvBjPgHSJzipgMtJo+Q/88OudRgGKwDEAKEp4XNgC+BINYVzrsCnTb7KW0/JOe+UPxvyWaugdsdG/6gf3U0+9WLDeEhdu7ckFjMJDtg6P8pK164S0xnnQN8wGg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 3 Nov 2023, Keith Busch wrote: > On Fri, Nov 03, 2023 at 09:30:07PM +0100, Marek Marczykowski-G'orecki wrote: > > On Fri, Nov 03, 2023 at 10:54:00AM -0600, Keith Busch wrote: > > > On Fri, Nov 03, 2023 at 05:15:49PM +0100, Marek Marczykowski-G'orecki wrote: > > > > On Thu, Nov 02, 2023 at 06:06:33PM +0100, Mikulas Patocka wrote: > > > > > Then, try this patch (without "iommu=panic"), reproduce the deadlock and > > > > > tell us which one of the "printk" statements is triggered during the > > > > > deadlock. > > > > > > > > The "821" one - see below. > > > > > > Thanks for confirming! > > > > > > Could you try this patch? > > > > Besides min3() being unhappy about types, it works. > > Oops, should have changed the constant to "ul" instead of just "u". > > Anyway, the overall idea makes sense to me, but I don't know the swiotlb > stuff well. > > Christoph, does that patch make sense? For reference: > > https://lore.kernel.org/linux-mm/ZUOr-vp0yRkLyvyi@kbusch-mbp.dhcp.thefacebook.com/T/#m8d34245e0eef43f8e9fe6cba6038d77ed2a93ad6 dma_opt_mapping_size returns "min(dma_max_mapping_size(dev), size)". So you don't have to call dma_max_mapping_size explicitly, you can leave the file drivers/nvme/host/pci.c as it is. What about the other block device drivers (AHCI, SCSI...)? Should there be some generic framework that restricts max_hw_sectors according to dma_opt_mapping_size? Mikulas