From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DB1BC83005 for ; Fri, 9 Jun 2023 20:11:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C59118E000A; Fri, 9 Jun 2023 16:11:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE27F8E0002; Fri, 9 Jun 2023 16:11:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5CE78E000A; Fri, 9 Jun 2023 16:11:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 904BA8E0002 for ; Fri, 9 Jun 2023 16:11:32 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5B8F7120304 for ; Fri, 9 Jun 2023 20:11:32 +0000 (UTC) X-FDA: 80884304424.06.8A7FD2F Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by imf16.hostedemail.com (Postfix) with ESMTP id 8C673180020 for ; Fri, 9 Jun 2023 20:11:30 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="d/6rBPd7"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of hughd@google.com designates 209.85.210.54 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686341490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BNhoN+f5/2l7cZy5Z84aZKirbXfCn9RTJhC9+NCxT+I=; b=TdEDW5QbDHHjNQumGVfIWj7GV/btDlZSMwRjoaXY8/77cHXshn7wEBT/7tkkSl7RWgrDWy //SJudhwtx89/u4h3RcPo6CmzP33Xsr4ple/Zbsduia9Mj4Z9JuTLY96dU5AmDAbhEsIvr W+mPXsQybnf4/dwHg88GTiUAfxhMSu4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="d/6rBPd7"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of hughd@google.com designates 209.85.210.54 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686341490; a=rsa-sha256; cv=none; b=zrB4UOHPOLLT5DvhMRWMvn6is1boB+27a1X+TQm3CklGqfuJVJwNRPU1wr9DRK51xwE5gL iAlbEZ4H2hJwusm1S/B9VR3SE/BVDfICzhSie7iT14T3MRiFg2CvEUGL6FIVoWmjvBKYTf piRMf3H2bXBeah4MkrQRm+nrwJ9Qr24= Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-6af93a6166fso967215a34.3 for ; Fri, 09 Jun 2023 13:11:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686341489; x=1688933489; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=BNhoN+f5/2l7cZy5Z84aZKirbXfCn9RTJhC9+NCxT+I=; b=d/6rBPd74W0HkXu+EUDXKlSN8o5i+l5/F1a2slQZafKk6WIPKC+wuMB7dADlBrLtyM poQQG5ScaC8fvmLhUCZ/gWgJ2zRtH2r9BnAWYzXdM4rU7YvJQBRC7IU4TT9rx69EyJvn bhsACpIFEGAzoPPyJ+wOA4XH9SOLnaEUZKbWCj3APhoigWRN+ZJyFwpi133I57LqMr49 EzVmuFEGPpqnoh0Yf5uVi5LN2K4tVOwsnTjiNeOpbpg21u6GsLbyz3+q+XIiA6kykJvi 3q3m76KPzFg3UA+XER4MD7yzah7yrXozpiQErF+7+qymD5C7n9vsHD+qXqS0M4Q1ntOo dKzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686341489; x=1688933489; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BNhoN+f5/2l7cZy5Z84aZKirbXfCn9RTJhC9+NCxT+I=; b=PDdwE8J8E3LO1AHXztxT2FdVCDfuNp1WKv9B6UFOfNQp4eGlvu0ydKOEXf0x6tuCo7 +Ed1dzpCXyMHUeoylIUQLP6L022PoMCuCMx5fIrzZCbkprteL0K9JnLJYqhv6s9DHuAU CIZFv7H2grJbMFytHIDi61Ev2Rn9lNxbduX6yVUu2fAdlIAHJpQqENvEdUSMx11Z8P80 LB5d3JlcO6nDB3M4m8smLsR8BJpBo/kyh05qfBbWasfeZkDSwBuIy+JTVCqrVkVJTpa0 xKCckV8lgAq9bfh+orvRaNas7i0zVVlo6M3EVxmDxlP5Wf7dTLHPIyIb3m4mDzw6lxVp FYCw== X-Gm-Message-State: AC+VfDykZe+10fEoAApxUXfX74LwVzlRYo2bSxz7X9kqnpNQ+LNCse/D XCCgXx/c4hh/PS3nq/Wa3ijOPA== X-Google-Smtp-Source: ACHHUZ4XnN4b9GdYKVqAKytuaB3+barXDfYXv6W/j7Dy4qv6jA09xFIrqfasC+7NO0E7Y5ouP+kt4A== X-Received: by 2002:a05:6359:1e:b0:129:cd33:9d5f with SMTP id en30-20020a056359001e00b00129cd339d5fmr2065211rwb.28.1686341489426; Fri, 09 Jun 2023 13:11:29 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id a74-20020a0dd84d000000b005463e45458bsm808484ywe.123.2023.06.09.13.11.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jun 2023 13:11:29 -0700 (PDT) Date: Fri, 9 Jun 2023 13:11:18 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Andrew Morton cc: Hugh Dickins , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Lorenzo Stoakes , Huang Ying , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 28/32] mm/memory: allow pte_offset_map[_lock]() to fail In-Reply-To: <20230609130632.ec6ffe72fc5f7952af4a3e54@linux-foundation.org> Message-ID: <11a9744a-e7f-33d0-474-c2f2eb7e079@google.com> References: <20230609130632.ec6ffe72fc5f7952af4a3e54@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 8C673180020 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: pdw1axg817w9w4n3ns9ahibdto3p1odw X-HE-Tag: 1686341490-516104 X-HE-Meta: U2FsdGVkX1//ac5gAHKdUiRRyP2m/J9/m0GtEqMPc1xZamjmMZhO1Yi77hx43IZsARWF4WI0DnpVXDArhRxlmasdd91t0aM6FWhaITvL3W4T548/u2EEiyE58OxhJAqtCVzWNVyV3kSZhlWG0IEEyZY6M9tJHg9Z9v0Ga9fx4m+rqn+P0upGWKCQfbL/7utb4+GejMkzV31ag1QfhwlKioWGg09MywWBpOLheJPCkSUlj1Mvb86MKNFc7bOEYfEhytsx55CHb5vSUOuPb4lxTb2aM3Xnc6LEgJGk9QRCF7xJaAeeu4cbfyDSDJiqwWM+zz8/XWQRzN+B3lwxQwXxxjhPpIc8zMmUcZoEJPB3jqKODDRspo8ae+rgDr/Olwxw1w2TzC5Qn/ilnSKrrooHLey7K8aJbvlEUuxruUL5SO806EwruvYUmCDNotNhP1zeSMb8o5vXqYVeI8ckbGe3i1xNc8o/l0TNcthnvoC6THiSkKVKHyb6lqmZie+oUzk9oYZbeY8UUcB9E7fuqQQ0NiIX7Uke0QrsFxwEUyyYpc2kV4BslBMKZ9z9sYS4A/KqlHqp25/jLY0g0VdMJircRfMg5yh7bDZFtWiXhXpMSlBx6cyHJ/F1Sxm2JKYCaG18CHc8Fz1OBpoeuuAj+Sh/tYJq1FlixCg/HKsZ6YWIi1BTy1YnwE/qMPpMhiOEjU3+BIHQPmjzlWfVU2dSvIoKIH/+WNDuUR86JMDaiM+ecZJ7jgYJnH9gcxZ7hy4EVyjAEUvYUrr07Ua9ZaWRkcQdkMbIfvOQ3POkpJR+3IDiauzSCe0gHIgwUzzZXh7ZVfvDcD5B1/3VQo/l0BnFfacqgRxZsoByIeM/O9ponu4ajZKovuBO9h3tXEFj7lnFyUnhIxDHr1BCuweXv8B8ZxnFUGmFghKv4A2kAho6YGMIObxLU+2dQjLR5AXyG5SinFA5hTBL2b4kAzBV/L8Q0U8 EoU4lcgD 7+LuZYS/r+qUuM/C/mq6CoGdQW9jDSFyZfic9GW98VF62dQdHWSrIyMaORy2Ojx1jpd1sq3oOQoPgAIstaGRT70wvwoRJOtHkqOlbunV1ZbUfFB4JnLbCacjIkklBRw6Wn+e/cqyBbsz4O7bNjuQy1fjxasAEdBaOydmtCfLH3rV+uK1a/Eyfox8bv0gbt3Dm9nQPh1XcqLo47ktVr/lRyZb2ob5D3sOB7tsyhyFiUpmazf7b3kgDpdsCEj+MsnP6+t0Rs/qRuFZ09YNj+Mazryt9fiM53aV8xUqD+5AzGXRzH8/XyjqTk9FRcvkU4v27f82eENGF6x61X2gmds1ndgZTSzUsM1xB10Eq4Js5wbyzUXxxnln5EyJgeb2vX4c9mUCgmqCPdl+i/hzd0hFm7PdpKuBMuxVD/4IcIF0FTvJvJLpavseVubLhPbneBbcVsSgxZ/s3DQ9IonRLcCPRAu/k1YformyMvlIOXgbQlfFg0+WXiaMXghxL9hTCU9sjTjdh7L5Hq9N6zdiGf/GyWQmZGeBQJoPxrDoTOy1ZmWgbxSk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 9 Jun 2023, Andrew Morton wrote: > On Thu, 8 Jun 2023 18:43:38 -0700 (PDT) Hugh Dickins wrote: > > > copy_pte_range(): use pte_offset_map_nolock(), and allow for it to fail; > > but with a comment on some further assumptions that are being made there. > > > > zap_pte_range() and zap_pmd_range(): adjust their interaction so that > > a pte_offset_map_lock() failure in zap_pte_range() leads to a retry in > > zap_pmd_range(); remove call to pmd_none_or_trans_huge_or_clear_bad(). > > > > Allow pte_offset_map_lock() to fail in many functions. Update comment > > on calling pte_alloc() in do_anonymous_page(). Remove redundant calls > > to pmd_trans_unstable(), pmd_devmap_trans_unstable(), pmd_none() and > > pmd_bad(); but leave pmd_none_or_clear_bad() calls in free_pmd_range() > > and copy_pmd_range(), those do simplify the next level down. > > > > ... > > > > @@ -3728,11 +3737,9 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > > vmf->page = pfn_swap_entry_to_page(entry); > > vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, > > vmf->address, &vmf->ptl); > > - if (unlikely(!pte_same(*vmf->pte, vmf->orig_pte))) { > > - spin_unlock(vmf->ptl); > > - goto out; > > - } > > - > > + if (unlikely(!vmf->pte || > > + !pte_same(*vmf->pte, vmf->orig_pte))) > > + goto unlock; > > /* > > * Get a page reference while we know the page can't be > > * freed. > > This hunk falls afoul of > https://lkml.kernel.org/r/20230602092949.545577-5-ryan.roberts@arm.com. > > I did this: > > @@ -3729,7 +3738,8 @@ vm_fault_t do_swap_page(struct vm_fault > vmf->page = pfn_swap_entry_to_page(entry); > vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, > vmf->address, &vmf->ptl); > - if (unlikely(!pte_same(*vmf->pte, vmf->orig_pte))) > + if (unlikely(!vmf->pte || > + !pte_same(*vmf->pte, vmf->orig_pte))) > goto unlock; > > /* Yes, that's exactly right: thanks, Andrew. Hugh