From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6DCAC36008 for ; Tue, 25 Mar 2025 18:03:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 701FD280040; Tue, 25 Mar 2025 14:03:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B19A280005; Tue, 25 Mar 2025 14:03:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52BD2280040; Tue, 25 Mar 2025 14:03:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3301D280005 for ; Tue, 25 Mar 2025 14:03:31 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 905C6502AC for ; Tue, 25 Mar 2025 18:03:32 +0000 (UTC) X-FDA: 83260845864.05.62E4DA8 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf06.hostedemail.com (Postfix) with ESMTP id 72BB7180020 for ; Tue, 25 Mar 2025 18:03:30 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="hN/Qp/bO"; spf=pass (imf06.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742925810; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2OFHC4oxGhg/toa6bpGo7PeSs9DiV3rh5O8lrz2FAFs=; b=jJMntGlel86zbf0gS3ldJdvT8TB7ixt4DAtE0MprJ2oAsG3hwDoyuAjyaED4Lu4S1zCHhh DNciEiC4b4duWuAVBAZbsDBN9k0zP7bp9seUxmXM/lGDLs+QGi0YvgzvABaaypnBC5e55D kNzjNJV7zOnXNZ4obcMlIQp3dPkm+5o= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="hN/Qp/bO"; spf=pass (imf06.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742925810; a=rsa-sha256; cv=none; b=7DPIEyDSZvyA7Np5bKtRZDC+LK4jv1EQpAOrvq1MCG+B3dVuBd2QOxtYSIHpBqEla4/N2z o56IM9NrZhJkta9kQxZWhtOKr/YY/QL9qYEQbkbVUszDo+9g6jtQVGTba5W20Q6MXI002+ 1RjkVM+1d2oN1rFclDCS+iFxCd5J220= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-225477548e1so116410915ad.0 for ; Tue, 25 Mar 2025 11:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742925809; x=1743530609; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2OFHC4oxGhg/toa6bpGo7PeSs9DiV3rh5O8lrz2FAFs=; b=hN/Qp/bO79+moTKVwhVE48nYcBOfPfCHNUVK4u3r7zblICJ6sFNNALzoDXutga0vwh yIEREhZXBS2jP7YeQnHkQgqQljsUD0cUbU81zx5upvE1xo2AUhK8Rozj8hcuPhobIX98 oq9427Bd6Eo4WFUrcIo14CTTa9iZQIu0b8v2/iqgWSxDPnrELDIR9C9DUABbnKjWIQyS 5eIxPemQBZXjMZxLsKoSa8atIn11xQy1MlKYCZ3Y7xUVq0/DBee+JAWfyO+WZGEV9zPM iV1Q1UIC0Gxv319YRGLdpWi53pKZo2z3xBwCgWc3+Q7TiT3WEzI9JUHfDtWE1BlgSS6n UAcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742925809; x=1743530609; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2OFHC4oxGhg/toa6bpGo7PeSs9DiV3rh5O8lrz2FAFs=; b=g5SXEF1Bfzo56kKmmI0kimEtV2jiVdEtglXBHn9Vs7TO4c660qYzFg0W00LofOoqTT Zg6SI6e99l6UrKqqxrMPGDQbsXTkHsooF9CVjzICu1s5EZKTBtd55Jl8cVH9SW6nhP9P jclBG43KHyNqhtLznJWjDcigjAbOjZNWB/Oe+p+6yTuA8G+RQ5Yxov4xGfHNWgbcQJBq UVzmY5nJhq7b6U0AJXwi+pTKGcD5J+Wy4mh25euMwr2JOYBXuV06l8k/bgMwPau+Fs+x jY0KxRbzv5ji5ovJrmYMj9Fkz3Y1TYZU4QkBn2B8mil+3p6gThiIZNzQk1YTygwgMuc3 1zZA== X-Forwarded-Encrypted: i=1; AJvYcCXZ1HCclDPYwR7BF7ufuniV4TF/QyrArOsrgHQIzCwb7WEdFPe27IKaz3mMlX/2uB3mmEATe1MZ9A==@kvack.org X-Gm-Message-State: AOJu0YzP4DnM72lBU3kq4gqawVaiK+e2eN/mPruqCjFMh6FOVBoUku37 uO/h3fLqGmbKdcks4QDiFgsHIrTISF3Doisg4BkGZojXWfOqZ+2k X-Gm-Gg: ASbGncveVQ/EROY4n2678bAM8yubK1P+1ZCQJcyG3/zsxXpa4VLnZ45laGBhQ9VqeGJ k0S/BIoA4H15YqmmmmDMQmKjbirCHILKfh9KEYQ4cVlNkECo4mOnBfylUk/Fq1pJ6vpnGhaM7IB uyPQmLlSMqzO1lVAapOxx5gSWjSQs+tfFs7atDpmgNjr1/8KSjBln1aq+C1sGvqPIS8ni0U5jtM OTebCQ3bENhYFGSuzxkASRKZGfgED2m3nlGgWLGUox61ZnQa/UlQ/3HN48ci2i/NGd77lCEMBLC XQiAL1VaEChgk/Qn40L1JtvrOWD2AsujyDHSKPZH9XOnqTx4ascELE/5yi09r8wGBpmSNUwSCKo Yq1bEOzR8vel6t7a2VlDn+KLWSg== X-Google-Smtp-Source: AGHT+IGRcIkV+T0NdTkjungee/b9D2PnTIi31LT82NdWbq9QwJcA4yfw4vLUE/v7qpb0mRjHF0RbHA== X-Received: by 2002:a05:6a21:688:b0:1f5:7353:c303 with SMTP id adf61e73a8af0-1fe42f2cbf3mr29019788637.11.1742925809037; Tue, 25 Mar 2025 11:03:29 -0700 (PDT) Received: from [192.168.2.117] (c-67-188-127-15.hsd1.ca.comcast.net. [67.188.127.15]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73905fa92bbsm10913499b3a.16.2025.03.25.11.03.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Mar 2025 11:03:28 -0700 (PDT) Message-ID: <11a80d4a-9776-4a43-8c61-5cc1ad4abbc7@gmail.com> Date: Tue, 25 Mar 2025 11:03:26 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4 v3] cgroup: use separate rstat api for bpf programs To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: tj@kernel.org, shakeel.butt@linux.dev, yosryahmed@google.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com References: <20250319222150.71813-1-inwardvessel@gmail.com> <20250319222150.71813-2-inwardvessel@gmail.com> <4akwk5uurrhqo4mb7rxijnwsgy35sotygnr5ugvp7xvwyofwn2@v6jx3qzq66ln> Content-Language: en-US From: JP Kobryn In-Reply-To: <4akwk5uurrhqo4mb7rxijnwsgy35sotygnr5ugvp7xvwyofwn2@v6jx3qzq66ln> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 72BB7180020 X-Stat-Signature: u48zzk8s8nmw3ni8opg8imghqrt6pnu1 X-HE-Tag: 1742925810-887452 X-HE-Meta: U2FsdGVkX19BBxU4yih2UoJNxZGvr7Wkwnwh4Y3qY4gVATvPMiIshNVK+Z0LrqrL3kwFZJklcGkTp48WMdpCQuKFIyPz2ges9qS2FFQBERvrk/C1ty31h3A3cqtW3oCxKbpqsfvq4AhNerZFEEKSvMvm8V7VxqMGJVDVyY31rNtkNgc2bjM9Zx7a2UZetBUOPIC6D9q8ZEEK0jnTp5EqQ40aApHgJiCvTFaoCKODmMUjEwFdZujh6WV30ANhWc/aZ8EeuN7yNONxVXx3bgTO5VGSSRwrSNv01W3MpmGdMr/Ksv4q//ByCUj1g0p2KmJq45dTMZfQgl5PwAw47JdV2jCdKzw9BKLQLor18vNoXHMKWsCZ0GU2i1XI1BBzONj+IXJOup9EocCJCPp96aUZi49MAHO0bStKsObOCle6cZtQuziqsYEJpjeY5525UxBqRQPxfiSHL2qp3uR9tJIZaXcCCFsiqRz+5XUCPLPnAjflHHDSehKbDSD3vzcgoHYL9VZN4EKbiKRbjmvf69SbWy68+QjEgxgt4kQA+zoLffWhQciWPdzenTAkKRjQG/Q95UFeKpXvXcUhgD9rALs69Vk8kNOAryetk0VooiiBusAJ8E9mEEo0prZzTjcKd8CY0C0W23dSOzb9119tm2S/wry8DLsS/THPiHWczQpp6Sk4hV1SN9MNoJg02C0Vn0la120p1hA5480glLTjqSDrpe5r7UU7aSnAyX/ho89uH5fWcvffuJW19qCSE+IQNQDYy61Y4FM3NfiwIW64UEZdw7JtjfG7TFx3Qwm4LON5v2Fd3hHfLjHPboENWcupg1DTLosPIwV6EQ62watBmLD5Qi8FMy2PBeppJyh5Dhlf+nLIRpFUYPGC+khAQ1ZRPHofG70neRt6tVOJcEXzV74iwKiUorlcWnj8IUYSD94tj4fKxugcMXv+KGbNHc0hgoDOJl8gVvZXljdKhfU5mdU 144g8tjM DENvg7I1wtqq+xvL69UIwOXhUXPR0O4tVo5u5Z4SIENM1wISEzeHEC3GCvCJ2NHreViywVXsSE47IFqzRnu8dRpirUZTYWZYpXAT6ylTrsmpSGkA2iFXHENORsc+3nq0wJ5Awxee4/1QVc8YJeT5GbHuezCtvMP/oz6MtpVs8+Ls23p6ladUn706ng4Wmh6kVFUAuJtyXmMeHSaAqCGq64OYKT+iA88VKKghVQXU8XIL9akGB6ULZ39g/IwOdXhm2vCck5y8YuTpQnbv8lJ0BxKDaYDVuiaeTZW440vh0Qq+ykQu/L0LaxQZ4JX1qKK7LCJ1acqyiKttHEQRNIKOgR07LoFDB6gRHGs27WGZERfPV861Rk2KOuvVQ16u8xUfLhUkJUnyINI9LeR5ERUiHhZbDOMcSAI9yzyr9rqOvy3mLdUNBOS33vl5XANir+N1UdVcn1wx4+6L7nJJzIVwiUVUEb0ET+SxT30R4zt6moiCPIaBpas1GmHOVmS4f+ahOYDVaEfXVU2pG9vc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.047663, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/24/25 10:47 AM, Michal Koutný wrote: > On Wed, Mar 19, 2025 at 03:21:47PM -0700, JP Kobryn wrote: >> The rstat updated/flush API functions are exported as kfuncs so bpf >> programs can make the same calls that in-kernel code can. Split these API >> functions into separate in-kernel and bpf versions. Function signatures >> remain unchanged. The kfuncs are named with the prefix "bpf_". This >> non-functional change allows for future commits which will modify the >> signature of the in-kernel API without impacting bpf call sites. The >> implementations of the kfuncs serve as adapters to the in-kernel API. > > This made me look up > https://docs.kernel.org/bpf/kfuncs.html#bpf-kfunc-lifecycle-expectations > > The series reworks existing kfuncs anyway, is it necessary to have the > bpf_ versions? The semantics is changed too from base+all subsystems > flush to only base flush (bpf_rstat_flush()). This patch was done based on some conversation in v2 around what to do with the kfuncs (bottom of [0]). It's true the kfunc API deviates from flush-specific-subsystem approach. Dropping this patch is fine by me and I assume it would be ok with Yosry (based on comments at end of [0]), but I'll wait and see if he has any input. [0] https://lore.kernel.org/all/Z8IIxUdRpqxZyIHO@google.com/ > > I'd perhaps do the changes freely w/out taking kfuncs into account and > then add possible reconstructive patches towards the end of the series. > (I'm not unsure whether the modified btf_type_tag_percpu.c selftest > survives the latest unionization of base stats.) > > > Michal