From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62765C71157 for ; Tue, 17 Jun 2025 11:27:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F24236B0088; Tue, 17 Jun 2025 07:27:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED4CD6B008A; Tue, 17 Jun 2025 07:27:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D755E6B0095; Tue, 17 Jun 2025 07:27:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C2F396B0088 for ; Tue, 17 Jun 2025 07:27:26 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 44CFB121BAC for ; Tue, 17 Jun 2025 11:27:26 +0000 (UTC) X-FDA: 83564666892.02.0E063EA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 98DD214000B for ; Tue, 17 Jun 2025 11:27:23 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O29mdIGN; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750159643; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cBv04AzRYwR2RH99FDKl6zOhUz1eEJZnFDjDjLqLuvY=; b=PbUTzfljVw4DWKcl+MJol5wSdFucdnwTqRuvXxyUPbLXlO0x5GBG8GCuTf85A5w4F2jPjh ++soCgJPtmj07ocNN7io+v51uwOLtBDYjDZtcoPWkeU2tqJZ9YGELWXYrfTD1dJue6RwDt t2iqO/XMxw8SzYSSVjLM81BIuZzP+Xg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O29mdIGN; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750159643; a=rsa-sha256; cv=none; b=X/cFE4TG5qGO0n8WRdXQhOuObKUN1i8Gec64OZumcRiVIFTC/uVI/1XZSQAXmDXOlkyE5R MdtjvZe6ng983eBy+4flHLWPB10Y2nxax39BCBFsQfq+1nvyioIUo3W7izsEcKXXzAxJHN KmFO8a2/b6ZLODK6EolXK6HNeiJ9Whc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750159643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=cBv04AzRYwR2RH99FDKl6zOhUz1eEJZnFDjDjLqLuvY=; b=O29mdIGNmhO3wXuo6YiM0rtgrDGKrrkprl+07m4okGkL20lX3+r1jdAJKDho8U5WAJ5IDr pxp2FsDbkmONuJBpz7+PqrMATlfogSiJ7PdBR+Sbo20p19XQCYBotAEc0Hp7tZxS9cd7lZ f3kbpWVGNl/zq7YVYp50eqpCo2sZFn0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-269-0EqxC4rxO_y9Jm1XGGnsqA-1; Tue, 17 Jun 2025 07:27:21 -0400 X-MC-Unique: 0EqxC4rxO_y9Jm1XGGnsqA-1 X-Mimecast-MFC-AGG-ID: 0EqxC4rxO_y9Jm1XGGnsqA_1750159640 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-451d5600a54so45970375e9.2 for ; Tue, 17 Jun 2025 04:27:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750159640; x=1750764440; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=cBv04AzRYwR2RH99FDKl6zOhUz1eEJZnFDjDjLqLuvY=; b=XzoM/+DtKXhP32IFeGWGjgmhGLYshSyl/dwd/gSvdLTjSGPRC6Zrqsezmx03VIPwwy kjK594X8dj52zCnLk7ccDhofoGMTY0b0SEzf+y5dUXB23ukSE9KmgmVRBeUDY/kWhRJz OwEbQ//msYcOppupsYKOGlHzAWMGQaA4u8B1Q9v+BUdBM29cSDvqDELsnD/uOitTKCFJ /t7WIMvdE23JVL47FTqYYsY00liW8l8VMnJs90+z/qRtiXyatB2xL3WHUPfky8aRVn3a YWeAjHyJsdPVyddyzWU02+bSkqVU2FtRatsAGY8rLbTmCk2h/8518mjVaeoHs50QKhQ6 G8cQ== X-Forwarded-Encrypted: i=1; AJvYcCVKr1fx5VyW88yBV1zYZRQrtFqbveEn/uqSpZZ9MkbqUozM5lChu4ahGRi87gVnJD+vUJ/ECNKO0A==@kvack.org X-Gm-Message-State: AOJu0YwvVsm7QdZYtC0UvKupgdk4KLcmQCRLPP45PSwjwDXF2H+B/kUy 50jy8BIM149BSPNPA8TeNn201QRKx3FF1w/cOWI1bgNnX347zzlETNsIIhpSG19pc0UjnqARYm0 ycT6h7duY1FKWFvByLIzxMmqvG38UfAYQPPI7xtpIjP2SfNFd//xz X-Gm-Gg: ASbGncv7tK/hhEbV3f7jdqcNgQcMZYHLgIMMF+S+x6pT41SqA2gCNg77sgELka5p/eV f0Blt5Ftlz2/nQNyE7xYm1mubXdV1zvvKFl/P6TZfg+OhjeWGNuS1BFXENvDKy3xEJECC3z5jjX IV5fapPy59ukgQAjU8hCxdAno4QzncbZL7uG9yeaUF4Lyak8aF2ewUi/pL1YcOvIpk5z3IZrDGX bpI3YY7QdViYu91usbgjquwgnO1wzdI2CDaowxZfpEk52D+4+3CdQnfoJOeGZh47/i85WmxuoYM Z2sJFyLIagIqrG5Mndzlas2yfiv7ZK7pbjrNrntF95vLYph7IQEFAdlo2QPixFUwYVk3bsHtTuv UYOXyqvcOqlFAp2QFgGcz/QuM0sKCSehIYUbTNpqvezJjT1g= X-Received: by 2002:a05:600c:c16a:b0:450:d614:cb with SMTP id 5b1f17b1804b1-4533cacab63mr109784165e9.33.1750159640412; Tue, 17 Jun 2025 04:27:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG4nTkxALRXp8tpUHinMo02ZnDSVCD/WKB2nv0p0hL3MZb2bfGKStHwvst0rB5V378o7CAU6w== X-Received: by 2002:a05:600c:c16a:b0:450:d614:cb with SMTP id 5b1f17b1804b1-4533cacab63mr109783975e9.33.1750159640056; Tue, 17 Jun 2025 04:27:20 -0700 (PDT) Received: from ?IPV6:2003:d8:2f31:700:3851:c66a:b6b9:3490? (p200300d82f3107003851c66ab6b93490.dip0.t-ipconnect.de. [2003:d8:2f31:700:3851:c66a:b6b9:3490]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e09c2ffsm171012335e9.18.2025.06.17.04.27.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jun 2025 04:27:19 -0700 (PDT) Message-ID: <11a1d0f7-ef4e-4836-9bde-d7651eebcd03@redhat.com> Date: Tue, 17 Jun 2025 13:27:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] mm,hugetlb: Document the reason to lock the folio in the faulting path To: Oscar Salvador Cc: Andrew Morton , Muchun Song , James Houghton , Peter Xu , Gavin Guo , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250612134701.377855-1-osalvador@suse.de> <20250612134701.377855-3-osalvador@suse.de> <44f0f1cc-307a-46e3-9e73-8b2061e4e938@redhat.com> <1297fdd5-3de2-45bc-b146-e14061643fee@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: S-5aifSeuCzGGttVkson1YCnDPe8BWRcYhH8fZPlRKo_1750159640 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 98DD214000B X-Stat-Signature: p8bzcaqjgmbxip498ix6g98muwt1wh93 X-Rspam-User: X-HE-Tag: 1750159643-342600 X-HE-Meta: U2FsdGVkX19GjW2nHMWdqLakyqgssxGRe7vF6SyrPedmPdOGIMFi+vW/B+D9VKP8l7qHL31W6n/tg83mgGehVyymHTGdWVxPOAutSvJwbqPNoOKTJatT/daAhAZrLxWYcnxJFUFkcS6Ppw+rKofn9cFfrhsZrnlDOavfrNT5Lig/fV38xpzFacBc6xPX358tkG21k8s/577FppHomUBZmIFF0LWTDYMeXXNh1gQXUNjAKck9+LtgKdPAw3Of4z09c/cMTdEKVTew2DaWFY6lk+52fqe7O4ZrxuadO9XMlJFUXhCle9f1UQAwFZN8Q4KeYCIdGSpzPUD2JQCS9MEx+b+bJmaHY76J1p0hfdzMg9RxOkOcc2xEZhImyv81R9rkhl0kCiSvtc9ruYeoTZBDQqh4QMa48AHRmv396rA9/IlMG0477mApPQ2Ex/ekUetRJQIc8hMqsVH1YWVBJLyDEZejx7xGwd0OUykz61HMLiUt3qBcVOBAJuETVsYwTjZLB831KjLWHLXuhpho4H+VGv9ZYu1fGNHyxz/qDFiw2DVM1D0DXb3pZGJCBoi+qePOHbpLcgDw9OrDePtWgHqY+HvenHPf6hwVjc5EPfK0ow2JoOZaNOBjBAQvRTqzUcxBr13wHs6vlGRyia1nX4hNDTn6Apz9eCsu3/aJr3WHvQAaWygdQDuP0assh54enD8VNWGPZJO620MViZPq5uhB94gE2cdgk0L5R7dZ/TGbHKVHvN9J9cRVV6Y4Gk/wsD/sfANCWxyYPKnkfBDPvUjmft0DfT6+Bz940/nC2u0YxoFlsngIlLFI/o+nJUexlZuB5eDZBzzcYkVWxwdXFIsC+2n4egR+Z+BnuX3eRp7nHKUPwHuzmZtLywcpd+BnQDsdsBvlsNvM02CJjQr/LNVziMB8usdB44H1peIt45+j0b1GCpt6ro998d7T3icmisjQO7ZpHKsxgmKxKLO9Tc6 u1YGDl0f aUHxTmBObb8eQcfLicHmXBaw1+sYdVsU3R3sbM7Kr4qd9nPKL3Df2LC/ZK1WkLQeCfhq5GQzmYdXybPPFdffR2+76lF3CpvGutuZ42v7txR+N05Nh9y6qj9WLewgpP9tB2ZAg5T8itcLfr+HkpZa09gIvsAQHDqi+6oyeLtXphyWPcg7zZyqeSz8icusoCDVVUu9ju/YtdiYOW+sD6IphCd3WzSLdq5TSY7dYwhrSWU9qciksf76DzHDtx49JXyE46G5vzOQbLOGZd/OWQ08ObKzFXkH7adQhQujHCqgpzYDESZOPXmlTpx16BbxO/XEiR989AOM2CllqEHRRr82IIY5dsl/TUpD7ewbRoByFu+A6RNrcqvSt2kiqIQSykJR5E6d4IUE2Km/q05ENFKmXdllgoSU0iiTwpWcxcdrHM120TJ+icpCgia9+SwtMEv/+f/Awl6sDwE7nntIZVHau3LgyrPvNqm9zxJ6CuzhCRjodW//gDyhYh5crcm1N1nFi0JiIGPqDEX65tM0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > I see, this makes a lot of sense, thanks for walking me through David! Well, I hope the same logic applies to hugetlb :D > Alright, then, with all this clear now we should: > > - Not take any locks on hugetlb_fault()->hugetlb_wp(), hugetlb_wp() will take it > if it's an anonymous folio (re-use check) > - Drop the lock in hugetlb_no_page() after we have mapped the page in > the pagetables > - hugetlb_wp() will take the lock IFF the folio is anonymous > > This will lead to something like the following: > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index dfa09fc3b2c6..4d48cda8a56d 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -6198,6 +6198,8 @@ static vm_fault_t hugetlb_wp(struct vm_fault *vmf) > * in scenarios that used to work. As a side effect, there can still > * be leaks between processes, for example, with FOLL_GET users. > */ > + if (folio_test_anon(old_folio)) > + folio_lock(old_folio); If holding the PTL, this would not work. You'd have to unlock PTL, lock folio, retake PTL, check pte_same. > if (folio_mapcount(old_folio) == 1 && folio_test_anon(old_folio)) { > if (!PageAnonExclusive(&old_folio->page)) { > folio_move_anon_rmap(old_folio, vma); > @@ -6212,6 +6214,8 @@ static vm_fault_t hugetlb_wp(struct vm_fault *vmf) > } > VM_BUG_ON_PAGE(folio_test_anon(old_folio) && > PageAnonExclusive(&old_folio->page), &old_folio->page); > + if (folio_test_anon(old_folio)) > + folio_unlock(old_folio); [...] > > This should be patch#2 with something like "Sorting out locking" per > title, and maybe explaining a bit more why the lock in hugelb_wp for > anonymous folios. Jup. -- Cheers, David / dhildenb