From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e32.co.us.ibm.com (8.12.11.20060308/8.13.8) with ESMTP id l9PGNpWL006153 for ; Thu, 25 Oct 2007 12:23:51 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l9PHWs0a064428 for ; Thu, 25 Oct 2007 11:32:54 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l9PHWqkM020954 for ; Thu, 25 Oct 2007 11:32:53 -0600 Subject: Re: [PATCH 2/2] Add mem_type in /syfs to show memblock migrate type From: Badari Pulavarty In-Reply-To: <1193332528.4039.156.camel@localhost> References: <1193327756.9894.5.camel@dyn9047017100.beaverton.ibm.com> <1193331162.4039.141.camel@localhost> <1193332042.9894.10.camel@dyn9047017100.beaverton.ibm.com> <1193332528.4039.156.camel@localhost> Content-Type: text/plain Date: Thu, 25 Oct 2007 10:36:05 -0700 Message-Id: <1193333766.9894.16.camel@dyn9047017100.beaverton.ibm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Dave Hansen Cc: KAMEZAWA Hiroyuki , melgor@ie.ibm.com, linux-mm List-ID: On Thu, 2007-10-25 at 10:15 -0700, Dave Hansen wrote: > On Thu, 2007-10-25 at 10:07 -0700, Badari Pulavarty wrote: > > I agree with you that all I care about are the "movable" sections > > for remove. But what we are doing here is, exporting the migrate type > > to user-space and let the user space make a decision on what type > > of sections to use for its use. For now, we can migrate/remove ONLY > > "movable" sections. But in the future, we may be able to > > migrate/remove > > "Reclaimable" ones. I don't know. > > Right, and if that happens, we simply update the one function that makes > the (non)removable decision. > > > I don't want to make decisions in the kernel for removability > > Too late. :) That's what the mobility patches are all about: having the > kernel make decisions that affect removability. > > > - as > > it might change depending on the situation. All I want is to export > > the info and let user-space deal with the decision making. > > That's a good point. But, if we have multiple _removable_ pageblocks in > the same section, but with slightly different types, your patch doesn't > help. The user will just see "Multiple", and won't be able to tell that > they can remove it. :( So, what you would like to see is - instead of mem_type, you want "mem_removable" and print "true/false". Correct ? Mel/KAME - what do you think ? At least on ppc64 (where section size == mobility group size), I prefer to see mobility type (more informative). But I am okay with returning boolean. Thanks, Badari -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org