Re: [PATCH 2/2] Add mem_type in /syfs to show memblock migrate type

[Badari Pulavarty <pbadari@us.ibm.com>]

On Thu, 2007-10-25 at 10:15 -0700, Dave Hansen wrote:
> On Thu, 2007-10-25 at 10:07 -0700, Badari Pulavarty wrote:
> > I agree with you that all I care about are the "movable" sections 
> > for remove. But what we are doing here is, exporting the migrate type
> > to user-space and let the user space make a decision on what type
> > of sections to use for its use. For now, we can migrate/remove ONLY
> > "movable" sections. But in the future, we may be able to
> > migrate/remove
> > "Reclaimable" ones. I don't know.
> 
> Right, and if that happens, we simply update the one function that makes
> the (non)removable decision.
> 
> > I don't want to make decisions in the kernel for removability
> 
> Too late. :)  That's what the mobility patches are all about: having the
> kernel make decisions that affect removability.  
> 
> >  - as
> > it might change depending on the situation. All I want is to export
> > the info and let user-space deal with the decision making.
> 
> That's a good point.  But, if we have multiple _removable_ pageblocks in
> the same section, but with slightly different types, your patch doesn't
> help.  The user will just see "Multiple", and won't be able to tell that
> they can remove it. :(

So, what you would like to see is - instead of mem_type, you want 
"mem_removable" and print "true/false". Correct ?

Mel/KAME - what do you think ? At least on ppc64 (where section size ==
mobility group size), I prefer to see mobility type (more informative).
But I am okay with returning boolean.

Thanks,
Badari

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>