From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5923C4345F for ; Wed, 24 Apr 2024 17:13:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 344976B02CC; Wed, 24 Apr 2024 13:13:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F4286B02CD; Wed, 24 Apr 2024 13:13:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BDCA8D001F; Wed, 24 Apr 2024 13:13:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EF7706B02CC for ; Wed, 24 Apr 2024 13:13:01 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5D0BE1210FA for ; Wed, 24 Apr 2024 17:13:01 +0000 (UTC) X-FDA: 82045070562.23.11A1223 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by imf27.hostedemail.com (Postfix) with ESMTP id 5F5CB40020 for ; Wed, 24 Apr 2024 17:12:59 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=egXitihj; spf=pass (imf27.hostedemail.com: domain of libang.linux@gmail.com designates 209.85.215.196 as permitted sender) smtp.mailfrom=libang.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713978779; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dxegVweWqPE61Ew53tJ0ETeROIZotZvlHjzQVwAHEps=; b=xyr5xQkgiCXkPFSRxzh23SM6BNCg/fT4oV8Xubil8ro98IoUNnG0Lts4klmf27d8cfLLlI Ri87c/c+UMgVMtSjPDHMcrTiehipnX0HWxGbwDdmlsUd5awEH7R+jM3QnixXu9G6lUEtgH Wo/4DQ5R0D90O9NJ0R7dnF+IF+ectoI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713978779; a=rsa-sha256; cv=none; b=8oh30Ev68EMcZ2ZAwNwDLu5kOZPYkq9mm8TUAt81W26WcXlTEmDgvIEKCvbthL9iEhOtHu 7/WnLR9fd03wzMKrvZ9pU8KgPLQ93iWFsIrDRIlFOxhtP3vu2lQ5Go5U+vgCXVLg7mUUua KB3DlKX+S/tCrdb0M7UQ0eiGdzhP4Jc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=egXitihj; spf=pass (imf27.hostedemail.com: domain of libang.linux@gmail.com designates 209.85.215.196 as permitted sender) smtp.mailfrom=libang.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pg1-f196.google.com with SMTP id 41be03b00d2f7-5d8b887bb0cso56470a12.2 for ; Wed, 24 Apr 2024 10:12:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713978778; x=1714583578; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dxegVweWqPE61Ew53tJ0ETeROIZotZvlHjzQVwAHEps=; b=egXitihjual/8agK8xSS2+fSGV8pL9B3XWfROW9nUgD92dtVnr3cvv8bkc61cak0s/ rLRQ4dtjGY0az7SNhGQH9b7SBzwR8sl9x0RYSFkRl0QaYSmTK9k1mRmiD10YkpW3+ckf w+z6zoayNlC+CNVoFQ/40fYayinE4CsgvtvvWIPUS0rryRZ2HOHwiLqaNw6Q0OOp1MSK v08IguO5WPXYdBBl58Sluud3w8GPiFz96VASYFgPW4cbjsITaO0WX2kvlFcRsGADmHlP TCjToSiiNxW0bf08ar/aIYtlSyzFAm1OHyZQPn2ql0FcgTnIwLChCXVvrGROahP6T5SH 1+/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713978778; x=1714583578; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dxegVweWqPE61Ew53tJ0ETeROIZotZvlHjzQVwAHEps=; b=tVbSspAsMWCL3OBAVh/geuDHNcUZ00VCRiVix54W1V8KTjJJMwWNsAyA8pNdS7lZ2T XWcGFmNj3jRx3j+rUPD891lmtYTOgxR5Xtd/vKsvPo01ue4TJ7GlRIPG/dDXo8kpdSnx 85hCWiLjxwkZxn3+HLfCT9v4K+qtVYFfkVbI8Hn8m5i7GFXNJVBWW8Gt2CrT1wDfMugj OjvPgfbok4W52ABmAyVlIJf6X3eVCUdEUgUsXQg90PraoGGRu9nQ6nE5cLN9U06Nm5Xi wkf6THdPjsBJ53HFNyRflPl+kUP5xdLUtantFBAWyIFf0ltWtq8noDS/snCDGSfcumDb i1Jg== X-Forwarded-Encrypted: i=1; AJvYcCVsLuv9RyetRROTzeMqCiGx+0gI2xW0GbOitAbfFfz7x01fU633VfFk4P31nzetEH67fwTTbk3t4epLai5KbppUSNs= X-Gm-Message-State: AOJu0Yxj6PlUSZyvrROdrWT7TtvchssWfQAhX5v/xruSSkR8U2UTH5er hL9sN+DHgLcmsmDIlo9jeVIYyTo2KNH7LOpBBraThjp/ZsX3xpDV X-Google-Smtp-Source: AGHT+IGwhhiu4+La+tG0OomZAWmseIzRLz3aE1iD1bwq3lJoIbnOV11f34aO0HHKjJs1M5qglz/5Zg== X-Received: by 2002:a17:90b:1c0d:b0:2ae:1316:a4a with SMTP id oc13-20020a17090b1c0d00b002ae13160a4amr3131444pjb.4.1713978778201; Wed, 24 Apr 2024 10:12:58 -0700 (PDT) Received: from [192.168.3.172] ([122.231.145.235]) by smtp.gmail.com with ESMTPSA id d17-20020a170903209100b001e45c0d6ce6sm12165046plc.306.2024.04.24.10.12.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Apr 2024 10:12:57 -0700 (PDT) Message-ID: <1192295a-5b94-4c1a-b11c-7cd8ef0e62b7@gmail.com> Date: Thu, 25 Apr 2024 01:12:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: add per-order mTHP split counters To: Lance Yang Cc: akpm@linux-foundation.org, 21cnbao@gmail.com, ryan.roberts@arm.com, david@redhat.com, baolin.wang@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240424135148.30422-1-ioworker0@gmail.com> <20240424135148.30422-2-ioworker0@gmail.com> Content-Language: en-US From: Bang Li In-Reply-To: <20240424135148.30422-2-ioworker0@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5F5CB40020 X-Stat-Signature: j63tgx1hxum39fhca5wnzd59ewweuyj6 X-HE-Tag: 1713978779-64032 X-HE-Meta: U2FsdGVkX1+joaGZFnHNJDUP3tSRy7NDXL8f9Go+2W0I5ePfDoVmAu8gGMwCuryiNfGd678jb0ub4oANSMZPNbXhoQJQhxAK6YNhpaqusfXMI8cS7xv/V/phhbz9xjwh6V6rPD/Vx7oIwtAevCodYvX12+A9Efd7a03BbKc5s3OmD2RBH7lob9Omsy+HpbUz8cOu3voBQ11Xx/fPnG9XwMm0XbyvC9XoTrNBA1RFxsjqxiFYPB78pernMJmh3Roid7COS8DvJKCY7JUiMUoVu6lkZkizLWnAAW9UncIF8fCmU3sft/whiuDZZSx4hLwptFjNAIfkNZGjYSkV/dJ4JXsxKJKW+mnV5Z3eeDcTjOZsLJWC64zwwcnTbTsxl+vmUOUrkJDvMIZtGarCtcfv/1LFAScTZNGGej6f1l1gTcybasjGU7Tob86RspZ334r0CMvlqONoNjq9rGmjDKFnERJR8Jwxi0Ic9BlHmX91Ba3kMGJ48eNoGbaL5LwYHWEFhoi98lVPJgynOJkWhlRSTZyqWuUfnOoxadHhekoPmOn5IC4r5HNif1jv5Vw7lIN2xN5gCJHcBMIoDChnjRs0NA7lGXAUbDCh786YGoxXN7ZB627i853xUfYcCEgicdZzGbIYDxNUuIHCAWmTIH5ElJfWTJEpBhvy0lhTVRiZTZle88aXiBQRR3KTMLlLrOaTfhS1y7Y++0J1I4x/8xbN5dvs2iHT+dYOuEUUdlO1dhuh4JqWnqCz7NrLx9I3hjgH6gvjXA7T3VOQB0zMOySdoC9I+gMJSG5/J9saAyJddHzqQjeZqBMyGvdC/6NJOg2pO9TQjuTog5r3e9TzemBGzCPJuuKW0XBAhSM6wy21OFysohvB37a3FVFiOQ9I/UOMSB/XI0AjibVF+75TcJ3jBiUYqbiK71/yPLafCATAPcZkYq2dEN2sxYLiLB67QQw6vdxoxEBLdFQnSrUceA1 VC1hwLtn LSdu1ji1oGlOdhttiZEgdihwp5MhD4YUjIEnFt/oojh70eEheL6s3LvKhcsR0HjaXn7dJ8wYjcTBMYQ3E/ti4rUWSYmvF/+w5LnSN30McUEajvT9m7hy76TjSIDpu2w6S0WGvJYu0JuD9UKEadOZduNQvA4DOvF9jZ2uTA01FRRacG1tq7h7OeELY7UWayngcvuXVh1FlqSjNVD1t57mUZKzk2hrf9E1Cgu5lE9IjRybuXfc95h6+UK8GMoKkdtv/QWa4mB+tYGO77R/KEFQda6Ae/9yBauSKRXs0jmIb5RAO48JdvsKHe5OK1213PTEnzulg5KmfbtbS19mJxgySS3Rvn7oZblxUUFwXlBU84vVDAHa2Uyc64DYoYIKesvsCbuMx6JakQAnIqvkC4fNs0ahaa/CS76xz7WT4m50pcCotAtClT6NPcrcLkwHbLYUV3470b2szkQmpi+4KuXIp5A296+qtkIAU7P5LK5wKM2gBQBOFNshz3ErfZ8Gwt6hAwvN/VZoBN3oZu6m5W0BVlMbkYA1xMnmG+2ym+XxMsxBzEA+YPGLipAeUIJuyb6jgZaMrohN9s2W47t8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hey Lance, On 2024/4/24 21:51, Lance Yang wrote: > At present, the split counters in THP statistics no longer include > PTE-mapped mTHP. Therefore, this commit introduces per-order mTHP split > counters to monitor the frequency of mTHP splits. This will assist > developers in better analyzing and optimizing system performance. > > /sys/kernel/mm/transparent_hugepage/hugepages-/stats > split_page > split_page_failed > deferred_split_page > > Signed-off-by: Lance Yang > --- > include/linux/huge_mm.h | 3 +++ > mm/huge_memory.c | 14 ++++++++++++-- > 2 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 56c7ea73090b..7b9c6590e1f7 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -272,6 +272,9 @@ enum mthp_stat_item { > MTHP_STAT_ANON_FAULT_FALLBACK_CHARGE, > MTHP_STAT_ANON_SWPOUT, > MTHP_STAT_ANON_SWPOUT_FALLBACK, > + MTHP_STAT_SPLIT_PAGE, > + MTHP_STAT_SPLIT_PAGE_FAILED, > + MTHP_STAT_DEFERRED_SPLIT_PAGE, > __MTHP_STAT_COUNT > }; > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 055df5aac7c3..52db888e47a6 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -557,6 +557,9 @@ DEFINE_MTHP_STAT_ATTR(anon_fault_fallback, MTHP_STAT_ANON_FAULT_FALLBACK); > DEFINE_MTHP_STAT_ATTR(anon_fault_fallback_charge, MTHP_STAT_ANON_FAULT_FALLBACK_CHARGE); > DEFINE_MTHP_STAT_ATTR(anon_swpout, MTHP_STAT_ANON_SWPOUT); > DEFINE_MTHP_STAT_ATTR(anon_swpout_fallback, MTHP_STAT_ANON_SWPOUT_FALLBACK); > +DEFINE_MTHP_STAT_ATTR(split_page, MTHP_STAT_SPLIT_PAGE); > +DEFINE_MTHP_STAT_ATTR(split_page_failed, MTHP_STAT_SPLIT_PAGE_FAILED); > +DEFINE_MTHP_STAT_ATTR(deferred_split_page, MTHP_STAT_DEFERRED_SPLIT_PAGE); > > static struct attribute *stats_attrs[] = { > &anon_fault_alloc_attr.attr, > @@ -564,6 +567,9 @@ static struct attribute *stats_attrs[] = { > &anon_fault_fallback_charge_attr.attr, > &anon_swpout_attr.attr, > &anon_swpout_fallback_attr.attr, > + &split_page_attr.attr, > + &split_page_failed_attr.attr, > + &deferred_split_page_attr.attr, > NULL, > }; > > @@ -3083,7 +3089,7 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list, > XA_STATE_ORDER(xas, &folio->mapping->i_pages, folio->index, new_order); > struct anon_vma *anon_vma = NULL; > struct address_space *mapping = NULL; > - bool is_thp = folio_test_pmd_mappable(folio); > + int order = folio_order(folio); > int extra_pins, ret; > pgoff_t end; > bool is_hzp; > @@ -3262,8 +3268,10 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list, > i_mmap_unlock_read(mapping); > out: > xas_destroy(&xas); > - if (is_thp) > + if (order >= HPAGE_PMD_ORDER) > count_vm_event(!ret ? THP_SPLIT_PAGE : THP_SPLIT_PAGE_FAILED); > + count_mthp_stat(order, !ret ? MTHP_STAT_SPLIT_PAGE : > + MTHP_STAT_SPLIT_PAGE_FAILED); > return ret; > } > > @@ -3327,6 +3335,8 @@ void deferred_split_folio(struct folio *folio) > if (list_empty(&folio->_deferred_list)) { > if (folio_test_pmd_mappable(folio)) > count_vm_event(THP_DEFERRED_SPLIT_PAGE); > + count_mthp_stat(folio_order(folio), > + MTHP_STAT_DEFERRED_SPLIT_PAGE); > list_add_tail(&folio->_deferred_list, &ds_queue->split_queue); > ds_queue->split_queue_len++; > #ifdef CONFIG_MEMCG My opinion can be ignored :). Would it be better to modify the deferred_split_folio function as follows? I'm not sure. diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 055df5aac7c3..e8562e8630b1 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -3299,12 +3299,13 @@ void deferred_split_folio(struct folio *folio) struct mem_cgroup *memcg = folio_memcg(folio); #endif unsigned long flags; + int order = folio_order(folio); /* * Order 1 folios have no space for a deferred list, but we also * won't waste much memory by not adding them to the deferred list. */ - if (folio_order(folio) <= 1) + if (order <= 1) return; /* @@ -3325,8 +3326,9 @@ void deferred_split_folio(struct folio *folio) spin_lock_irqsave(&ds_queue->split_queue_lock, flags); if (list_empty(&folio->_deferred_list)) { - if (folio_test_pmd_mappable(folio)) + if (order >= HPAGE_PMD_ORDER) count_vm_event(THP_DEFERRED_SPLIT_PAGE); + count_mthp_stat(order, MTHP_STAT_DEFERRED_SPLIT_PAGE); list_add_tail(&folio->_deferred_list, &ds_queue->split_queue); ds_queue->split_queue_len++; #ifdef CONFIG_MEMCG thanks, bang