From: Dave Hansen <haveblue@us.ibm.com>
To: Adam Litke <agl@us.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org
Subject: Re: [PATCH] hugetlb: Fix dynamic pool resize failure case
Date: Fri, 12 Oct 2007 12:31:45 -0700 [thread overview]
Message-ID: <1192217505.20859.106.camel@localhost> (raw)
In-Reply-To: <20071012191519.14433.13461.stgit@kernel>
On Fri, 2007-10-12 at 12:15 -0700, Adam Litke wrote:
>
> Changes since V1
> Added a comment explaining the free logic in gather_surplus_pages.
>
> When gather_surplus_pages() fails to allocate enough huge pages to satisfy
> the requested reservation, it frees what it did allocate back to the buddy
> allocator. put_page() should be called instead of update_and_free_page()
> to ensure that pool counters are updated as appropriate and the page's
> refcount is decremented.
The comment looks good. It's much more obvious what it's doing now and
certainly answers all the questions I asked before.
I do think we need to consider some of the wider implications before the
series that this applies on top of goes to mainline, but this patch by
itself is just fine with me.
Acked-by: Dave Hansen <haveblue@us.ibm.com>
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-10-12 19:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 19:15 Adam Litke
2007-10-12 19:31 ` Dave Hansen [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-10-09 15:58 Adam Litke
2007-10-09 21:20 ` Dave Hansen
2007-10-10 13:58 ` Adam Litke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1192217505.20859.106.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=agl@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox