From: Peter Zijlstra <peterz@infradead.org>
To: Yan Zheng <yanzheng@21cn.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH]fix page release issue in filemap_fault
Date: Mon, 08 Oct 2007 19:15:23 +0200 [thread overview]
Message-ID: <1191863723.20745.26.camel@twins> (raw)
In-Reply-To: <3d0408630710080828h7ad160dbxf6cbd8513c1ad3e8@mail.gmail.com>
On Mon, 2007-10-08 at 23:28 +0800, Yan Zheng wrote:
> Hi all
>
> find_lock_page increases page's usage count, we should decrease it
> before return VM_FAULT_SIGBUS
>
> Signed-off-by: Yan Zheng<yanzheng@21cn.com>
Nice catch, .23 material?
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> ----
> diff -ur linux-2.6.23-rc9/mm/filemap.c linux/mm/filemap.c
> --- linux-2.6.23-rc9/mm/filemap.c 2007-10-07 15:03:33.000000000 +0800
> +++ linux/mm/filemap.c 2007-10-08 23:14:39.000000000 +0800
> @@ -1388,6 +1388,7 @@
> size = (i_size_read(inode) + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT;
> if (unlikely(vmf->pgoff >= size)) {
> unlock_page(page);
> + page_cache_release(page);
> goto outside_data_content;
> }
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-10-08 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 15:28 Yan Zheng
2007-10-08 17:15 ` Peter Zijlstra [this message]
2007-10-08 17:23 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1191863723.20745.26.camel@twins \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yanzheng@21cn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox