From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4619CE77188 for ; Fri, 20 Dec 2024 15:00:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C4D86B0082; Fri, 20 Dec 2024 10:00:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 974CE6B0083; Fri, 20 Dec 2024 10:00:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EF006B0088; Fri, 20 Dec 2024 10:00:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5EC596B0082 for ; Fri, 20 Dec 2024 10:00:10 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D8ECE160B0B for ; Fri, 20 Dec 2024 15:00:09 +0000 (UTC) X-FDA: 82915647444.14.487853A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 2995E16000E for ; Fri, 20 Dec 2024 14:59:43 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NVLRRETD; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734706775; a=rsa-sha256; cv=none; b=IL+Kxt3vR8H1dY9VKi4LrQh72pR4/7rwjSCsHHeGGyGGmVlze8Nk2lNPZPNm0V0p66UTWF wR9Ucy9J0Hb4CohO6/nPNm0RrzUW/4RBfc+EsENsMdpFV5iq7Q45ajNWU2tPwtGXdpjYE7 3FommHLmaLlnvX5MbfmuyzeG6i7deX4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NVLRRETD; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734706775; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CVlHai8ZtrdA52oawJnYbwy0hmdfeFJlU4gJMi3MOlA=; b=Qjr8FArf9PxbB+HsJR8Wb+OFfuoLJ2gV2A7rUCGtzxSsZm4RX7LiQ3/wxgs4ELjtC9Vif8 SqzQipjTpN4yKqoyk13TH1gbdu6FN28KOWUg12mUjikCSa2PSOe+xEi1zE6CmAzloE6IGR 6l98nF3YHuPZWrfs7/k5/RXQpAAe+ek= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734706806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CVlHai8ZtrdA52oawJnYbwy0hmdfeFJlU4gJMi3MOlA=; b=NVLRRETDO4SIGNTGHakjSs9gwfBUqa0HB5yHduYHDpz/jxt2JyUzxSHPseLcfTmQVJAoUQ ++niWdvU+7AYGoQu7vnPRbV7RKbJomRMAonN/IVR7Th3ul8BTy5pGI01MzHT1+BSQJd8YV xdSFvhy1qR/i/Glyjmz3XfZSK8bGJjY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-313-_6EOVMNNOl6Vuy96cUqE1g-1; Fri, 20 Dec 2024 10:00:02 -0500 X-MC-Unique: _6EOVMNNOl6Vuy96cUqE1g-1 X-Mimecast-MFC-AGG-ID: _6EOVMNNOl6Vuy96cUqE1g Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-385e9c69929so978962f8f.1 for ; Fri, 20 Dec 2024 07:00:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734706801; x=1735311601; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=CVlHai8ZtrdA52oawJnYbwy0hmdfeFJlU4gJMi3MOlA=; b=LwkN+Lxf+PHyV51zRaqTCFG9nTw7af1ruXXhUdyoH093aYJyTFBy5khmPwcbzTywDd l4RFZhpDPLYyfP2S07Tr8wQ7b5TmzQ54oceiT2TtERZ39auUpjIdSJMj3TIoZUTdbz2a aeWfNFj20V8+qHUFsqml579FaNwJrb5cyTQCoGnaDaRQBkl5td7UXij3OAlgsWx2EvEj ZklSRldjROKTbj7j04xnPCU7dBB7+Wy3J3SePeir0+cTx1QPRSj1XTywuOjGsGJgv+T7 lvOSTQxSdjxuUZvSVcdL8276vB0Eb+0fmBAOoaMYcEgTSOTFwXsnjcl/I/JMHkA9ZS1t Tk3A== X-Forwarded-Encrypted: i=1; AJvYcCVTXLN/5RQzaihwxICsUDRQO4m6bGG5mpL05YuScknC3SseuA3ikVvrhX3dCIIplamo3YMiG9N5bA==@kvack.org X-Gm-Message-State: AOJu0Yx0SF2wb/+Oosp6S9RWbYdgcNV4O+7BluD/CoMejortu6mt5Lx4 JC3uzmCgkr1Kj/922w1zjELXUol2YcRNhCMBTTuzDNGgz8yEvhe3N5wh56LCktUjwexPK8aupKq jWXxejaMz5Tx4k9aFKZrSGQdayWbeg/qL1udHGatRaCxuG7Vv X-Gm-Gg: ASbGnctCSX4aSgDvNaMGp3U/+oqS9dCCLRJ1NLGf8Kz3P+nLEAJ6Me6YDdmijin7Qny cCFTBTkjAiKRlcmXL3PENHB+/P01eJnDkoI8J2Od9XtBmMmuJTmOiMoox1ljD7OaWj82YRROODK y7mzFkSmtK0pl9z+atHWiO3qiKXCnlYyWWnSEHcmz2kjgeyEZeaBKVWbpiDYevMZOmuw3p2LQWc MzPI8rInQ+U/FIFbd8C3XsMnx4IJnqXVYzHEDcxVSFuHYAfSY5izc+iYahjQTI5/ltlMVJcDNoa 2NSQvsEsJ06l/TuycnQE/gcL48g+WtM6phEzkefIoQAYUrxKPt3Xv9PW0bVmzmXTkMqttOMJl/y R8Cjh6BtV X-Received: by 2002:a05:6000:1867:b0:385:df73:2f24 with SMTP id ffacd0b85a97d-38a223f5cd1mr3554620f8f.39.1734706800761; Fri, 20 Dec 2024 07:00:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IHWZhh6sB5dTXVDhO4PkN9idv6yIKdy8UmBJXabgk5GGSoaZQlkfVIvs8THbRFMRvkaj6U8Rw== X-Received: by 2002:a05:6000:1867:b0:385:df73:2f24 with SMTP id ffacd0b85a97d-38a223f5cd1mr3554594f8f.39.1734706800387; Fri, 20 Dec 2024 07:00:00 -0800 (PST) Received: from ?IPV6:2003:cb:c708:9d00:edd9:835b:4bfb:2ce3? (p200300cbc7089d00edd9835b4bfb2ce3.dip0.t-ipconnect.de. [2003:cb:c708:9d00:edd9:835b:4bfb:2ce3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8acb85sm4180147f8f.103.2024.12.20.06.59.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 06:59:59 -0800 (PST) Message-ID: <11911ad7-527b-411b-9896-fea06bf38a26@redhat.com> Date: Fri, 20 Dec 2024 15:59:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: add build-time option to set hotplug default type To: Gregory Price , linux-mm@kvack.org Cc: linux-kernel@kvack.org, osalvador@suse.de, gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org References: <20241220144518.206208-1-gourry@gourry.net> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241220144518.206208-1-gourry@gourry.net> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5zaGHOJewhWuZr3GPlxcMMb93MW5t9ApZPHBxlsIknQ_1734706801 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: o4qdw43m1zjp64idmtbxzxc3r4ztzqtw X-Rspam-User: X-Rspamd-Queue-Id: 2995E16000E X-Rspamd-Server: rspam08 X-HE-Tag: 1734706783-126226 X-HE-Meta: U2FsdGVkX1/4mIoTNxawJsQsn4NKe0qM45aTKpAZcXxDXc+ksCJc8Myhbp4l+CXv+aPctuezUmueDfcKTHp2sHyjwCnYOJY1updAUVe81xPu5KSl917ELFY813cJvmyxGu14QB80kYp9d8Bl1w/dSCYOBD9H2NVXanNfiyPFxmCwRJaZ+m0HHWaqvBN7Fm5oL22w0uN8nrxmKOB2MSdFFBvbuD5oQ0snlSL+GWxkgMD7IHbzxl+GVZNtfmTLL3XnZtf52tvM5vGiCG3/pH0+OacP5IQ5dcH2JndxbaroiDakV44oj5Je+ifVEJEPjIHYmmxW8TVGO5QmrOJTHwMzBLdwHzn4Nc9sIsWNcr3HdbCROAsk6VqdFynJnLMLK5IHtO4tKf2kBC8ij34URFKS66Ykcr+JVOi3tu0X3DWyBf6L93ARdeDIm3+FLMx5xEYpnW7WxUjulYsHLGl42jBnwXbkdKJHKe78zN9g5E6btrpr7/t0CMI6RngkupeUzC/+zP1uPsyuWmDHV1zR0T0bwwq3v6e4eXSQ0FceR8YsNflzhZfkDlGZ34hmBOif03oljec6nR8HWLBMGZHwpFtv1KewHZIHar7e0IDsfbHWvNmsVNC0wMQICBo9gDYC3nivrY3bKCnJR/1Im/aCtrKx4GRih7lbg/HFdF0cmV0pXF2u+QJ91xQjE/QuATf6TacRDzxS/Tgh9dlVqm8QLD28/SexpDvDFIQEh8uOuX1MHBSAITaoWf/8y385RGBjy/ItyNla0FvjJN8wKuykSNCPA9lnqR6SR1L71uLOTwoqJ76nr5Xo+vweP7DD57+z+iNrBsWeL+rCt6//Eza14o8j/R53KtG78yrll9ZpGYr4j5pRivHRyqOSrXYpMBOmQS2uoT64NNlBIw5UdtwNcvwCVjSSZDWgxxlF7adx1gNPA9/VJgFTUPJlWhzBgUrQ1/rpQcGQ1OJAwdirBI9aNzW D2SRXHym Miw98baFgy9oNLdpScWMKtgh8HJpGBtu+AiWwkzfcNFgiDbzynss0WZP1TUnkWnlbIT9CsAeMJ6NOadxVaIXgmLSNFPi849XrhyYIhKcF7bvVT8ZEm4iZWfOIDX8l/4u2u4jUfS90JN0wJBrcNNsW6ROtW9dKs16jKe/jgZDHIE/h8HnpKzKjAqvLGYbUxzO84pXbcdWv8H0w8JiacuJsw/yYAD2C2b7LHmwh6IVFzZ2/bR/AIR4st9SaItkgJyvatl55pjrHxOJuqk+lLYolJ60lJMZHOD5JQNpdt4lm5as7TtViZLRqrCETAV0ishWx14pIQ9b7Et+YM2ttujA9CCGNC23T/M4UmS9PN5NYfcOEmfFG4pWJk28tBs3pc1CbyESSqohV76YeyY/eUX4MAqVWcjbj9IsAGtai X-Bogosity: Ham, tests=bogofilter, spamicity=0.045042, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.12.24 15:45, Gregory Price wrote: > When memory hotplug auto-online is enabled, hotplug memory blocks are > onlined into ZONE_NORMAL by default. The `memhp_default_state` boot > param allows runtime configuration, but no build-time config exists. + you can configure it at runtime. > > Add a build-time configuration option to change default hotplug zone. > > build config: > MEMHP_DEFAULT_TYPE > > Selections: > MEMHP_DEFAULT_TYPE_NORMAL => mhp_default_online_type = "online" > MEMHP_DEFAULT_TYPE_MOVABLE => mhp_default_online_type = "online_movable" > > When MEMORY_HOTPLUG_DEFAULT_ONLINE is disabled, MEMHP_DEFAULT_TYPE is > set to "offline" to match the current system behavior. > > ZONE_NORMAL still remains the default, because for systems with a large > amount of hotplug memory, defaulting it to ZONE_MOVABLE may result in > portions failing to online if sufficient ZONE_NORMAL memory does not > exist to describe it. > What's the use case? I'm hoping that we can move away from the compile-time option and let user space, who better knows what to do (especially with different kinds of memory having different requirements) configure auto-onlining or online manually (e.g., devdax). For example, in RHEL we traditionally use udev rules, because we want a different behavior on bare-metal vs. VMs, but they are not particularly easy to extend to implement wilder policies. For a while I worked on a systemd unit [1] to configure+handle memory onlining so we can get rid of the udev rules we use in RHEL. But it only configured+handled having "one type of hotplugged memort". I'm planning on picking that up again at some point, to also make it possible to handle different policies for different memory types. For example, maybe someone wants to auto-online virtio-mem memory to ZONE_NORMAL, but let onlining of devdax memory be handled by the devdax utility (e.g. ZONE_MOVABLE). We can identify in some cases "what" memory was added using /proc/iomem. [1] https://github.com/davidhildenbrand/systemd/tree/memoryhotplugd -- Cheers, David / dhildenb