From: Dave Hansen <haveblue@us.ibm.com>
To: Balbir Singh <balbir@in.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm <linux-mm@kvack.org>
Subject: Re: 2.6.23-rc4-mm1 memory controller BUG_ON()
Date: Thu, 13 Sep 2007 12:51:41 -0700 [thread overview]
Message-ID: <1189713102.17236.1647.camel@localhost> (raw)
In-Reply-To: <1189712083.17236.1626.camel@localhost>
On Thu, 2007-09-13 at 12:34 -0700, Dave Hansen wrote:
> Looks like somebody is holding a lock while trying to do a
> mem_container_charge(), and the mem_container_charge() call is doing an
> allocation. Naughty.
>
> I'm digging into it a bit more, but thought I'd report it, first.
>
> .config: http://sr71.net/~dave/linux/memory-controller-bug.config
I'm now thinking this is because the add_to_page_cache() functions have
a gfp_mask passed in, and the mem_container_charge() functions don't
take that mask. So, even if the add_to_page_cache() user specified !
__GFP_WAIT, the mem_container_charge() function can sleep on its
kmalloc.
I'll try passing gfp_flags through to it and see what happens.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-09-13 19:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-13 19:34 Dave Hansen
2007-09-13 19:51 ` Dave Hansen [this message]
2007-09-13 20:24 ` Balbir Singh
2007-09-13 20:21 ` Balbir Singh
2007-09-13 20:54 ` Dave Hansen
2007-09-14 8:49 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1189713102.17236.1647.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@in.ibm.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox