Re: [PATCH] 2.6.23-rc3-mm1 - Move setup of N_CPU node state mask

[Mel Gorman <mel@csn.ul.ie>]

On Fri, 2007-08-24 at 12:09 -0400, Lee Schermerhorn wrote:
> Saw this while looking at "[BUG] 2.6.23-rc3-mm1 kernel BUG at
> mm/page_alloc.c:2876!".  Not sure it matters, as apparently, failure to
> kmalloc() the zone pcp will bug out later anyway.
> 

If the failure path is entered, my expectation is that the CPU would not
appear otherwise active. I'm not convinced the old code is wrong.

> Lee
> --------------------------
> 
> [PATCH] Move setup of N_CPU node state mask
> 
> Against:  2.6.23-rc3-mm1
> 
> Move recording of nodes w/ cpus to before zone loop.
> Otherwise, error exit could skip setup of N_CPU mask.  
> 
> Signed-off-by:  Lee Schermerhorn <lee.schermerhorn@hp.com>
> 
>  mm/page_alloc.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Index: linux-2.6.23-rc3-mm1/mm/page_alloc.c
> ===================================================================
> --- linux-2.6.23-rc3-mm1.orig/mm/page_alloc.c	2007-08-22 10:08:00.000000000 -0400
> +++ linux-2.6.23-rc3-mm1/mm/page_alloc.c	2007-08-22 10:08:44.000000000 -0400
> @@ -2793,6 +2793,8 @@ static int __cpuinit process_zones(int c
>  	struct zone *zone, *dzone;
>  	int node = cpu_to_node(cpu);
>  
> +	node_set_state(node, N_CPU);	/* this node has a cpu */
> +
>  	for_each_zone(zone) {
>  
>  		if (!populated_zone(zone))
> @@ -2810,7 +2812,6 @@ static int __cpuinit process_zones(int c
>  			 	(zone->present_pages / percpu_pagelist_fraction));
>  	}
>  
> -	node_set_state(node, N_CPU);
>  	return 0;
>  bad:
>  	for_each_zone(dzone) {
> 
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>