linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <haveblue@us.ibm.com>
To: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux MM Mailing List <linux-mm@kvack.org>,
	David Rientjes <rientjes@google.com>,
	Linux Containers <containers@lists.osdl.org>,
	Paul Menage <menage@google.com>
Subject: Re: [-mm PATCH]  Memory controller improve user interface
Date: Wed, 29 Aug 2007 11:45:48 -0700	[thread overview]
Message-ID: <1188413148.28903.113.camel@localhost> (raw)
In-Reply-To: <20070829111030.9987.8104.sendpatchset@balbir-laptop>

On Wed, 2007-08-29 at 16:40 +0530, Balbir Singh wrote:
> 
> 
> @@ -352,7 +353,7 @@ int mem_container_charge(struct page *pa
>                 kfree(pc);
>                 pc = race_pc;
>                 atomic_inc(&pc->ref_cnt);
> -               res_counter_uncharge(&mem->res, 1);
> +               res_counter_uncharge(&mem->res, MEM_CONTAINER_CHARGE_KB);
>                 css_put(&mem->css);
>                 goto done;
>         } 

Do these changes really need to happen anywhere besides the
user<->kernel boundary?  Why can't internal tracking be in pages?

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2007-08-29 18:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-29 11:10 Balbir Singh
2007-08-29 15:28 ` Paul Menage
2007-08-29 16:07   ` Balbir Singh
2007-08-29 16:17     ` Paul Menage
2007-08-29 18:45 ` Dave Hansen [this message]
2007-08-29 22:04   ` Balbir Singh
2007-08-29 22:18     ` Dave Hansen
2007-08-29 22:20       ` Paul Menage
2007-08-29 22:25         ` Dave Hansen
2007-08-29 22:37           ` Balbir Singh
2007-08-30  5:38             ` KAMEZAWA Hiroyuki
2007-08-30  9:13               ` Balbir Singh
2007-08-29 22:27       ` Balbir Singh
2007-08-29 22:36         ` Dave Hansen
2007-08-29 22:44           ` Balbir Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1188413148.28903.113.camel@localhost \
    --to=haveblue@us.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=containers@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=menage@google.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox