[PATCH 5/5] mm/... convert #include "linux/..." to #include <linux/...>

[PATCH 5/5] mm/... convert #include "linux/..." to #include <linux/...>

[Joe Perches]

(untested)

There are several files that 
#include "linux/file" not #include <linux/file>
#include "asm/file" not #include <asm/file>

Here's a little script that converts them:

egrep -i -r -l --include=*.[ch] \
"^[[:space:]]*\#[[:space:]]*include[[:space:]]*\"(linux|asm)/(.*)\"" * \
| xargs sed -i -e 's/^[[:space:]]*#[[:space:]]*include[[:space:]]*"\(linux\|asm\)\/\(.*\)"/#include <\1\/\2>/g'

Signed-off-by: Joe Perches <joe@perches.com>

diff --git a/mm/slab.c b/mm/slab.c
index a684778..976aeff 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -334,7 +334,7 @@ static __always_inline int index_of(const size_t size)
 		return i; \
 	else \
 		i++;
-#include "linux/kmalloc_sizes.h"
+#include <linux/kmalloc_sizes.h>
 #undef CACHE
 		__bad_size();
 	} else


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH 5/5] mm/... convert #include "linux/..." to #include <linux/...>

[Christoph Lameter]

On Sun, 19 Aug 2007, Joe Perches wrote:

> diff --git a/mm/slab.c b/mm/slab.c
> index a684778..976aeff 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -334,7 +334,7 @@ static __always_inline int index_of(const size_t size)
>  		return i; \
>  	else \
>  		i++;
> -#include "linux/kmalloc_sizes.h"
> +#include <linux/kmalloc_sizes.h>
>  #undef CACHE
>  		__bad_size();
>  	} else

But I think this was done intentionally to point out that the file 
includes is *not* a regular include file.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH 5/5] mm/... convert #include "linux/..." to #include <linux/...>

[Joe Perches]

On Mon, 2007-08-20 at 11:06 -0700, Christoph Lameter wrote:
> On Sun, 19 Aug 2007, Joe Perches wrote:
> > diff --git a/mm/slab.c b/mm/slab.c
> > -#include "linux/kmalloc_sizes.h"
> > +#include <linux/kmalloc_sizes.h>
> But I think this was done intentionally to point out that the file 
> includes is *not* a regular include file.

Maybe.  I think it's just a simple error.

mm/slab.c has 2 other includes of

	#include <linux/kmalloc_sizes.h>

cheers, Joe

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH 5/5] mm/... convert #include "linux/..." to #include <linux/...>

[Christoph Lameter]

On Mon, 20 Aug 2007, Joe Perches wrote:

> Maybe.  I think it's just a simple error.
> 
> mm/slab.c has 2 other includes of
> 
> 	#include <linux/kmalloc_sizes.h>
> 
> cheers, Joe

Ahh. ok.

Then

Acked-by: Christoph Lameter <clameter@sgi.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>