From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: [kj] is_power_of_2 in mm/slub.c From: vignesh babu Reply-To: vigneshbabu@gmail.com Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Mon, 13 Aug 2007 18:33:13 +0530 Message-Id: <1187010193.7273.15.camel@merlin.linuxcoe.com> Mime-Version: 1.0 Sender: owner-linux-mm@kvack.org Return-Path: To: clameter@sgi.com Cc: linux-mm@kvack.org, linux-kernel , Kernel Janitors List List-ID: Replacing n & (n - 1) for power of 2 check by is_power_of_2(n) Signed-off-by: vignesh babu --- diff --git a/mm/slub.c b/mm/slub.c index 69d02e3..1241d14 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -20,6 +20,7 @@ #include #include #include +#include /* * Lock order: @@ -2606,7 +2607,7 @@ void __init kmem_cache_init(void) * around with ARCH_KMALLOC_MINALIGN */ BUILD_BUG_ON(KMALLOC_MIN_SIZE > 256 || - (KMALLOC_MIN_SIZE & (KMALLOC_MIN_SIZE - 1))); + !is_power_of_2(KMALLOC_MIN_SIZE)); for (i = 8; i < KMALLOC_MIN_SIZE; i += 8) size_index[(i - 1) / 8] = KMALLOC_SHIFT_LOW; -- Vignesh Babu BM _____________________________________________________________ "Why is it that every time I'm with you, makes me believe in magic?" -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org