From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH 03/10] mm: tag reseve pages From: Peter Zijlstra In-Reply-To: References: <20070806102922.907530000@chello.nl> <20070806103658.356795000@chello.nl> Content-Type: text/plain Date: Mon, 06 Aug 2007 20:47:59 +0200 Message-Id: <1186426079.11797.88.camel@lappy> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Andi Kleen , linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Miller , Andrew Morton , Daniel Phillips , Pekka Enberg , Matt Mackall , Lee Schermerhorn , Steve Dickson List-ID: On Mon, 2007-08-06 at 11:43 -0700, Christoph Lameter wrote: > On Mon, 6 Aug 2007, Andi Kleen wrote: > > > > > pgoff_t index; /* Our offset within mapping. */ > > > > void *freelist; /* SLUB: freelist req. slab lock */ > > > > + int reserve; /* page_alloc: page is a reserve page */ > > > > > > Extending page struct ??? > > > > Note it's an union. > > Ok. Then under what conditions can we use reserve? Right after alloc? Yes, its usually only observed right after alloc. Its basically an extra return value. Daniel suggested it was about saving page flags, _maybe_. The value is 1) rare and 2) usually only interesting right after alloc. So wasting a precious page flag which would keep this state for the duration of the whole allocation seemed like a waste. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org