* [PATCH] mm: fixup /proc/vmstat output
@ 2007-07-06 11:35 Peter Zijlstra
2007-07-06 17:18 ` Alexey Dobriyan
2007-07-06 17:52 ` Christoph Lameter
0 siblings, 2 replies; 3+ messages in thread
From: Peter Zijlstra @ 2007-07-06 11:35 UTC (permalink / raw)
To: linux-kernel, linux-mm, Linus Torvalds, Andrew Morton
Cc: Fengguang Wu, Rusty Russell, Christoph Lameter, riel
Line up the vmstat_text with zone_stat_item
enum zone_stat_item {
/* First 128 byte cacheline (assuming 64 bit words) */
NR_FREE_PAGES,
NR_INACTIVE,
NR_ACTIVE,
We current have nr_active and nr_inactive reversed.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
mm/vmstat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/mm/vmstat.c
===================================================================
--- linux-2.6.orig/mm/vmstat.c
+++ linux-2.6/mm/vmstat.c
@@ -700,8 +700,8 @@ const struct seq_operations pagetypeinfo
static const char * const vmstat_text[] = {
/* Zoned VM counters */
"nr_free_pages",
- "nr_active",
"nr_inactive",
+ "nr_active",
"nr_anon_pages",
"nr_mapped",
"nr_file_pages",
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm: fixup /proc/vmstat output
2007-07-06 11:35 [PATCH] mm: fixup /proc/vmstat output Peter Zijlstra
@ 2007-07-06 17:18 ` Alexey Dobriyan
2007-07-06 17:52 ` Christoph Lameter
1 sibling, 0 replies; 3+ messages in thread
From: Alexey Dobriyan @ 2007-07-06 17:18 UTC (permalink / raw)
To: Peter Zijlstra
Cc: linux-kernel, linux-mm, Linus Torvalds, Andrew Morton,
Fengguang Wu, Rusty Russell, Christoph Lameter, riel
On Fri, Jul 06, 2007 at 01:35:34PM +0200, Peter Zijlstra wrote:
> Line up the vmstat_text with zone_stat_item
>
> enum zone_stat_item {
> /* First 128 byte cacheline (assuming 64 bit words) */
> NR_FREE_PAGES,
> NR_INACTIVE,
> NR_ACTIVE,
>
> We current have nr_active and nr_inactive reversed.
OK with patch, though using initializers canbe handy to prevent such
things in future:
static const char * const vmstat_text[] = {
[NR_FREE_PAGES] = "nr_free_pages",
...
> --- linux-2.6.orig/mm/vmstat.c
> +++ linux-2.6/mm/vmstat.c
> @@ -700,8 +700,8 @@ const struct seq_operations pagetypeinfo
> static const char * const vmstat_text[] = {
> /* Zoned VM counters */
> "nr_free_pages",
> - "nr_active",
> "nr_inactive",
> + "nr_active",
> "nr_anon_pages",
> "nr_mapped",
> "nr_file_pages",
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm: fixup /proc/vmstat output
2007-07-06 11:35 [PATCH] mm: fixup /proc/vmstat output Peter Zijlstra
2007-07-06 17:18 ` Alexey Dobriyan
@ 2007-07-06 17:52 ` Christoph Lameter
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Lameter @ 2007-07-06 17:52 UTC (permalink / raw)
To: Peter Zijlstra
Cc: linux-kernel, linux-mm, Linus Torvalds, Andrew Morton,
Fengguang Wu, Rusty Russell, riel
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-06 17:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-06 11:35 [PATCH] mm: fixup /proc/vmstat output Peter Zijlstra
2007-07-06 17:18 ` Alexey Dobriyan
2007-07-06 17:52 ` Christoph Lameter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox