From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH] Re: Sparc32: random invalid instruction occourances on sparc32 (sun4c) From: David Woodhouse In-Reply-To: References: <468A7D14.1050505@googlemail.com> Content-Type: text/plain Date: Tue, 03 Jul 2007 15:26:18 -0400 Message-Id: <1183490778.29081.35.camel@shinybook.infradead.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Mark Fortescue Cc: linux-mm@kvack.org, Andrew Morton , LKML , sparclinux@vger.kernel.org, David Miller , Christoph Lameter , William Lee Irwin III List-ID: On Tue, 2007-07-03 at 19:57 +0100, Mark Fortescue wrote: > > Commit b46b8f19c9cd435ecac4d9d12b39d78c137ecd66 partially fixed alignment > > issues but does not ensure that all 64bit alignment requirements of sparc32 > > are met. Tests have shown that the redzone2 word can become misallignd. Oops, sorry about that. I'm not sure about your patch though -- I think I'd prefer to keep the redzone misaligned (and hence _right_ next to the real data), and just deal with it. typedef unsigned long long __aligned__((BYTES_PER_WORD)) redzone_t; -- dwmw2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org