From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [patch 5/5] Optimize page_mkclean_one From: Peter Zijlstra In-Reply-To: References: <20070629135530.912094590@de.ibm.com> <20070629141528.511942868@de.ibm.com> <1183274153.15924.6.camel@localhost> Content-Type: text/plain Date: Sun, 01 Jul 2007 15:27:48 +0200 Message-Id: <1183296468.5180.10.camel@lappy> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Hugh Dickins Cc: Martin Schwidefsky , linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Sun, 2007-07-01 at 09:54 +0100, Hugh Dickins wrote: > But I could easily be overlooking something: Peter will recall. /me tries to get his brain up to speed after the OLS closing party :-) I did both pte_dirty and pte_write because I was extra careful. One _should_ imply the other, but since we'll be clearing both, I thought it prudent to also check both. I will have to think on this a little more, but I'm currently of the opinion that the optimisation is not correct. But I'll have a thorough look at s390 again when I get home. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org