linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Yinan Zhang <zhangyinan2019@email.szu.edu.cn>,
	Matthew Wilcox <willy@infradead.org>
Cc: akpm@linux-foundation.org, william.kucharski@oracle.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	yejiajian2018@email.szu.edu.cn,
	hanshenghong2019@email.szu.edu.cn,
	caoyixuan2019@email.szu.edu.cn, zhaochongxi2019@email.szu.edu.cn,
	yuhongf@szu.edu.cn
Subject: Re: [PATCH 1/2] mm/page_owner.c: introduce vmalloc allocator for page_owner
Date: Tue, 22 Mar 2022 16:10:46 +0100	[thread overview]
Message-ID: <11814119-0e5c-3e4f-29c4-d2e9b8dfb622@suse.cz> (raw)
In-Reply-To: <299aef9a-dd57-2197-f3cf-6b08c441f755@email.szu.edu.cn>

On 3/22/22 15:48, Yinan Zhang wrote:
> on 2022/3/22 11:28, Matthew Wilcox wrote:
> 
>> On Tue, Mar 22, 2022 at 11:22:24AM +0800, Yinan Zhang wrote:
>>> An application's memory consumption is high and keeps increasing,
>>> then it is suspected of having memory leak. There are several
>>> commonly used memory allocators: slab, cma, vmalloc, etc. The memory
>>> leak identification can be speed up if page information allocated
>>> by an individual allocator are analyzed individually. This patch
>>> introduce vmalloc allocator for page_owner.
>> Why is /proc/vmallocinfo not enough?
> 
> There is only one owner information in /proc/vmallocinfo: caller.
> While there are plenty of owner information in page owner,
> besides caller, it includes task id (pid), process id (tgid),
> and other useful information, which enables us for more comprehensive
> page allocation/release relevant statistics and analysis.
> 
> Adding allocator infomation can augment page owner for tracking about
> who allocates each page. And this patch adds vmalloc allocator infomation.

Hm but page_owner has the whole stack trace of allocation so it should be
easy to determine vmalloc from slab etc? How exactly would this extra field
help?




      parent reply	other threads:[~2022-03-22 15:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22  3:22 Yinan Zhang
2022-03-22  3:22 ` [PATCH 2/2] mm/vmalloc.c: record the allocator in page_owner when __vmalloc_area_node complete mapping pages to virtual address Yinan Zhang
2022-03-22  3:28 ` [PATCH 1/2] mm/page_owner.c: introduce vmalloc allocator for page_owner Matthew Wilcox
     [not found]   ` <299aef9a-dd57-2197-f3cf-6b08c441f755@email.szu.edu.cn>
2022-03-22 15:10     ` Vlastimil Babka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11814119-0e5c-3e4f-29c4-d2e9b8dfb622@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=caoyixuan2019@email.szu.edu.cn \
    --cc=hanshenghong2019@email.szu.edu.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=william.kucharski@oracle.com \
    --cc=willy@infradead.org \
    --cc=yejiajian2018@email.szu.edu.cn \
    --cc=yuhongf@szu.edu.cn \
    --cc=zhangyinan2019@email.szu.edu.cn \
    --cc=zhaochongxi2019@email.szu.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox