linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Badari Pulavarty <pbadari@us.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Albert Cahalan <acahalan@gmail.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	lkml <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	torvalds@linux-foundation.org
Subject: [PATCH] Restore shmid as inode# to fix /proc/pid/maps ABI breakage
Date: Fri, 08 Jun 2007 15:31:14 -0700	[thread overview]
Message-ID: <1181341874.14441.3.camel@dyn9047017100.beaverton.ibm.com> (raw)
In-Reply-To: <787b0d920706072351s6917ad77oe0bf381a5d5817d0@mail.gmail.com>

Andrew,

Can you include this in -mm ?

Thanks,
Badari

shmid used to be stored as inode# for shared memory segments. Some of
the proc-ps tools use this from /proc/pid/maps.  Recent cleanups
to newseg() changed it.  This patch sets inode number back to shared 
memory id to fix breakage.

Signed-off-by: Badari Pulavarty <pbadari@us.ibm.com>

Index: linux-2.6.22-rc4/ipc/shm.c
===================================================================
--- linux-2.6.22-rc4.orig/ipc/shm.c	2007-06-08 15:17:20.000000000 -0700
+++ linux-2.6.22-rc4/ipc/shm.c	2007-06-08 15:19:38.000000000 -0700
@@ -397,6 +397,11 @@ static int newseg (struct ipc_namespace 
 	shp->shm_nattch = 0;
 	shp->id = shm_buildid(ns, id, shp->shm_perm.seq);
 	shp->shm_file = file;
+	/*
+	 * shmid gets reported as "inode#" in /proc/pid/maps.
+	 * proc-ps tools use this. Changing this will break them.
+	 */
+	file->f_dentry->d_inode->i_ino = shp->id;
 
 	ns->shm_tot += numpages;
 	shm_unlock(shp);


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-06-08 22:30 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-07  3:27 [RFC][PATCH] /proc/pid/maps doesn't match "ipcs -m" shmid Albert Cahalan
2007-06-07  3:44 ` Andrew Morton
2007-06-07  4:53   ` Albert Cahalan
2007-06-07 16:20     ` Serge E. Hallyn
2007-06-08  3:45       ` Eric W. Biederman
2007-06-08  4:41         ` Albert Cahalan
2007-06-08  5:55           ` Eric W. Biederman
2007-06-08  6:51             ` Albert Cahalan
2007-06-08 22:31               ` Badari Pulavarty [this message]
2007-06-08 16:07         ` Badari Pulavarty
2007-06-08 23:43           ` [PATCH] shm: Fix the filename of hugetlb sysv shared memory Eric W. Biederman
2007-06-08 23:55             ` Andrew Morton
2007-06-09  4:32               ` Badari Pulavarty
2007-06-09  8:01                 ` Eric W. Biederman
2007-06-11 18:11             ` Andrew Morton
2007-06-11 19:55               ` Badari Pulavarty
2007-06-11 19:00             ` Adam Litke
2007-06-11 20:53               ` Ken Chen
2007-06-07 16:23     ` [RFC][PATCH] /proc/pid/maps doesn't match "ipcs -m" shmid Badari Pulavarty
2007-06-07 16:43       ` Albert Cahalan
2007-06-07 17:06         ` Badari Pulavarty
2007-06-07 19:48           ` Andrew Morton
2007-06-07 19:59             ` Badari Pulavarty
2007-06-07 20:37               ` Serge E. Hallyn
2007-06-07 20:51                 ` Serge E. Hallyn
2007-06-07 21:16                 ` Badari Pulavarty
2007-06-07 22:08                   ` Serge E. Hallyn
2007-06-07 22:21                     ` Badari Pulavarty
2007-06-07 22:22                     ` Serge E. Hallyn
2007-06-07 23:57                       ` Badari Pulavarty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1181341874.14441.3.camel@dyn9047017100.beaverton.ibm.com \
    --to=pbadari@us.ibm.com \
    --cc=acahalan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox