Re: [patch 1/1] vmscan: give referenced, active and unmapped pages a second trip around the LRU

[Peter Zijlstra <peterz@infradead.org>]

On Fri, 2007-05-25 at 01:01 -0700, Andrew Morton wrote:
> On Fri, 25 May 2007 09:51:19 +0200 Peter Zijlstra <peterz@infradead.org> wrote:
> 
> > Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> 
> But why?  It might make the VM suck.  Or swap more.  Or go oom.
> 
> I don't know how to justify merging this.

/me a tad confused here - what patch are we discussing?
The ACK was for your initial patch.

As for my patch - yes I understand that that would be difficult, but
sometimes you seem to just toss things in to see how they work out (one
can always hope, right :-)

As for the rationale: not clearing the referenced state when we do give
the page another go on the active list, means it will get yet another
one when we finally do check it (and reclaim_mapped is deemed ok).

Not doing it basically gives all those pages another go after
reclaim_mapped is set.

I realise this is not backed up by evidence of actual tests,.. :-(

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>