From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82A34C6FA99 for ; Fri, 10 Mar 2023 14:13:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 178B48E0002; Fri, 10 Mar 2023 09:13:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 128AD8E0001; Fri, 10 Mar 2023 09:13:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F32548E0002; Fri, 10 Mar 2023 09:13:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E59778E0001 for ; Fri, 10 Mar 2023 09:13:42 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CF5B41C6AFD for ; Fri, 10 Mar 2023 14:13:42 +0000 (UTC) X-FDA: 80553181884.29.8221FEC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 205C3100012 for ; Fri, 10 Mar 2023 14:13:39 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PCpVkVTI; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678457620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A7zxiTlY/KjLxdbyEM0eMfFkU0GBlfDz/AuaOXGMZI0=; b=En5YQXhpkEf3l5hINzDQjP4asoFViuaMOgqY9BarENc56ml4HVWBJoFPZTcgge/KWowpft hImKT1hv+7NG4NNIm7BylWoNOjcyevWy9bgAlLNOEPlLvZP0J1wOapN7xZpeLbDU93OiO/ oNifONEmtQZfYO445Km0nSxfNMLQ6P4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PCpVkVTI; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678457620; a=rsa-sha256; cv=none; b=vA0WbEXy+LtnWW4tVT+Be//PoAmB+EzTH2FwwcAe0tOpFrs5SvKnBemi0Eef204cdqvmbx SXyyPZHQxRetD7prBDg87YTydCUjVuowK27f70QrqT735+HB4lyQq51U9ZmrnwRy43R93O 3lqUGcMRaxpClNlBJphiz/Jscy1dEe8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678457619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A7zxiTlY/KjLxdbyEM0eMfFkU0GBlfDz/AuaOXGMZI0=; b=PCpVkVTIl0hhNTYB+Zz16CTVQpsR3JwCBs4RBqGvbOVVs8Y5cCaBFalVf2REocUT4NDn/c 0n6BWoU036P+YRP44eVYNzugZ7HycXgkcB0hrT9NWAH667n7Pe0tbrMYbosSxb7+22XM5+ g2o5Iu+8MaIaviZTYHZz8QNjafy5axE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-TaW0soj1PTinSoAixd7j9A-1; Fri, 10 Mar 2023 09:13:38 -0500 X-MC-Unique: TaW0soj1PTinSoAixd7j9A-1 Received: by mail-wm1-f72.google.com with SMTP id p22-20020a7bcc96000000b003e2036a1516so3913382wma.7 for ; Fri, 10 Mar 2023 06:13:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678457617; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=A7zxiTlY/KjLxdbyEM0eMfFkU0GBlfDz/AuaOXGMZI0=; b=MhluQnwCD25kcq0WMMFBfvOw4gS3OC1CXHD1K7Q+YwclIL5Bh5OGx6zLJTfrrpvfQ1 b4IJCBB5fXBK9l9x//oCK98/RIwoFdolt6uf+Ab7RKRjPn+tTdP4/5eRHaPNN8MOZkch FxdvyXDLZbXcev5L5mcs88NRUbZ+u3GWDeHzdzA77pIGCOhk4rft+jbO5PQpBMVN/OYE 3YlkOw3T8GxsKFb4YlLE1qJxSUFBy52Gv3SzOd/jvu5hruhOQmp1KqBSbXGoqclW4E9+ fok4C78mpRRNH8o993zmZJ1vMpDyKx5P/fb/cjRg+vlMH0+dLJGDvuMUQfwnS/d4Nexv 7dvg== X-Gm-Message-State: AO0yUKXdHP7cODkCzCl6hyU6JeXr3J8fwiyB2rYdP6lPCncLEATi23Kd 2SiRwPv+ncxQ3xkD/PNe1kvWPEjUL/O6r4IFXxhf8dNzLG05J5H3nUHMVTgunyDI4OmhoQCr0Yv LKzKg2ntJXfw= X-Received: by 2002:adf:f34c:0:b0:2c7:b3b9:a39d with SMTP id e12-20020adff34c000000b002c7b3b9a39dmr17068382wrp.11.1678457616965; Fri, 10 Mar 2023 06:13:36 -0800 (PST) X-Google-Smtp-Source: AK7set8n9E7TFK3Ba8ZSojU5csRxgVkI3eiMHH3uZmv6dakjA9e52sCj2rxvfm8TjkNYBkF6OFenTw== X-Received: by 2002:adf:f34c:0:b0:2c7:b3b9:a39d with SMTP id e12-20020adff34c000000b002c7b3b9a39dmr17068362wrp.11.1678457616612; Fri, 10 Mar 2023 06:13:36 -0800 (PST) Received: from ?IPV6:2003:cb:c707:1100:12e6:ffa5:775d:18ee? (p200300cbc707110012e6ffa5775d18ee.dip0.t-ipconnect.de. [2003:cb:c707:1100:12e6:ffa5:775d:18ee]) by smtp.gmail.com with ESMTPSA id c7-20020adffb47000000b002c567b58e9asm2202310wrs.56.2023.03.10.06.13.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Mar 2023 06:13:36 -0800 (PST) Message-ID: <117b3a88-0046-95f9-060b-98dd8c09fc64@redhat.com> Date: Fri, 10 Mar 2023 15:13:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] mm: memory-failure: correct HWPOISON_INJECT config To: Kefeng Wang , Naoya Horiguchi , Andrew Morton , linux-mm@kvack.org Cc: Miaohe Lin , linux-kernel@vger.kernel.org References: <20230310133843.76883-1-wangkefeng.wang@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230310133843.76883-1-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: wwiin1jdrxgutbk44nii31rbwkzxcpjj X-Rspamd-Queue-Id: 205C3100012 X-HE-Tag: 1678457619-540723 X-HE-Meta: U2FsdGVkX19yFvp6HZTrva4VsZgkY/U5agPGeRvo0A+IEbJAEAKcgXte/HZzflTuvWuzfX48dqEQPPs/htogdYLS9CoVrUaUm8VPLp7ExRXIiL+eRty+T8NbW+99IO868VMz4W70JEd/VMybheyYmDJlg/zTpY/SAnCT24A6/Kc4lcYdPVjxK5UYCLbEo//5Yn+aUDZ8G5BgEmcJR9SwLS+6bUrdBLAQ1RGg6uVTFsDaqNxbAMxuEHAdVMsxk84dw/JDxJu71/LU9tAAikeXNAUXeDCcRpOOkyWJBuUTh3qSqSgAQsALed4r9NJ4UEQZhbCV5BE7ByqpeOHQrnOXxyeLvJw6NRUs7s3C9ZKWNJtwzNBN32+L8vt5JTSDePjBcQCsnN6LPHD+qkysvv6KkZEq2LnWV9DfF2j+x7XSa0zQ+RvqHH1Lt2gtnnnyKHw+ybjsgqEq/wkJeoo3//r3RjlWHNdiaQbB4Smr5Vc5Drobd7f9aul/052kOt7gVzGlMMOTusInYVgWge1FWAgaspLoPHy9vYDClwD6hLxEAyA2uJwFjwsvhLm34QwkBmbCkCuc7u1HVN9WivT9tQmooL9FN0GA5AdL4J0t9Res46tP6yljxXLtT7SUVQ5zSSaAzF0snHnKujax4C+GPycaP7n8VFWx3lg88lrgdNdxNGu268uZEeRG5TGQOKRYUfu/ss0c2etcViy6uk67Er4KlqDPfenls5qfYKow7UqP0t96CV/sawbI61IVPJGwaStsx0pWgxIp6hSXPG6CqybK39P8TbK5pqtsrXQMJzAXd6mvptlG9HNRl6IEBtw9TriwY+2jwUvpX6OMxtFrfwydeYfEbwQbSISmQ2fgjBx5hcSo7bGupOWcnD8ubcWWLZ0dYsoFHqZFegeql4bLcogmKdUTv2phQHjzsFOTO9qfBp70HW2l+BS4SbZ7zJ4hDIqU/40i/AIuMqU+3CecE5V LE9bbqY0 LEmJmaSxVtlOaQh6UGhp5Y2+1r5dBvb05uU4OSUrvdjwCEUQCjs870Fo6K5fNyi7pyAPjg7hC37qX7pXpzM8Z1AyEiHcDX2cEXEQJ4+mfRKuqQz3+GptM4MQLODQd9UxGus8VaIxCKZfcZbqQggg126qNIuUJZ1lZ32t0tMzyK3herFxONOx0G7iM/vK2shTW1cg3DWOodDDiX3Hn+JmV0YHoKTy82pAaRbWDTuvs/TvZqWF5qycsWM+r4OVGR7hx9qe3eOmGM9K2BB7LmTUQUCZ/CpAyEgtaEIhfBPlLrTs6ic9bkx55ioaLvXAEGLtcKxfYV0MWnMN6z/NeHbfRYVVpzGpTNFv0fGPAfZ7zCKGjGeirNNOE8Xdx6VHgh9jJucerwM1g39Inn1QshLu/vXH4KfBM4aZaYQKBIkjPT3nRWGCxE72/vw2rwDn6Qd+hbRajFcga2JEyXFM4jTqo4NVusUTcUIS0LJnGwDe82IPqDsg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10.03.23 14:38, Kefeng Wang wrote: > Use IS_ENABLED(CONFIG_HWPOISON_INJECT) to check whether or not to > enable HWPoison injector module. > > Signed-off-by: Kefeng Wang > --- > mm/memory-failure.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index fae9baf3be16..f761704d27d7 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -168,7 +168,7 @@ static bool page_handle_poison(struct page *page, bool hugepage_or_freepage, boo > return true; > } > > -#if defined(CONFIG_HWPOISON_INJECT) || defined(CONFIG_HWPOISON_INJECT_MODULE) > +#if IS_ENABLED(CONFIG_HWPOISON_INJECT) > > u32 hwpoison_filter_enable = 0; > u32 hwpoison_filter_dev_major = ~0U; Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb