[RFC/PATCH 2/2] Make map_vm_area() static

[RFC/PATCH 2/2] Make map_vm_area() static

[Benjamin Herrenschmidt]

map_vm_area() is only ever used inside of mm/vmalloc.c. This makes
it static and removes the prototype.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

---

 include/linux/vmalloc.h |    2 --
 mm/vmalloc.c            |    3 ++-
 2 files changed, 2 insertions(+), 3 deletions(-)

Index: linux-cell/include/linux/vmalloc.h
===================================================================
--- linux-cell.orig/include/linux/vmalloc.h	2007-05-16 13:18:31.000000000 +1000
+++ linux-cell/include/linux/vmalloc.h	2007-05-16 13:18:33.000000000 +1000
@@ -66,8 +66,6 @@ extern struct vm_struct *get_vm_area_nod
 					  gfp_t gfp_mask);
 extern struct vm_struct *remove_vm_area(void *addr);
 
-extern int map_vm_area(struct vm_struct *area, pgprot_t prot,
-			struct page ***pages);
 extern void unmap_kernel_range(unsigned long addr, unsigned long size);
 
 /*
Index: linux-cell/mm/vmalloc.c
===================================================================
--- linux-cell.orig/mm/vmalloc.c	2007-05-16 13:18:18.000000000 +1000
+++ linux-cell/mm/vmalloc.c	2007-05-16 13:18:22.000000000 +1000
@@ -140,7 +140,8 @@ static inline int vmap_pud_range(pgd_t *
 	return 0;
 }
 
-int map_vm_area(struct vm_struct *area, pgprot_t prot, struct page ***pages)
+static int map_vm_area(struct vm_struct *area, pgprot_t prot,
+		       struct page ***pages)
 {
 	pgd_t *pgd;
 	unsigned long next;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [RFC/PATCH 2/2] Make map_vm_area() static

[Christoph Hellwig]

On Wed, May 16, 2007 at 01:45:29PM +1000, Benjamin Herrenschmidt wrote:
> map_vm_area() is only ever used inside of mm/vmalloc.c. This makes
> it static and removes the prototype.

Looks good.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [RFC/PATCH 2/2] Make map_vm_area() static

[Benjamin Herrenschmidt]

On Wed, 2007-05-16 at 08:57 +0200, Christoph Hellwig wrote:
> On Wed, May 16, 2007 at 01:45:29PM +1000, Benjamin Herrenschmidt wrote:
> > map_vm_area() is only ever used inside of mm/vmalloc.c. This makes
> > it static and removes the prototype.
> 
> Looks good.

Thanks. However, patch 1/2 is the interesting one for which I'd like
to get your comment since you asked me to do it this way :-)

(I know, I incorrectly labelled it powerpc: while it's generic code)

Cheers,
Ben.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>