From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Matt Mackall <mpm@selenic.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management <linux-mm@kvack.org>
Subject: Re: [patch] slob: implement RCU freeing
Date: Thu, 10 May 2007 10:22:08 +0200 [thread overview]
Message-ID: <1178785328.6810.19.camel@twins> (raw)
In-Reply-To: <4642C6A2.1090809@yahoo.com.au>
On Thu, 2007-05-10 at 17:15 +1000, Nick Piggin wrote:
> @@ -283,6 +295,12 @@
> if (c) {
> c->name = name;
> c->size = size;
> + if (flags & SLAB_DESTROY_BY_RCU) {
> + BUG_ON(c->dtor);
> + /* leave room for rcu footer at the end of object */
> + c->size += sizeof(struct slob_rcu);
> + }
> + c->flags = flags;
might want to put this hunt below
> c->ctor = ctor;
> c->dtor = dtor;
here; for c->dtor is not initialised quite yet at the BUG_ON site.
> /* ignore alignment unless it's forced */
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-05-10 8:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0705081746500.16914@schroedinger.engr.sgi.com>
[not found] ` <20070509012725.GZ11115@waste.org>
[not found] ` <Pine.LNX.4.64.0705081828300.17376@schroedinger.engr.sgi.com>
[not found] ` <20070508.185141.85412154.davem@davemloft.net>
[not found] ` <46412BB5.1060605@yahoo.com.au>
[not found] ` <20070509174238.b4152887.akpm@linux-foundation.org>
[not found] ` <46426EA1.4030408@yahoo.com.au>
[not found] ` <20070510022707.GO11115@waste.org>
2007-05-10 7:15 ` Nick Piggin
2007-05-10 7:19 ` Nick Piggin
2007-05-10 8:22 ` Peter Zijlstra [this message]
2007-05-10 8:26 ` Nick Piggin
2007-05-10 8:29 ` Peter Zijlstra
2007-05-09 4:17 Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178785328.6810.19.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox