Re: 2.6.21-rc7-mm1 on test.kernel.org

[Badari Pulavarty <pbadari@gmail.com>]

On Wed, 2007-04-25 at 01:44 +0100, Andy Whitcroft wrote:
> Badari Pulavarty wrote:
> > On Wed, 2007-04-25 at 01:16 +0100, Andy Whitcroft wrote:
> >> Andy Whitcroft wrote:
> >>> Andrew Morton wrote:
> >>>> On Tue, 24 Apr 2007 14:30:16 -0700 (PDT) Christoph Lameter <clameter@sgi.com> wrote:
> >>>>
> >>>>> On Tue, 24 Apr 2007, Andrew Morton wrote:
> >>>>>
> >>>>>>> Could we get a .config?
> >>>>>> test.kernel.org configs are subtly hidden on the front page.  Go to
> >>>>>> test.kernel.org, click on the "amd64" or "numaq" links in the title row
> >>>>>> there.
> >>>>>>
> >>>>>> The offending machine is elm3b6.
> >>>>> My x86_64 box boots fine with the indicated .config.
> >>>> So do both of mine.
> >>>>
> >>>>> Hardware related?
> >>>> Well it's AMD64, presumably real NUMA.  Maybe try numa=fake=4?
> >>> Yep real NUMA box.  Will try and get hold of the box to test.
> >>>
> >>> -apw
> >> git bisect points to:
> >>
> >>     quicklist-support-for-x86_64
> >>
> >> Reverting just this patch sorts this problem on the x86_64.
> > 
> > Hmm.. I narrowed it further down to ..
> > 
> > quicklists-for-page-table-pages-avoid-useless-virt_to_page-
> > conversion.patch
> > 
> > Andy, can you try backing out only this and enable QUICK_LIST
> > on your machine ?
> 
> Yep confirmed that reverting that one is enough to fix this machine.
> 
> -apw


Here is the patch to fix it (against -mm) ? 
Works on my machine :)

Thanks,
Badari

Signed-off-by: Badari Pulavarty <pbadari@us.ibm.com>
 include/linux/quicklist.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux-2.6.21-rc7/include/linux/quicklist.h
===================================================================
--- linux-2.6.21-rc7.orig/include/linux/quicklist.h	2007-04-24 19:10:09.000000000 -0700
+++ linux-2.6.21-rc7/include/linux/quicklist.h	2007-04-24 19:10:57.000000000 -0700
@@ -61,7 +61,8 @@ static inline void __quicklist_free(int 
 	if (unlikely(nid != numa_node_id())) {
 		if (dtor)
 			dtor(p);
-		free_hot_page(page);
+		if (put_page_testzero(page))
+			free_hot_page(page);
 		return;
 	}
 


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>