From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, neilb@suse.de, dgc@sgi.com,
tomoki.sekiyama.qu@hitachi.com, nikita@clusterfs.com,
trond.myklebust@fys.uio.no, yingchao.zhou@gmail.com
Subject: Re: [PATCH 11/12] mm: per device dirty threshold
Date: Thu, 19 Apr 2007 20:04:14 +0200 [thread overview]
Message-ID: <1177005854.2934.6.camel@lappy> (raw)
In-Reply-To: <E1Heakt-0006jg-00@dorka.pomaz.szeredi.hu>
On Thu, 2007-04-19 at 19:49 +0200, Miklos Szeredi wrote:
> > +static inline unsigned long bdi_stat_delta(void)
> > +{
> > +#ifdef CONFIG_SMP
> > + return NR_CPUS * FBC_BATCH;
>
> Shouln't this be multiplied by the number of counters to sum? I.e. 3
> if dirty and unstable are separate, and 2 if they are not.
Ah, yes, good catch. How about this:
---
Since we're adding 3 stat counters, tripple the per counter delta as
well.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
mm/page-writeback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/mm/page-writeback.c
===================================================================
--- linux-2.6.orig/mm/page-writeback.c 2007-04-19 19:59:26.000000000 +0200
+++ linux-2.6/mm/page-writeback.c 2007-04-19 20:00:09.000000000 +0200
@@ -321,7 +321,7 @@ static void balance_dirty_pages(struct a
get_dirty_limits(&background_thresh, &dirty_thresh,
&bdi_thresh, bdi);
- if (bdi_thresh < bdi_stat_delta()) {
+ if (bdi_thresh < 3*bdi_stat_delta()) {
bdi_nr_reclaimable =
bdi_stat_sum(bdi, BDI_DIRTY) +
bdi_stat_sum(bdi, BDI_UNSTABLE);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-04-19 18:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 7:10 [PATCH 00/12] per device dirty throttling -v4 Peter Zijlstra
2007-04-17 7:10 ` [PATCH 01/12] revert per-backing_dev-dirty-and-writeback-page-accounting Peter Zijlstra
2007-04-17 7:10 ` [PATCH 02/12] nfs: remove congestion_end() Peter Zijlstra
2007-04-17 7:10 ` [PATCH 03/12] lib: dampen the percpu_counter FBC_BATCH Peter Zijlstra
2007-04-17 7:10 ` [PATCH 04/12] lib: percpu_counter_mod64 Peter Zijlstra
2007-04-17 7:10 ` [PATCH 05/12] mm: bdi init hooks Peter Zijlstra
2007-04-17 7:10 ` [PATCH 06/12] mm: scalable bdi statistics counters Peter Zijlstra
2007-04-17 7:10 ` [PATCH 07/12] mm: count dirty pages per BDI Peter Zijlstra
2007-04-17 7:10 ` [PATCH 08/12] mm: count writeback " Peter Zijlstra
2007-04-17 7:10 ` [PATCH 09/12] mm: count unstable " Peter Zijlstra
2007-04-19 17:44 ` Miklos Szeredi
2007-04-19 18:12 ` Peter Zijlstra
2007-04-19 18:46 ` Peter Zijlstra
2007-04-19 19:00 ` Peter Zijlstra
2007-04-19 19:20 ` Miklos Szeredi
2007-04-19 19:23 ` Peter Zijlstra
2007-04-17 7:10 ` [PATCH 10/12] mm: expose BDI statistics in sysfs Peter Zijlstra
2007-04-17 7:10 ` [PATCH 11/12] mm: per device dirty threshold Peter Zijlstra
2007-04-19 17:49 ` Miklos Szeredi
2007-04-19 18:04 ` Peter Zijlstra [this message]
2007-04-17 7:10 ` [PATCH 12/12] debug: expose BDI statistics in sysfs Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1177005854.2934.6.camel@lappy \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=dgc@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miklos@szeredi.hu \
--cc=neilb@suse.de \
--cc=nikita@clusterfs.com \
--cc=tomoki.sekiyama.qu@hitachi.com \
--cc=trond.myklebust@fys.uio.no \
--cc=yingchao.zhou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox