From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3323C02194 for ; Sat, 1 Feb 2025 07:32:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FD1F6B007B; Sat, 1 Feb 2025 02:32:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7ADB36B0082; Sat, 1 Feb 2025 02:32:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A5116B0083; Sat, 1 Feb 2025 02:32:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4C4DE6B007B for ; Sat, 1 Feb 2025 02:32:17 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 006AB48B3A for ; Sat, 1 Feb 2025 07:32:16 +0000 (UTC) X-FDA: 83070557514.03.1BD482F Received: from sender3-pp-f112.zoho.com (sender3-pp-f112.zoho.com [136.143.184.112]) by imf02.hostedemail.com (Postfix) with ESMTP id 03E848000C for ; Sat, 1 Feb 2025 07:32:14 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=fkMhyP05; dmarc=pass (policy=none) header.from=collabora.com; spf=pass (imf02.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.184.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1738395135; a=rsa-sha256; cv=pass; b=2CS4lqmJgaEBJiQCNmgIPCd6w7PbQuqMHw/wQtPCMsMhOwkr0bafQtclCQSALYo5SpK4zp 6czn16W6qqiOwhrnEFWgid3VjwTE3/xEUsRnTrhmJ1LCezhwu+ddtYMmwu84fPtywebwDE FZoU/L3hMGppj6niWJGfFiVMI6c+RAY= ARC-Authentication-Results: i=2; imf02.hostedemail.com; dkim=pass header.d=collabora.com header.s=zohomail header.b=fkMhyP05; dmarc=pass (policy=none) header.from=collabora.com; spf=pass (imf02.hostedemail.com: domain of Usama.Anjum@collabora.com designates 136.143.184.112 as permitted sender) smtp.mailfrom=Usama.Anjum@collabora.com; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738395135; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yPIDVcDWLvCXO6qjUDSCw6w2/zuz4gmUpH3iRUBTW9Q=; b=3R0xj31BIZjKUx8NK5iMIfKiVDpx5AUm2VeG2dTmjMREwOxiAjx8eLO52pmUjibUwYtEsW yqps2FMv21FD9cqYJGeFXR/C8OCmi6r2eIkXvDYgdNxmfaqIn9kX8CGukPRv3x6jrhqjMa ZtNu5ebX9p7MHHZf9uQ24TcFX6sIPe0= ARC-Seal: i=1; a=rsa-sha256; t=1738395113; cv=none; d=zohomail.com; s=zohoarc; b=Rfe9ZSjSkKPaFz/t1ESMbVqwfIOHPKTA8PHTBdoX2/DSOf+QqWzIlt9ns9BM9lLkeMKSSO6J8u28u0f+zy1mzKXUV0K1J0rFhTLFO77qAhVv/bKhVXxXkgWxBQSEzePKf0nEfXL898Y3fV/QsSkqXiSg39TghdffAHcjewYBSOk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1738395113; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=yPIDVcDWLvCXO6qjUDSCw6w2/zuz4gmUpH3iRUBTW9Q=; b=XQ6/6DNOKlLnCf3mv8FDGhbcpBTgpdZT5ae7GHbkglsTTjNlfwPCYbauZL15W1sWiJAvYjTxic7fLOZGd4CBdywXhA97TCHI6uU9L/zUUfZStUfAir0Fs3eRSyGcI//p52ZRUfIvJsaWfCJm8rinGbVU4OgQPLSqOZdPm98CyPU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=Usama.Anjum@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1738395113; s=zohomail; d=collabora.com; i=Usama.Anjum@collabora.com; h=Message-ID:Date:Date:MIME-Version:Cc:Cc:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=yPIDVcDWLvCXO6qjUDSCw6w2/zuz4gmUpH3iRUBTW9Q=; b=fkMhyP05nlECwp+8afA6ZdCnXRBEGqqOatHDveQW33cEN62Ivjo0lPQaOD66Fj7R dTRof9zsUg1tbDv+sU8BRWAsZpVXVSjpsf3kOL/7NfC3LWLNjOnECJvchoCHtYIHFlN loWAzalLSyl4C0nZ3tTxrZUzDiQd6IUpAmaA6Q8Q= Received: by mx.zohomail.com with SMTPS id 1738395109031628.7086343806136; Fri, 31 Jan 2025 23:31:49 -0800 (PST) Message-ID: <1175024c-6ef7-4557-95ca-180dd0a3dd5b@collabora.com> Date: Sat, 1 Feb 2025 12:32:20 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Usama.Anjum@collabora.com, Kees Cook , Andy Lutomirski , Will Drewry , Shuah Khan , Andrew Morton , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel@collabora.com Subject: Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters To: David Laight References: <20250109173842.1142376-1-usama.anjum@collabora.com> <20250109173842.1142376-2-usama.anjum@collabora.com> <20250110190057.2294fd5a@pumpkin> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <20250110190057.2294fd5a@pumpkin> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-Rspam-User: X-Rspamd-Queue-Id: 03E848000C X-Rspamd-Server: rspam10 X-Stat-Signature: dw9x8z6iy7ycmhngqtog93ksdifoapyu X-HE-Tag: 1738395134-19119 X-HE-Meta: U2FsdGVkX186H4VitknZDTbOIaA+MH91mZxMdy9iQCru2J+cFHu6ofweBiIC48igHyX+L9Ztl4WbOKBTUucgnDkpM8c4dzln9FggWxSYGBFt8qidir3T75ZTspeXXKyApIL3WNRmzOy/0eUn358tn9OoYv4xKg1JX1e/XdunT0M4VcPhPK13a06srdKVp2Sc7JNZeBhwnl9aoImzThQ9/oSSnsQdGHeMF6XBG0vCUG0reldYpXOJ2ZcsqFdQitI+6ZsESBhxfWEDsC11i8+G40YrTsKK9+IB1tbTBr8eq44y9sPl7zKjleHmcIMnwmZ0CZ/BcVYDu/skPA6WWgiu4bG9QNClY/2wLXOElgoDyBN8I63Ajgmr+QPlRlCQNBxnQklD83mqEptzQ1ValWzmwUMPLlF2sVtv9F+KKOzLSXHy9FSUHjXL9LsoU/TYMbBwkFFGeUYofSCooIRO0ALy5ouD8lnh37KDFZmQAG5m692yK4yYRi/0ozmhVZD3LLlGjMOlJOIC8Lh/8sRGCiha12DRB373CEgTR/7TGy5d9jdu4lzP+vQjKHv+m+G/OavwSK0dHfrifdeU2Kse5Zfv+uuYX6S/8Ba4MZqi5gXUnuq5jn22PdJEHeF/RFNf+MVrpoFU/wTOQkxhKabDO+aRNgkDxZo7XINSryvr8vvTPfJ/fgX6knWUuIwMGECBdV+falgivF5Lk/hUDhcGeBRQUmYz9A/nYssJ6jZuaDXB32Bl0e6NWSrTfdVxPoBFfOUzH8iFHiY0fDxFJqe4uQwr4Pj8mlas3qvkAl4eM9WsSHZVSKU0vLcmu7M244gToMLZroF2agjmNWBeH29kgGkElCjPfh+AQygBcJxDa+2P8r4rzjWV/oHloP1GqyIKjzF4Qprh0FlFX8CHEvqgbIHlUzT9uVlgBYP58Mp11ixcbCV54JrR3HwDS2+vL3RkJb31w1emoGj4gpTsAmZ1faV APLb5Qx+ D78+KPdye/GVLJ6YHST+OoAbTNCbOCR+tRtLjhifhiUipJSNrEjtudCDhbMXpMr78V6SVDZqDGWYDNgZV+mpe5WdeSOH49jRoVgPZtpqMAiGhmiwbzZYR9Wqds5gh8ERfqNRtEPJJzZ7QOxjy04vzJhbCd1nA5sK0izJer+JCECaYh6JFOfe2QDtTQSMSKhTsGuZKOF5jLkFMAt5Y6e+W2JfZkfyNz06mCDhLhPy6Vu9WoKu+GmYZRo0os0WbABvFZzdyApt0ZGvXzyvB4DlYP2fgSJVFGCXII3VxPnWazv6bGVy3683TEIkuWDlVS02zShuqVX5n+SR6k9090vQp+ykkW4iRlGPgAe8QAgS2nTvMGcLjeTAC3gMyLL1j1nGhZriqr3xwsWPvUdo3Ar6Fy8kbmSvdFgIGKPR7rYX5lbtucI2qeoDeett/CikJmqDNwgUW41LCZOpLpVugau0cjmaZ1g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000365, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/11/25 12:00 AM, David Laight wrote: > On Thu, 9 Jan 2025 22:38:27 +0500 > Muhammad Usama Anjum wrote: > >> Remove the following warnings by removing unused argc and argv >> parameters: >> In function ‘main’: >> warning: unused parameter ‘argc’ [-Wunused-parameter] >> 158 | int main(int argc, char *argv[]) >> | ~~~~^~~~ >> warning: unused parameter ‘argv’ [-Wunused-parameter] >> 158 | int main(int argc, char *argv[]) > ... >> diff --git a/tools/testing/selftests/mm/compaction_test.c b/tools/testing/selftests/mm/compaction_test.c >> index 2c3a0eb6b22d3..8d23b698ce9db 100644 >> --- a/tools/testing/selftests/mm/compaction_test.c >> +++ b/tools/testing/selftests/mm/compaction_test.c >> @@ -194,7 +194,7 @@ int set_zero_hugepages(unsigned long *initial_nr_hugepages) >> return ret; >> } >> >> -int main(int argc, char **argv) >> +int main(void) > > Doesn't that generate a different warning because main() is a special function > and gcc knows the arguments it should have. No, we still get unused argument warning. > > Just disable -Wunused-parameter - there are far too many places where it produces > unwanted warnings. The purpose is to run static analyzer and find obvious errors to enhance quality of the code which is only possible if we start using these compiler flags. This is just my thinking. Feel free to share your thoughts? -- BR, Muhammad Usama Anjum