From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [patch] rfc: introduce /dev/hugetlb From: Benjamin Herrenschmidt In-Reply-To: References: Content-Type: text/plain Date: Sat, 24 Mar 2007 08:08:54 +1100 Message-Id: <1174684134.10836.74.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Ken Chen Cc: Adam Litke , Andrew Morton , Arjan van de Ven , William Lee Irwin III , Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: > -#ifdef HAVE_ARCH_HUGETLB_UNMAPPED_AREA > -unsigned long hugetlb_get_unmapped_area(struct file *file, unsigned long addr, > - unsigned long len, unsigned long pgoff, unsigned long flags); > -#else > -static unsigned long > +unsigned long > hugetlb_get_unmapped_area(struct file *file, unsigned long addr, > unsigned long len, unsigned long pgoff, unsigned long flags) > { > @@ -150,7 +145,6 @@ full_search: > addr = ALIGN(vma->vm_end, HPAGE_SIZE); > } > } > -#endif WTF ? get_unmapped_area() -has- to be arch in some platforms like power... I'm trying to improve the whole get_unmapped_area() to better handle multiple constraints (cacheability, page size, ...) though I haven't quite yet settled on an interface I like. Ben. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org