From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ken Chen <kenchen@google.com>
Cc: Adam Litke <agl@us.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Arjan van de Ven <arjan@infradead.org>,
William Lee Irwin III <wli@holomorphy.com>,
Christoph Hellwig <hch@infradead.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] rfc: introduce /dev/hugetlb
Date: Sat, 24 Mar 2007 08:08:54 +1100 [thread overview]
Message-ID: <1174684134.10836.74.camel@localhost.localdomain> (raw)
In-Reply-To: <b040c32a0703230144r635d7902g2c36ecd7f412be31@mail.gmail.com>
> -#ifdef HAVE_ARCH_HUGETLB_UNMAPPED_AREA
> -unsigned long hugetlb_get_unmapped_area(struct file *file, unsigned long addr,
> - unsigned long len, unsigned long pgoff, unsigned long flags);
> -#else
> -static unsigned long
> +unsigned long
> hugetlb_get_unmapped_area(struct file *file, unsigned long addr,
> unsigned long len, unsigned long pgoff, unsigned long flags)
> {
> @@ -150,7 +145,6 @@ full_search:
> addr = ALIGN(vma->vm_end, HPAGE_SIZE);
> }
> }
> -#endif
WTF ? get_unmapped_area() -has- to be arch in some platforms like
power...
I'm trying to improve the whole get_unmapped_area() to better handle
multiple constraints (cacheability, page size, ...) though I haven't
quite yet settled on an interface I like.
Ben.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-03-23 21:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 8:44 Ken Chen
2007-03-23 15:03 ` William Lee Irwin III
2007-03-23 21:56 ` Ken Chen
2007-03-23 15:03 ` Mel Gorman
2007-03-23 15:09 ` William Lee Irwin III
2007-03-23 15:15 ` Mel Gorman
2007-03-23 15:30 ` William Lee Irwin III
2007-03-23 22:04 ` Ken Chen
2007-03-23 21:08 ` Benjamin Herrenschmidt [this message]
2007-03-24 4:58 ` Andrew Morton
2007-03-24 5:32 ` Nish Aravamudan
2007-03-24 6:12 ` Andrew Morton
2007-03-24 6:57 ` Sam Ravnborg
2007-03-24 7:41 ` Andrew Morton
2007-03-24 7:11 ` Ken Chen
2007-03-24 7:39 ` Andrew Morton
2007-03-25 10:22 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1174684134.10836.74.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=agl@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=hch@infradead.org \
--cc=kenchen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox