From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by kanga.kvack.org (Postfix) with ESMTP id 9BA1A6B025D for ; Tue, 15 Sep 2015 02:34:38 -0400 (EDT) Received: by wiclk2 with SMTP id lk2so13667704wic.0 for ; Mon, 14 Sep 2015 23:34:38 -0700 (PDT) Received: from mout.kundenserver.de (mout.kundenserver.de. [212.227.17.10]) by mx.google.com with ESMTPS id t9si22199581wiz.2.2015.09.14.23.34.36 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Sep 2015 23:34:37 -0700 (PDT) From: Arnd Bergmann Subject: Re: [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes Date: Tue, 15 Sep 2015 08:30:55 +0200 Message-ID: <11729827.zzMdq0fFyE@wuerfel> In-Reply-To: <20150915020438.GG32551@linux> References: <81516fb9c662cc338b5af5b63fbbcde5374e0893.1442202447.git.viresh.kumar@linaro.org> <20150914160348.GA7290@kroah.com> <20150915020438.GG32551@linux> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: owner-linux-mm@kvack.org List-ID: To: Viresh Kumar Cc: Greg KH , linaro-kernel@lists.linaro.org, "open list:NETWORKING DRIVERS WIRELESS" , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Avri Altman , Stanislaw Gruszka , Jiri Slaby , "open list:DOCUMENTATION" , Peter Zijlstra , Catalin Marinas , Mark Brown , Jaroslav Kysela , "open list:MEMORY MANAGEMENT" , Kalle Valo , Emmanuel Grumbach , Wang Long , Richard Fitzgerald , Ingo Molnar , Johan Hedberg , Davidlohr Bueso , Joonsoo Kim , Jonathan Corbet , Joerg Roedel , "open list:WOLFSON MICROELECTRONICS DRIVERS" , Sebastian Ott , "open list:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER" , Intel Linux Wireless , "open list:ACPI" , "open list:QUALCOMM ATHEROS ATH9K WIRELESS DRIVER" , Nick Kossifidis , "open list:B43 WIRELESS DRIVER" , Luciano Coelho , Doug Thompson , Gustavo Padovan , Sasha Levin , Tomas Winkler , Sebastian Andrzej Siewior , sboyd@codeaurora.org, Len Brown , Takashi Iwai , Hariprasad S , Johannes Berg , Mauro Carvalho Chehab , Vlastimil Babka , Arik Nemtsov , Marcel Holtmann , David Rientjes , Michal Hocko , Akinobu Mita , QCA ath9k Development , Michael Kerrisk , Tejun Heo , Florian Fainelli , Borislav Petkov , Oleg Nesterov , Charles Keepax , Mel Gorman , "moderated list:ARM64 PORT AARCH64 ARCHITECTURE" , "open list:EDAC-CORE" , Haggai Eran , "James E.J. Bottomley" , Chaya Rachel Ivgi , "open list:CISCO SCSI HBA DRIVER" , Brian Silverman , "Luis R. Rodriguez" , "open list:CXGB4 ETHERNET DRIVER CXGB4" , "open list:ULTRA-WIDEBAND UWB SUBSYSTEM:" , Rafael Wysocki , Liam Girdwood , Sesidhar Baddela , open list , "open list:BLUETOOTH DRIVERS" , "open list:AMD IOMMU AMD-VI" , Dmitry Monakhov , Thomas Gleixner , Narsimhulu Musini , Johannes Weiner , Joe Perches , Eliad Peller , Andrew Morton , Alexander Duyck , Larry Finger On Tuesday 15 September 2015 07:34:38 Viresh Kumar wrote: > On 14-09-15, 09:03, Greg KH wrote: > > What ever ones you think it is relevant for :) > > "Relevant" is a relevant term :) > > So, the patch which defined the type bool as _Bool was added in v2.6.19 :) > > 6e2182874324 ("[PATCH] Generic boolean") > > So, I will try at least for v3.10+ as they are used by a lot of > people, as they are LTS kernels. But wasn't sure if I should do it > right from 2.6.19. I don't think there is any use in backporting the global type change, that is too invasive and does not change much. The specific bug in the acpi code dates back to when acpi_ec_add_debugfs() was added in 2.6.36, so that is the earliest point it could be backported to. Then again, as I said it is only a problem on big-endian 64-bit architectures, and on ACPI that would specifically mean arm64, which only very recently gained ACPI support, so backporting to 4.1 is probably enough. Arnd -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org