From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH 03/29] mm: allow PF_MEMALLOC from softirq context From: Arjan van de Ven In-Reply-To: <20070221144841.823705000@taijtu.programming.kicks-ass.net> References: <20070221144304.512721000@taijtu.programming.kicks-ass.net> <20070221144841.823705000@taijtu.programming.kicks-ass.net> Content-Type: text/plain Date: Wed, 21 Feb 2007 16:53:37 +0100 Message-Id: <1172073217.3531.200.camel@laptopd505.fenrus.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, Trond Myklebust , Thomas Graf , David Miller List-ID: > Index: linux-2.6-git/kernel/softirq.c > =================================================================== > --- linux-2.6-git.orig/kernel/softirq.c 2006-12-14 10:02:18.000000000 +0100 > +++ linux-2.6-git/kernel/softirq.c 2006-12-14 10:02:52.000000000 +0100 > @@ -209,6 +209,8 @@ asmlinkage void __do_softirq(void) > __u32 pending; > int max_restart = MAX_SOFTIRQ_RESTART; > int cpu; > + unsigned long pflags = current->flags; > + current->flags &= ~PF_MEMALLOC; > > pending = local_softirq_pending(); > account_system_vtime(current); > @@ -247,6 +249,7 @@ restart: > > account_system_vtime(current); > _local_bh_enable(); > + current->flags = pflags; this wipes out all the flags in one go.... evil. What if something just selected this process for OOM killing? you nuke that flag here again. Would be nicer if only the PF_MEMALLOC bit got inherited in the restore path.. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org