From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFD6BC369DC for ; Tue, 29 Apr 2025 12:22:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F365C6B0006; Tue, 29 Apr 2025 08:22:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE30E6B0007; Tue, 29 Apr 2025 08:22:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5BBF6B0008; Tue, 29 Apr 2025 08:22:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B35696B0006 for ; Tue, 29 Apr 2025 08:22:07 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5821AB666D for ; Tue, 29 Apr 2025 12:22:08 +0000 (UTC) X-FDA: 83386993536.15.C40D6E5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id CC48C80004 for ; Tue, 29 Apr 2025 12:22:05 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mhn0SrjY; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745929326; a=rsa-sha256; cv=none; b=B9CnWmB1QUXfJYlF/StF3tRYfhPzAdAgJvbLFaid/bUg/dEhTPUVE5tYh3namM+s4XDZTC 6TfMiDm0STTYzX1w1Wnt7lfcK2bKObixkzITAkGuqnBxduk9fyiIIRl7AM0Ot4fhVafuLP 09yVm32SF+pnW0LEO1piiRCCoFuXchU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mhn0SrjY; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745929326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hu0T3YBPYeglvNoFV7uLeHvf/p7IaZ74RGzxo9in5d0=; b=0JkIFmQxgFzw1jTAePhL/wsx6sQl59mQSwtFRLNAaEVkm8/DTXyRpkQTC16cKxmIDcQOuH QYVVN5HA4t6XA/eghjwitfEIqkL+pngTEB88J853+9/CnXncyBizI4UdFWw6HuUYY78Gan pBOYUAmqU6vwpgC1eJG+GoCw/Nng4JM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745929325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hu0T3YBPYeglvNoFV7uLeHvf/p7IaZ74RGzxo9in5d0=; b=Mhn0SrjYagRgHJ+0NxuddQlLgy1zJ6adHybxH8EOmj148Gdzc2esXu7PsR+bndGIAVZ5i3 ouNarUUzHXFJrXvwxjfKQEhXdeVhaL0VKEFDp5CmJ5sxekjzfxncIrbIVkkqPUS8JlsZX4 MQbr/Oh7fneHP9YvjEIdI3/R5g1fxUc= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-PjMXyahMMmmEjmFsK1URJQ-1; Tue, 29 Apr 2025 08:22:03 -0400 X-MC-Unique: PjMXyahMMmmEjmFsK1URJQ-1 X-Mimecast-MFC-AGG-ID: PjMXyahMMmmEjmFsK1URJQ_1745929322 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-39ee54d5a00so1963988f8f.1 for ; Tue, 29 Apr 2025 05:22:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745929322; x=1746534122; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=hu0T3YBPYeglvNoFV7uLeHvf/p7IaZ74RGzxo9in5d0=; b=Yu2tOtYgHPmEPUomO4wyJ3PJ0UCX0A2AbfDRRTXkOF0elwiE5+ZXqqdETctDZ+v4LE zFEACUxp8Z3dY5jhmLpIXrlbHAogkPyOWRbPz+Qlyy0SpboRlN09PsLonHvHTdYwpAdG KjTqgQooAeBItdaNcDmtDn6z3NBtpkeebvkx3MtM2y3HV4mvdbpmwBjnhZ0Gi7lGdGby uLfh2Q5/evLTi4ULtd4yk9ZnWPp9+OZD5XleVfkDUxEdOrfwUwr6IFNMpXmoEnj1afDq GjFA7Tm6gkvAoZp1gJmZPuCYTMcsqckAZ0Z2ueiAdDv4N4FQ0sRsqZzTPu/RNKkPdvwm B8Kw== X-Forwarded-Encrypted: i=1; AJvYcCXwm1sUZPa3X41Qi8AOK5+Kp5ZpM02X0+Nyl9gyovFH0w8ne4vptihs9CWFkIN3NSwKqDcREjKNWg==@kvack.org X-Gm-Message-State: AOJu0YyvQ7SddyC4GD5jg0DX+csouyrwVYvoRQKfAyBtZ9Cl2mP8KFwN eAV/M1xR0IGfyCEX7l+Mt3s/ldhOOMZXazHoK3kWhjVs140BlVvDfWSKwBF4g8/x82EfO0e9qsp wfPjeEO6vhk0l6aJg2uWwy5YE0LDiBvI0dE32UHjkveMLw5M8 X-Gm-Gg: ASbGncszaqQ1eF3RTC/PN+rOODjFSIF17L5sOfgrcij0MHAh7OoTgBOnHgQ5/Ebpjui tQLkf4M/7avZ1DIjZ71AjKGw27/jHEKdy464NV0Ti5HJWrHAgpBK3tiA4/2PobLQBukvfBMUG3q 1QPVcKKyACiKr5kAdXDF/Oazgebz+i2APv8VD29/6rEEPOSB+CkEpCaJdy/uDPEquIIaQ2QAjZ4 sV7Z4pkKe7ys/Oge+l8UiT1OcWzyN1GLzbvLxyzrlFe9wYEMGCKZHHPDHiK1Yi0JUTm453r6Y9S U/Il3M5GSbFX4h9TjLIWTqofPVxhsvube8LWhITj45rY/A/1QOE7loqi5HmFopdCyEL/+CUg8ar E8slDN/PACjEmnvv/itSOsWLF7fehDelke0xysig= X-Received: by 2002:a05:6000:1ace:b0:3a0:880f:1a87 with SMTP id ffacd0b85a97d-3a08ad7da15mr2171467f8f.51.1745929322491; Tue, 29 Apr 2025 05:22:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFhAWUDNvU6wR5dToGt3Tw2/yFm5KjNYTdLqDXuXRRDZf9Rh68gGKUKiH3JzrsUo/LsrkIA5g== X-Received: by 2002:a05:6000:1ace:b0:3a0:880f:1a87 with SMTP id ffacd0b85a97d-3a08ad7da15mr2171448f8f.51.1745929322113; Tue, 29 Apr 2025 05:22:02 -0700 (PDT) Received: from ?IPV6:2003:cb:c73b:fa00:8909:2d07:8909:6a5a? (p200300cbc73bfa0089092d0789096a5a.dip0.t-ipconnect.de. [2003:cb:c73b:fa00:8909:2d07:8909:6a5a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d2a2386sm191282065e9.14.2025.04.29.05.22.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Apr 2025 05:22:01 -0700 (PDT) Message-ID: <116d8920-6154-4ed1-946a-887cfe084fe9@redhat.com> Date: Tue, 29 Apr 2025 14:22:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/6] filemap: do not use folio_contains for swap cache folios To: Kairui Song , linux-mm@kvack.org Cc: Andrew Morton , Matthew Wilcox , Hugh Dickins , Chris Li , Yosry Ahmed , "Huang, Ying" , Nhat Pham , Johannes Weiner , linux-kernel@vger.kernel.org References: <20250429114949.41124-1-ryncsn@gmail.com> <20250429114949.41124-5-ryncsn@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250429114949.41124-5-ryncsn@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: I9vlaJ6Q4Q6OXD7LUsN52DQJeJBmLLdEhO2uTW9Lark_1745929322 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CC48C80004 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: nadyyg4m1cq84bqx3oz6tmyrea1h9ndj X-HE-Tag: 1745929325-147864 X-HE-Meta: U2FsdGVkX1+7OqAlUncUz0T9uYHvht72wRo3uRi4FJXvYo9co3lLqit8yDneUJWeX2FBlGNccWm8hSObR7Utdx66KmJ9gZKb9C0BOy/Q5p0ozp9SXXBErk23cjB5B3OWudf+Pl8xOGCw6pssSh6WGZVSX/fLPBB1mIcC10ENVzkmq4iLqvcKqykZbiGRsnVmZADtCQ8cOL/uqY561NIYckd3ozlfTrqmYjhuCT2GR8/G7G1mhlLNPxaRCy2Y1qYcvePdtNCD7qJtWASkpvIJDnQni0jrBz8fM2duYOh8/6Nn3tUmAEBHwD3lOger5Axu4u9L0D+AbL9VuIPdQk94wxAKmGnLF7DXpmnXFHCgp4yk/9XizqBucoCurQ0lIK2JFx+AsB6z7nYYkwkod1XUh1oSFzk97BIn1TQJxPWw3n5zFGeHma+28doTPACsPdfw1hr9nGMXvcu7PMOdFN6cyRPRxAh2RiiMHxp6DEBLM/kHZhbm9eYHMfx8KvEJUUvEF/UFaRfoHu9yb12HI3QOt5xuGOs/cEHG+p2FCYGGNl5tFtsoXWL+/P3YKbInSlFtulzHt2KmPv4wNNOll5C2edmIpXxEqKbWhBFTLl3/1tYnvviMIloRHqDLke+DZ255JEvBrr4h0L5YtbK2VB0n0o7L6ExptVdkZKH9rLkcA0IkzAtVCiGpA+yyPDNKNsjq+FHCzh/DqNuYVKiullNgcOUlGpRomozWndw8GInToAmHfvsP1CIeuOFW5h5/moUvX+nU+fvzlK89qK8b7X5gz2dfWVEnMQP7LdeguqIR0Y24S5xTg4mUqvqk22FyxjS15G56XXOUR0IgdW8WK2LRNUoA8MbsbW1xkE+YxyxhNlDc23IkieLA02P1RNENqQiMXqE7+lDQJ/creiT+jWvNAZO+stmFvQSq8T9DWzfeYQLg5IZugpSRf2mx8y2/XZNeo06Fxqm9+t3ZqELlQHN J8bykMsy mZj01ziEwc7egMwJRTN0tUndT8oOx+TSehfD6XSw9T3SUZcL2GNqd4T9xflyYrKEzMw3Qjok7lTVjk6BuEn3g9jXu0WNX8jUHA7fHgalgoOt4TY7m7xtAJsXtpw3z7W5CErcSnN+SNJJNWyNhHdv357RSCgeSTOplXVLuGzInJrBwxR1B91GbHZDFG4NhZ3M5LuN8IG6ePPqNTihOun8nVvR+KYIIjNhRmmcj1jiqhQsRCiDIm2K2ChGcBgKwMmZiAucNrO1Rw3rP4zBZGVpoPndQi9L3AEVzZbUUm+jFuUe/+wISsxym34xsnC8ZecMdgeX5KNbMwyHjL5Hl6YJfK8jQgmTH7/vVT6DDU1U5Lc9n8fkFQ6VamGtRWWcPLPvp0YjHEYS/zNOlKT/HCu+kdJrm4tYjeN8zI1Ixi+Pgb+1ODBfq5w2u8MRtHAz0eQEj68jS7KhzoRyJ7/eY5APopr4K7LYFRqQir2VOVSYKtKQ1+rTAIgr8w5b/jw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.04.25 13:49, Kairui Song wrote: > From: Kairui Song > > Currently, none of the folio_contains callers should encounter swap > cache folios. > > For fs/ callers, swap cache folios are never part of their workflow. > > For filemap and truncate, folio_contains is only used for sanity > checks to verify the folio index matches the expected > lookup / invalidation target. > > The swap cache does not utilize filemap or truncate helpers in ways > that would trigger these checks, as it mostly implements its own > cache management. > > Shmem won't trigger these sanity checks either unless thing went > wrong, as it would directly trigger a BUG because swap cache index are > unrelated and almost never matches shmem index. Shmem have to handle > mixed values of folios, shadows, and swap entries, so it has its own > way of handling the mapping. > > While some filemap helpers works for swap cache space, the swap cache > is different from the page cache in many ways. So this particular helper > will unlikely to work in a helpful way for swap cache folios. > > So make it explicit here that folio_contains should not be used for > swap cache folios. This helps to avoid misuse, make swap cache less > exposed and remove the folio_index usage here. > > Signed-off-by: Kairui Song > --- > include/linux/pagemap.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index af25fb640463..1dc3416a9c0d 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -935,14 +935,14 @@ static inline struct page *folio_file_page(struct folio *folio, pgoff_t index) > * @folio: The folio. > * @index: The page index within the file. > * > - * Context: The caller should have the page locked in order to prevent > - * (eg) shmem from moving the page between the page cache and swap cache > - * and changing its index in the middle of the operation. > + * Context: The caller should have the folio locked and ensure > + * (e.g.) shmem did not move this folio to swap cache. The "(e.g.)" looks weird. Maybe "ensure that e.g., shmem ..." "to the" > * Return: true or false. > */ > static inline bool folio_contains(struct folio *folio, pgoff_t index) > { > - return index - folio_index(folio) < folio_nr_pages(folio); > + VM_BUG_ON_FOLIO(folio_test_swapcache(folio), folio); Likely you want VM_WARN_ON_ONCE_FOLIO() here. > + return index - folio->index < folio_nr_pages(folio); > } > > unsigned filemap_get_folios(struct address_space *mapping, pgoff_t *start, Acked-by: David Hildenbrand -- Cheers, David / dhildenb