From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53FD7C433EF for ; Tue, 12 Oct 2021 07:12:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C7D7960EB4 for ; Tue, 12 Oct 2021 07:12:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C7D7960EB4 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 515066B006C; Tue, 12 Oct 2021 03:12:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C4F76B0071; Tue, 12 Oct 2021 03:12:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3664B6B0073; Tue, 12 Oct 2021 03:12:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0157.hostedemail.com [216.40.44.157]) by kanga.kvack.org (Postfix) with ESMTP id 284526B006C for ; Tue, 12 Oct 2021 03:12:43 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E561B31E53 for ; Tue, 12 Oct 2021 07:12:42 +0000 (UTC) X-FDA: 78686917764.04.EA23630 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2041.outbound.protection.outlook.com [40.107.243.41]) by imf02.hostedemail.com (Postfix) with ESMTP id 402577001E0D for ; Tue, 12 Oct 2021 07:12:42 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FssPLZJtp2RiGN3x8od+MP9KDbh1Pxoxrvr8jsnbrox/AK8H/DSU8uzyjYCsPRvDxooqhbHNF8MCI17OKJ8btZVjZE9WiOhgYc3/EPX4FsvDyWYUfgOne30+TncePz59RORNbYlL1uzVOELSJDBNMko+dpeS97Hd/OdWu07AA4mtNaI+ITfzjCxoLEAgtPyFA1xAZabtpl3r80QnasovGCkjqSINdvthjJ2M4sHoOK9FnUObFRsuJbWEQwvVRMHGN8uecHdEgXXyhqNopyYNkHrR9GTpusnRqyRZRzLlDpFwCRfmVItBxp6xkslmhOFHFrWuVN5FaLDpB0Cm1iqwOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iOKks8bJbBXTDmvpd8K0/iajOdaKCeSuw2W8yJHWvyk=; b=Qw36PaI21AehAbagqDci6VwUmjZerucSEDc/5qBnr6nnZboovoqbgrO66mVawVxS8XY3Rjk3cdfs6bIEbfWQF8u3iP0hSY9VnIdbfGBTkwtMj8cwO5TQ7H5T4EMN3GPivG3PjahhgydIyO6o4TP9jtNgSlcLHWw5zd+v8u2cTrrbOSTf6I5eoZf3NwAl5m0CL1NyvhWFdpK+lTot0FfcXj2ooBLlfxcFGjrEhO+6ADM3x5fwbhL7bU9/JC2stxqh6z5yFz5R8tQlUQp2jes+PqCRdomIQuqtBXT5Sro8mkvhgUQyhB/GCptLOBtUwDmCMTSjWFDWw8VEYSx2QYl6xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iOKks8bJbBXTDmvpd8K0/iajOdaKCeSuw2W8yJHWvyk=; b=rDajTaXY+NiTIZBjkNWtq0wapQ+yg59YbAXOGQscWiR87CAkXf6WOaQv3Inxz0tTjPxetJX9cgj0qETbzr4Ob5g7IImaPhjU3PbCK74QCbpI+rqMJsu+PNqIRiiUHXFYyMn1ovDtc9UY/l/ei8VfnWpNdY0zo7hZFpQrTCSSG6E= Received: from MWHPR1201MB0192.namprd12.prod.outlook.com (2603:10b6:301:5a::14) by MWHPR1201MB0077.namprd12.prod.outlook.com (2603:10b6:301:55::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Tue, 12 Oct 2021 07:12:39 +0000 Received: from MWHPR1201MB0192.namprd12.prod.outlook.com ([fe80::55c7:6fc9:b2b1:1e6a]) by MWHPR1201MB0192.namprd12.prod.outlook.com ([fe80::55c7:6fc9:b2b1:1e6a%10]) with mapi id 15.20.4587.026; Tue, 12 Oct 2021 07:12:39 +0000 Subject: Re: [linux-next:master 3520/7405] drivers/gpu/drm/msm/msm_gem.c:624:34: error: implicit declaration of function 'vmap'; did you mean 'kmap'? To: Linux Memory Management List , Rob Clark References: <202110120451.TUzdLmdv-lkp@intel.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <116b7b44-b1fb-bf47-55d0-8bb1c4dcc803@amd.com> Date: Tue, 12 Oct 2021 09:12:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <202110120451.TUzdLmdv-lkp@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-ClientProxiedBy: AM6P193CA0070.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::47) To MWHPR1201MB0192.namprd12.prod.outlook.com (2603:10b6:301:5a::14) MIME-Version: 1.0 Received: from [IPv6:2a02:908:1252:fb60:87c8:f860:ca5d:9823] (2a02:908:1252:fb60:87c8:f860:ca5d:9823) by AM6P193CA0070.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend Transport; Tue, 12 Oct 2021 07:12:38 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 419db482-3487-4fbf-685f-08d98d4facf3 X-MS-TrafficTypeDiagnostic: MWHPR1201MB0077: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:89; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /vwHlJ1nf5aRPUa349u3JOuu2+6+5FBeGUrQVYuwUrewMosHuzqz3vAcRxkYU0UnNKGkPh7xTQw7vFAhQQZTGDqfS7EWJ/Kac00a7Af1xpZ2//YawRyPfGS8hMhOXCJ4ZFA2Wr6DneFv10yYecoVuuf5Rz7qHYCDbCkLjiXb6gW2efRRkUZMiuMuacTyI9pWo4bcdX0D2UN6UXK1SxrPmexEWBl8neGAyESWfI33YsvPujggD3K9Q8Z4vLUDZRik4iMdI3w9fGR8luVCrXt8dI1D2qsXsj8p66rfjVA0t+C5K43rior07+gVhRya62m8FEgtIQs6cKLobb1iqWXm4i/JFzfoZMlHX0I+MuDY5CmH2GfGE15ZxgJfOKDtInOchfuxsZu4QEhl3qPqFJEUjIdTnLc6tEPGeRWqx7cfrPKugU9OhvfHXecz++GAUg01QcwYI+hQYDeRo+cXQjrIjfEAX1PSM++4bMk5emuUFWfCGIpsF4RsVT/FrVjf9+qkLwy/60D5MuFSH8ZfB9mem98XMO+QmiIjip3rSHprMmT84FsuEnngnIMEoy2hHd/i9Ezym6qGCzKSJWGlxAwiZ4UmhbpJ299KhGRKrx2Jc+kAtJoE2RRwleUmXG+nsjv9cY9gNla0L6o/nLr2OHEw1nEHCxscLFktLfxrEHoOzURyudhQzKpD1NdSL3o0c8aTzQ5TbFC5zlj6aqwbBX3qg4ZqkDWGkbGEWik//2K+bLDxFUOG5NkYRsr59j6alQh5Hx/YqKi3i+oCIqYCir9UydMehaAFuMREaWrt+rxRFIvTXfgNNXA8ojaNexWbthBHjqbede+DHeAM4qwQlxrrW6o0+nvhPqT3X5ANi1FgMfk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1201MB0192.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(38100700002)(36756003)(31686004)(8676002)(186003)(6666004)(316002)(110136005)(2616005)(30864003)(45080400002)(4001150100001)(2906002)(83380400001)(86362001)(508600001)(966005)(66476007)(66556008)(5660300002)(6486002)(31696002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?YrUwMrQWQcrtSdA4F2XsAjuw2k8MroU0ivPMyqBF75Ba+Sa44op47gFg?= =?Windows-1252?Q?JKnd6pryZRfo+QHAoOH6T8TK12VPSXCNe+B1rmFvKvRQcR9opxUQu2sC?= =?Windows-1252?Q?jcTDOR4iMAbxz77KbEB6+Ia/M5OncahLKZzA+RScIZPS+GgV4b21SklX?= =?Windows-1252?Q?k0hwng/2JwbDDjNxycwCGfenvBd1Z+5//+vXg7gj4wHdzSl+fN7x0x4s?= =?Windows-1252?Q?RjAFV35J9AjOKzNwFmR2WQifoS1NUfnHJXaOA12ElQywE9o9PflPfjUm?= =?Windows-1252?Q?/TJ5GCFMRamGq5+5LvD3lY5Y3qND8I34GGiJUVq2FjSe4qqjIBLivfLr?= =?Windows-1252?Q?Q2H8ziIwWvIj6oiwB0Z+9We2yNVXwcixTlqGwOnnd0CZh1mOgfxCLCkZ?= =?Windows-1252?Q?PZ2JDM2pNX3xM7+jULV3vC8nB09re1IBzae+bpNfOZGXFR4d7HnN/Be4?= =?Windows-1252?Q?LS0jaqkIB0FhqevEBhEu2/+mevCeSzjiFWFTUvVQcV/oiO3RSvKnQXNt?= =?Windows-1252?Q?80WSuYNFnhYPW37TMcBplgKOwMax1cscVd77BkkRIchB2KuukaSitFI0?= =?Windows-1252?Q?+otCrnFwEfKy2jOmmLMRpyBV2gpudyc/6TGbyQ8uW8BOF8sq7BawdNwM?= =?Windows-1252?Q?lxTCwTVRDXmGRAcEpx4MEg9gFSSA0Mbsm43PeXFlZJQ5fgmMyKzyB3jl?= =?Windows-1252?Q?G5Mxxp4ftMQlLtUxWN6EXHZE6E/Y9mQZ0dStjSPIiksA8CZDOtskhHKi?= =?Windows-1252?Q?pai733t0J2JTLIEU7tqMgfw6DTT6D0FshOtfkWfJ5N7W4tOtEU14lVoF?= =?Windows-1252?Q?P9ryzkUj10i9kIfpqZGpsX1/VImlFyNy6EHYrVUcGoJUbVA4xnMI7m+u?= =?Windows-1252?Q?Ys9+Xrt95qrZPAF9wvwAkEWK7vu7L/7HcFdrCn8rylC9G/Cgemg6aeTZ?= =?Windows-1252?Q?JCJzRuEJ5rbAijidxKIK7Tm6D83M8WSykukzbLgjAVtxXjPNlMC5JGPs?= =?Windows-1252?Q?1xKGVXstwk/Oc/v+PSF4QjrUS6OR6HydypeeDPHHX1PashyrMKQ7hLzI?= =?Windows-1252?Q?grm6xQh9Q/u36vYN/w7aK/S+kSDgRpieU3arG5InthdeGUej2Mhtb+Io?= =?Windows-1252?Q?67JFOXeHSjytU7+ozq+Rk5d328x5oXYX99WFw2bSzL6O5MH6glFuOVxn?= =?Windows-1252?Q?AAHhZhZizldXd73JaeNCgncG1OKeaJrixr+X3EjttFlVzBIZNZDYh69A?= =?Windows-1252?Q?dd6qDI4cPAdFBvSRmeDPZiKILYziYGzTCuFd/Yqu/sqemURG1F1E0srn?= =?Windows-1252?Q?L674CkFXEI+MQsBHgq0JCgVmt83pdfYD3CWad0FgAz4oVKjz4uA5DtZC?= =?Windows-1252?Q?noXRj32UTAafO8FQ1f8PSPetRFfz7kCnRgBeIlJT9+S4HzadooGCLASN?= =?Windows-1252?Q?ZgYc8F+TZmYQsYFKr0QU8e4g00nBuyRmptjgjLzXGYBnW9wb1CDkPRt/?= =?Windows-1252?Q?9o9z7Xkp?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 419db482-3487-4fbf-685f-08d98d4facf3 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1201MB0192.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2021 07:12:39.6410 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EOQLbJ6v1AVO5t5DF4gglOUm9xKLKUog23/q6iFS20h5HYiYH5suPU29nWyvIB3r X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0077 X-Rspamd-Queue-Id: 402577001E0D X-Stat-Signature: kmzrni34qittaue3wio87yg8dmb6dxtj Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=rDajTaXY; spf=pass (imf02.hostedemail.com: domain of Christian.Koenig@amd.com designates 40.107.243.41 as permitted sender) smtp.mailfrom=Christian.Koenig@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com X-Rspamd-Server: rspam06 X-HE-Tag: 1634022762-634875 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Another fallout from my patch to allow MSM to be compile tested as well. But of hand I don't see the rational why that doesn't work, can anybody help here? Thanks, Christian. Am 11.10.21 um 22:27 schrieb kernel test robot: > Hi Christian, > > First bad commit (maybe != root cause): > > tree: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-next.git&data=04%7C01%7Cchristian.koenig%40amd.com%7C8647a3be20ec4190ad4508d98cf5bb93%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637695812014623891%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=jefIm%2Bt17EDi%2BfdP1MKyKIADCDX18xM7qGxKZeJSoFM%3D&reserved=0 master > head: d3134eb5de8546a214c028fb7195e764b89da7d4 > commit: b3ed524f84f573ece1aa2f26e9db3c34a593e0d1 [3520/7405] drm/msm: allow compile_test on !ARM > config: parisc-allyesconfig (attached as .config) > compiler: hppa-linux-gcc (GCC) 11.2.0 > reproduce (this is a W=1 build): > wget https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fintel%2Flkp-tests%2Fmaster%2Fsbin%2Fmake.cross&data=04%7C01%7Cchristian.koenig%40amd.com%7C8647a3be20ec4190ad4508d98cf5bb93%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637695812014623891%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=UsAangNH6b5BwFSZ798%2FMr646v4P24jd4O5MGKjfvrA%3D&reserved=0 -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-next.git%2Fcommit%2F%3Fid%3Db3ed524f84f573ece1aa2f26e9db3c34a593e0d1&data=04%7C01%7Cchristian.koenig%40amd.com%7C8647a3be20ec4190ad4508d98cf5bb93%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637695812014623891%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=sh2NjRE1guGQwBIydiBGhMLqx7BsrlS32GLfuNr3odY%3D&reserved=0 > git remote add linux-next https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-next.git&data=04%7C01%7Cchristian.koenig%40amd.com%7C8647a3be20ec4190ad4508d98cf5bb93%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637695812014623891%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=jefIm%2Bt17EDi%2BfdP1MKyKIADCDX18xM7qGxKZeJSoFM%3D&reserved=0 > git fetch --no-tags linux-next master > git checkout b3ed524f84f573ece1aa2f26e9db3c34a593e0d1 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=parisc > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > In file included from drivers/gpu/drm/msm/msm_fence.c:9: > drivers/gpu/drm/msm/msm_drv.h:545: error: "COND" redefined [-Werror] > 545 | #define COND(bool, val) ((bool) ? (val) : 0) > | > In file included from arch/parisc/include/asm/jump_label.h:8, > from include/linux/jump_label.h:117, > from include/linux/dynamic_debug.h:6, > from include/linux/printk.h:555, > from include/linux/kernel.h:19, > from include/linux/list.h:9, > from include/linux/wait.h:7, > from include/linux/dma-fence.h:17, > from drivers/gpu/drm/msm/msm_fence.c:7: > arch/parisc/include/asm/assembly.h:37: note: this is the location of the previous definition > 37 | #define COND(x) x > | > drivers/gpu/drm/msm/msm_fence.c: In function 'msm_fence_context_alloc': >>> drivers/gpu/drm/msm/msm_fence.c:24:9: error: 'strncpy' specified bound 32 equals destination size [-Werror=stringop-truncation] > 24 | strncpy(fctx->name, name, sizeof(fctx->name)); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > -- > In file included from drivers/gpu/drm/msm/msm_gem.c:15: > drivers/gpu/drm/msm/msm_drv.h:545: error: "COND" redefined [-Werror] > 545 | #define COND(bool, val) ((bool) ? (val) : 0) > | > In file included from arch/parisc/include/asm/jump_label.h:8, > from include/linux/jump_label.h:117, > from include/linux/dynamic_debug.h:6, > from include/linux/printk.h:555, > from include/linux/kernel.h:19, > from arch/parisc/include/asm/bug.h:5, > from include/linux/bug.h:5, > from include/linux/thread_info.h:13, > from include/asm-generic/current.h:5, > from ./arch/parisc/include/generated/asm/current.h:1, > from include/linux/sched.h:12, > from include/linux/ratelimit.h:6, > from include/linux/dev_printk.h:16, > from include/linux/device.h:15, > from include/linux/dma-mapping.h:7, > from include/linux/dma-map-ops.h:9, > from drivers/gpu/drm/msm/msm_gem.c:7: > arch/parisc/include/asm/assembly.h:37: note: this is the location of the previous definition > 37 | #define COND(x) x > | > drivers/gpu/drm/msm/msm_gem.c: In function 'get_vaddr': >>> drivers/gpu/drm/msm/msm_gem.c:624:34: error: implicit declaration of function 'vmap'; did you mean 'kmap'? [-Werror=implicit-function-declaration] > 624 | msm_obj->vaddr = vmap(pages, obj->size >> PAGE_SHIFT, > | ^~~~ > | kmap >>> drivers/gpu/drm/msm/msm_gem.c:625:33: error: 'VM_MAP' undeclared (first use in this function); did you mean 'VM_MTE'? > 625 | VM_MAP, msm_gem_pgprot(msm_obj, PAGE_KERNEL)); > | ^~~~~~ > | VM_MTE > drivers/gpu/drm/msm/msm_gem.c:625:33: note: each undeclared identifier is reported only once for each function it appears in > drivers/gpu/drm/msm/msm_gem.c: In function 'msm_gem_vunmap': >>> drivers/gpu/drm/msm/msm_gem.c:777:9: error: implicit declaration of function 'vunmap'; did you mean 'kunmap'? [-Werror=implicit-function-declaration] > 777 | vunmap(msm_obj->vaddr); > | ^~~~~~ > | kunmap > cc1: all warnings being treated as errors > -- > In file included from drivers/gpu/drm/msm/msm_gem_shrinker.c:7: > drivers/gpu/drm/msm/msm_drv.h:545: error: "COND" redefined [-Werror] > 545 | #define COND(bool, val) ((bool) ? (val) : 0) > | > In file included from arch/parisc/include/asm/jump_label.h:8, > from include/linux/jump_label.h:117, > from include/linux/dynamic_debug.h:6, > from include/linux/printk.h:555, > from include/linux/kernel.h:19, > from drivers/gpu/drm/msm/msm_drv.h:11, > from drivers/gpu/drm/msm/msm_gem_shrinker.c:7: > arch/parisc/include/asm/assembly.h:37: note: this is the location of the previous definition > 37 | #define COND(x) x > | > In file included from include/linux/bug.h:5, > from include/linux/thread_info.h:13, > from include/asm-generic/current.h:5, > from ./arch/parisc/include/generated/asm/current.h:1, > from include/linux/mutex.h:14, > from include/linux/notifier.h:14, > from include/linux/clk.h:14, > from drivers/gpu/drm/msm/msm_drv.h:12, > from drivers/gpu/drm/msm/msm_gem_shrinker.c:7: > drivers/gpu/drm/msm/msm_gem_shrinker.c: In function 'msm_gem_shrinker_init': >>> drivers/gpu/drm/msm/msm_gem_shrinker.c:224:17: error: implicit declaration of function 'register_vmap_purge_notifier'; did you mean 'register_module_notifier'? [-Werror=implicit-function-declaration] > 224 | WARN_ON(register_vmap_purge_notifier(&priv->vmap_notifier)); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > arch/parisc/include/asm/bug.h:80:32: note: in definition of macro 'WARN_ON' > 80 | int __ret_warn_on = !!(x); \ > | ^ > drivers/gpu/drm/msm/msm_gem_shrinker.c: In function 'msm_gem_shrinker_cleanup': >>> drivers/gpu/drm/msm/msm_gem_shrinker.c:238:25: error: implicit declaration of function 'unregister_vmap_purge_notifier'; did you mean 'unregister_module_notifier'? [-Werror=implicit-function-declaration] > 238 | WARN_ON(unregister_vmap_purge_notifier(&priv->vmap_notifier)); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > arch/parisc/include/asm/bug.h:80:32: note: in definition of macro 'WARN_ON' > 80 | int __ret_warn_on = !!(x); \ > | ^ > cc1: all warnings being treated as errors > > > vim +624 drivers/gpu/drm/msm/msm_gem.c > > c8afe684c95cd1 Rob Clark 2013-06-26 593 > fad33f4b1073a4 Rob Clark 2017-09-15 594 static void *get_vaddr(struct drm_gem_object *obj, unsigned madv) > c8afe684c95cd1 Rob Clark 2013-06-26 595 { > c8afe684c95cd1 Rob Clark 2013-06-26 596 struct msm_gem_object *msm_obj = to_msm_bo(obj); > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 597 int ret = 0; > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 598 > 90643a24a7bfbe Rob Clark 2021-04-05 599 GEM_WARN_ON(!msm_gem_is_locked(obj)); > e4b87d227f9e82 Rob Clark 2020-10-23 600 > 8b6b7d84bfce9a Daniel Vetter 2020-05-14 601 if (obj->import_attach) > 8b6b7d84bfce9a Daniel Vetter 2020-05-14 602 return ERR_PTR(-ENODEV); > 8b6b7d84bfce9a Daniel Vetter 2020-05-14 603 > 90643a24a7bfbe Rob Clark 2021-04-05 604 if (GEM_WARN_ON(msm_obj->madv > madv)) { > 6a41da17e87dee Mamta Shukla 2018-10-20 605 DRM_DEV_ERROR(obj->dev->dev, "Invalid madv state: %u vs %u\n", > fad33f4b1073a4 Rob Clark 2017-09-15 606 msm_obj->madv, madv); > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 607 return ERR_PTR(-EBUSY); > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 608 } > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 609 > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 610 /* increment vmap_count *before* vmap() call, so shrinker can > a6ae74c956e72c Rob Clark 2020-10-23 611 * check vmap_count (is_vunmapable()) outside of msm_obj lock. > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 612 * This guarantees that we won't try to msm_gem_vunmap() this > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 613 * same object from within the vmap() call (while we already > a6ae74c956e72c Rob Clark 2020-10-23 614 * hold msm_obj lock) > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 615 */ > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 616 msm_obj->vmap_count++; > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 617 > c8afe684c95cd1 Rob Clark 2013-06-26 618 if (!msm_obj->vaddr) { > c8afe684c95cd1 Rob Clark 2013-06-26 619 struct page **pages = get_pages(obj); > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 620 if (IS_ERR(pages)) { > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 621 ret = PTR_ERR(pages); > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 622 goto fail; > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 623 } > c8afe684c95cd1 Rob Clark 2013-06-26 @624 msm_obj->vaddr = vmap(pages, obj->size >> PAGE_SHIFT, > af9b3547079915 Jonathan Marek 2021-04-23 @625 VM_MAP, msm_gem_pgprot(msm_obj, PAGE_KERNEL)); > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 626 if (msm_obj->vaddr == NULL) { > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 627 ret = -ENOMEM; > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 628 goto fail; > c8afe684c95cd1 Rob Clark 2013-06-26 629 } > 10f76165d30bf5 Rob Clark 2021-04-26 630 > 10f76165d30bf5 Rob Clark 2021-04-26 631 update_inactive(msm_obj); > c8afe684c95cd1 Rob Clark 2013-06-26 632 } > c8afe684c95cd1 Rob Clark 2013-06-26 633 > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 634 return msm_obj->vaddr; > c8afe684c95cd1 Rob Clark 2013-06-26 635 > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 636 fail: > e1e9db2ca79575 Rob Clark 2016-05-27 637 msm_obj->vmap_count--; > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 638 return ERR_PTR(ret); > 18f23049f640e2 Rob Clark 2016-05-26 639 } > 18f23049f640e2 Rob Clark 2016-05-26 640 > e4b87d227f9e82 Rob Clark 2020-10-23 641 void *msm_gem_get_vaddr_locked(struct drm_gem_object *obj) > fad33f4b1073a4 Rob Clark 2017-09-15 642 { > fad33f4b1073a4 Rob Clark 2017-09-15 643 return get_vaddr(obj, MSM_MADV_WILLNEED); > fad33f4b1073a4 Rob Clark 2017-09-15 644 } > fad33f4b1073a4 Rob Clark 2017-09-15 645 > e4b87d227f9e82 Rob Clark 2020-10-23 646 void *msm_gem_get_vaddr(struct drm_gem_object *obj) > e4b87d227f9e82 Rob Clark 2020-10-23 647 { > e4b87d227f9e82 Rob Clark 2020-10-23 648 void *ret; > e4b87d227f9e82 Rob Clark 2020-10-23 649 > e4b87d227f9e82 Rob Clark 2020-10-23 650 msm_gem_lock(obj); > e4b87d227f9e82 Rob Clark 2020-10-23 651 ret = msm_gem_get_vaddr_locked(obj); > e4b87d227f9e82 Rob Clark 2020-10-23 652 msm_gem_unlock(obj); > e4b87d227f9e82 Rob Clark 2020-10-23 653 > e4b87d227f9e82 Rob Clark 2020-10-23 654 return ret; > e4b87d227f9e82 Rob Clark 2020-10-23 655 } > e4b87d227f9e82 Rob Clark 2020-10-23 656 > fad33f4b1073a4 Rob Clark 2017-09-15 657 /* > fad33f4b1073a4 Rob Clark 2017-09-15 658 * Don't use this! It is for the very special case of dumping > fad33f4b1073a4 Rob Clark 2017-09-15 659 * submits from GPU hangs or faults, were the bo may already > fad33f4b1073a4 Rob Clark 2017-09-15 660 * be MSM_MADV_DONTNEED, but we know the buffer is still on the > fad33f4b1073a4 Rob Clark 2017-09-15 661 * active list. > fad33f4b1073a4 Rob Clark 2017-09-15 662 */ > fad33f4b1073a4 Rob Clark 2017-09-15 663 void *msm_gem_get_vaddr_active(struct drm_gem_object *obj) > fad33f4b1073a4 Rob Clark 2017-09-15 664 { > fad33f4b1073a4 Rob Clark 2017-09-15 665 return get_vaddr(obj, __MSM_MADV_PURGED); > fad33f4b1073a4 Rob Clark 2017-09-15 666 } > fad33f4b1073a4 Rob Clark 2017-09-15 667 > e4b87d227f9e82 Rob Clark 2020-10-23 668 void msm_gem_put_vaddr_locked(struct drm_gem_object *obj) > 18f23049f640e2 Rob Clark 2016-05-26 669 { > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 670 struct msm_gem_object *msm_obj = to_msm_bo(obj); > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 671 > 90643a24a7bfbe Rob Clark 2021-04-05 672 GEM_WARN_ON(!msm_gem_is_locked(obj)); > 90643a24a7bfbe Rob Clark 2021-04-05 673 GEM_WARN_ON(msm_obj->vmap_count < 1); > e4b87d227f9e82 Rob Clark 2020-10-23 674 > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 675 msm_obj->vmap_count--; > e4b87d227f9e82 Rob Clark 2020-10-23 676 } > e4b87d227f9e82 Rob Clark 2020-10-23 677 > e4b87d227f9e82 Rob Clark 2020-10-23 678 void msm_gem_put_vaddr(struct drm_gem_object *obj) > e4b87d227f9e82 Rob Clark 2020-10-23 679 { > e4b87d227f9e82 Rob Clark 2020-10-23 680 msm_gem_lock(obj); > e4b87d227f9e82 Rob Clark 2020-10-23 681 msm_gem_put_vaddr_locked(obj); > a6ae74c956e72c Rob Clark 2020-10-23 682 msm_gem_unlock(obj); > 18f23049f640e2 Rob Clark 2016-05-26 683 } > 18f23049f640e2 Rob Clark 2016-05-26 684 > 4cd33c48ea25ba Rob Clark 2016-05-17 685 /* Update madvise status, returns true if not purged, else > 4cd33c48ea25ba Rob Clark 2016-05-17 686 * false or -errno. > 4cd33c48ea25ba Rob Clark 2016-05-17 687 */ > 4cd33c48ea25ba Rob Clark 2016-05-17 688 int msm_gem_madvise(struct drm_gem_object *obj, unsigned madv) > 4cd33c48ea25ba Rob Clark 2016-05-17 689 { > 4cd33c48ea25ba Rob Clark 2016-05-17 690 struct msm_gem_object *msm_obj = to_msm_bo(obj); > 4cd33c48ea25ba Rob Clark 2016-05-17 691 > a6ae74c956e72c Rob Clark 2020-10-23 692 msm_gem_lock(obj); > 4cd33c48ea25ba Rob Clark 2016-05-17 693 > 4cd33c48ea25ba Rob Clark 2016-05-17 694 if (msm_obj->madv != __MSM_MADV_PURGED) > 4cd33c48ea25ba Rob Clark 2016-05-17 695 msm_obj->madv = madv; > 4cd33c48ea25ba Rob Clark 2016-05-17 696 > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 697 madv = msm_obj->madv; > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 698 > 3edfa30f2340e6 Rob Clark 2020-11-16 699 /* If the obj is inactive, we might need to move it > 3edfa30f2340e6 Rob Clark 2020-11-16 700 * between inactive lists > 3edfa30f2340e6 Rob Clark 2020-11-16 701 */ > 3edfa30f2340e6 Rob Clark 2020-11-16 702 if (msm_obj->active_count == 0) > 3edfa30f2340e6 Rob Clark 2020-11-16 703 update_inactive(msm_obj); > 3edfa30f2340e6 Rob Clark 2020-11-16 704 > a6ae74c956e72c Rob Clark 2020-10-23 705 msm_gem_unlock(obj); > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 706 > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 707 return (madv != __MSM_MADV_PURGED); > 4cd33c48ea25ba Rob Clark 2016-05-17 708 } > 4cd33c48ea25ba Rob Clark 2016-05-17 709 > 599089c6af6830 Rob Clark 2020-10-23 710 void msm_gem_purge(struct drm_gem_object *obj) > 68209390f11603 Rob Clark 2016-05-17 711 { > 68209390f11603 Rob Clark 2016-05-17 712 struct drm_device *dev = obj->dev; > 68209390f11603 Rob Clark 2016-05-17 713 struct msm_gem_object *msm_obj = to_msm_bo(obj); > 68209390f11603 Rob Clark 2016-05-17 714 > 81d4d597d4faad Rob Clark 2021-04-05 715 GEM_WARN_ON(!msm_gem_is_locked(obj)); > 90643a24a7bfbe Rob Clark 2021-04-05 716 GEM_WARN_ON(!is_purgeable(msm_obj)); > 68209390f11603 Rob Clark 2016-05-17 717 > 20d0ae2f8c72e3 Rob Clark 2021-04-05 718 /* Get rid of any iommu mapping(s): */ > 20d0ae2f8c72e3 Rob Clark 2021-04-05 719 put_iova_spaces(obj, true); > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 720 > 599089c6af6830 Rob Clark 2020-10-23 721 msm_gem_vunmap(obj); > 68209390f11603 Rob Clark 2016-05-17 722 > 81d4d597d4faad Rob Clark 2021-04-05 723 drm_vma_node_unmap(&obj->vma_node, dev->anon_inode->i_mapping); > 81d4d597d4faad Rob Clark 2021-04-05 724 > 68209390f11603 Rob Clark 2016-05-17 725 put_pages(obj); > 68209390f11603 Rob Clark 2016-05-17 726 > 9b73bde39cf24b Iskren Chernev 2020-11-26 727 put_iova_vmas(obj); > 9b73bde39cf24b Iskren Chernev 2020-11-26 728 > 68209390f11603 Rob Clark 2016-05-17 729 msm_obj->madv = __MSM_MADV_PURGED; > 25ed38b3ed2691 Rob Clark 2021-04-02 730 update_inactive(msm_obj); > 68209390f11603 Rob Clark 2016-05-17 731 > 68209390f11603 Rob Clark 2016-05-17 732 drm_gem_free_mmap_offset(obj); > 68209390f11603 Rob Clark 2016-05-17 733 > 68209390f11603 Rob Clark 2016-05-17 734 /* Our goal here is to return as much of the memory as > 68209390f11603 Rob Clark 2016-05-17 735 * is possible back to the system as we are called from OOM. > 68209390f11603 Rob Clark 2016-05-17 736 * To do this we must instruct the shmfs to drop all of its > 68209390f11603 Rob Clark 2016-05-17 737 * backing pages, *now*. > 68209390f11603 Rob Clark 2016-05-17 738 */ > 68209390f11603 Rob Clark 2016-05-17 739 shmem_truncate_range(file_inode(obj->filp), 0, (loff_t)-1); > 68209390f11603 Rob Clark 2016-05-17 740 > 68209390f11603 Rob Clark 2016-05-17 741 invalidate_mapping_pages(file_inode(obj->filp)->i_mapping, > 68209390f11603 Rob Clark 2016-05-17 742 0, (loff_t)-1); > 68209390f11603 Rob Clark 2016-05-17 743 } > 68209390f11603 Rob Clark 2016-05-17 744 > 37c68900a252ce Lee Jones 2021-06-02 745 /* > 63f17ef834284d Rob Clark 2021-04-05 746 * Unpin the backing pages and make them available to be swapped out. > 63f17ef834284d Rob Clark 2021-04-05 747 */ > 63f17ef834284d Rob Clark 2021-04-05 748 void msm_gem_evict(struct drm_gem_object *obj) > 63f17ef834284d Rob Clark 2021-04-05 749 { > 63f17ef834284d Rob Clark 2021-04-05 750 struct drm_device *dev = obj->dev; > 63f17ef834284d Rob Clark 2021-04-05 751 struct msm_gem_object *msm_obj = to_msm_bo(obj); > 63f17ef834284d Rob Clark 2021-04-05 752 > 63f17ef834284d Rob Clark 2021-04-05 753 GEM_WARN_ON(!msm_gem_is_locked(obj)); > 63f17ef834284d Rob Clark 2021-04-05 754 GEM_WARN_ON(is_unevictable(msm_obj)); > 63f17ef834284d Rob Clark 2021-04-05 755 GEM_WARN_ON(!msm_obj->evictable); > 63f17ef834284d Rob Clark 2021-04-05 756 GEM_WARN_ON(msm_obj->active_count); > 63f17ef834284d Rob Clark 2021-04-05 757 > 63f17ef834284d Rob Clark 2021-04-05 758 /* Get rid of any iommu mapping(s): */ > 63f17ef834284d Rob Clark 2021-04-05 759 put_iova_spaces(obj, false); > 63f17ef834284d Rob Clark 2021-04-05 760 > 63f17ef834284d Rob Clark 2021-04-05 761 drm_vma_node_unmap(&obj->vma_node, dev->anon_inode->i_mapping); > 63f17ef834284d Rob Clark 2021-04-05 762 > 63f17ef834284d Rob Clark 2021-04-05 763 put_pages(obj); > 63f17ef834284d Rob Clark 2021-04-05 764 > 63f17ef834284d Rob Clark 2021-04-05 765 update_inactive(msm_obj); > 63f17ef834284d Rob Clark 2021-04-05 766 } > 63f17ef834284d Rob Clark 2021-04-05 767 > 599089c6af6830 Rob Clark 2020-10-23 768 void msm_gem_vunmap(struct drm_gem_object *obj) > e1e9db2ca79575 Rob Clark 2016-05-27 769 { > e1e9db2ca79575 Rob Clark 2016-05-27 770 struct msm_gem_object *msm_obj = to_msm_bo(obj); > e1e9db2ca79575 Rob Clark 2016-05-27 771 > 90643a24a7bfbe Rob Clark 2021-04-05 772 GEM_WARN_ON(!msm_gem_is_locked(obj)); > 0e08270a1f01bc Sushmita Susheelendra 2017-06-13 773 > 90643a24a7bfbe Rob Clark 2021-04-05 774 if (!msm_obj->vaddr || GEM_WARN_ON(!is_vunmapable(msm_obj))) > e1e9db2ca79575 Rob Clark 2016-05-27 775 return; > e1e9db2ca79575 Rob Clark 2016-05-27 776 > e1e9db2ca79575 Rob Clark 2016-05-27 @777 vunmap(msm_obj->vaddr); > e1e9db2ca79575 Rob Clark 2016-05-27 778 msm_obj->vaddr = NULL; > e1e9db2ca79575 Rob Clark 2016-05-27 779 } > e1e9db2ca79575 Rob Clark 2016-05-27 780 > > :::::: The code at line 624 was first introduced by commit > :::::: c8afe684c95cd17cf4f273d81af369a0fdfa5a74 drm/msm: basic KMS driver for snapdragon > > :::::: TO: Rob Clark > :::::: CC: Rob Clark > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.01.org%2Fhyperkitty%2Flist%2Fkbuild-all%40lists.01.org&data=04%7C01%7Cchristian.koenig%40amd.com%7C8647a3be20ec4190ad4508d98cf5bb93%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637695812014623891%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ZG3H%2BZ%2BlCk2VDPqUkwhyeV6wK%2BsWaOnHiq7WQedAR6Y%3D&reserved=0