From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Dmitry Safonov <d.safonov@partner.samsung.com>,
linux-mm@kvack.org, Nicolas Pitre <nicolas.pitre@linaro.org>,
Russell King <linux@arm.linux.org.uk>,
Dyasly Sergey <s.dyasly@samsung.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org,
James Bottomley <JBottomley@parallels.com>,
Arnd Bergmann <arnd.bergmann@linaro.org>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC][PATCH RESEND] mm: vmalloc: remove ioremap align constraint
Date: Tue, 23 Dec 2014 21:58:49 +0100 [thread overview]
Message-ID: <11656044.WGcPr1b8t8@wuerfel> (raw)
In-Reply-To: <1419328813-2211-1-git-send-email-d.safonov@partner.samsung.com>
On Tuesday 23 December 2014 13:00:13 Dmitry Safonov wrote:
> ioremap uses __get_vm_area_node which sets alignment to fls of requested size.
> I couldn't find any reason for such big align. Does it decrease TLB misses?
> I tested it on custom ARM board with 200+ Mb of ioremap and it works.
> What am I missing?
The alignment was originally introduced in this commit:
commit ff0daca525dde796382b9ccd563f169df2571211
Author: Russell King <rmk@dyn-67.arm.linux.org.uk>
Date: Thu Jun 29 20:17:15 2006 +0100
[ARM] Add section support to ioremap
Allow section mappings to be setup using ioremap() and torn down
with iounmap(). This requires additional support in the MM
context switch to ensure that mappings are properly synchronised
when mapped in.
Based an original implementation by Deepak Saxena, reworked and
ARMv6 support added by rmk.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
and then later extended to 16MB supersection mappings, which indeed
is used to reduce TLB pressure.
I don't see any downsides to it, why change it?
Arnd
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-12-28 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 10:00 Dmitry Safonov
2014-12-23 20:58 ` Arnd Bergmann [this message]
2015-01-03 15:59 ` Sergey Dyasly
2015-01-04 16:38 ` Arnd Bergmann
2015-01-21 6:52 ` Sergey Dyasly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11656044.WGcPr1b8t8@wuerfel \
--to=arnd@arndb.de \
--cc=JBottomley@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=arnd.bergmann@linaro.org \
--cc=d.safonov@partner.samsung.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=nicolas.pitre@linaro.org \
--cc=s.dyasly@samsung.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox