From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH] mm: cleanup and document reclaim recursion From: Peter Zijlstra In-Reply-To: <20061116161636.aa210bf1.akpm@osdl.org> References: <1163618703.5968.50.camel@twins> <20061115124228.db0b42a6.akpm@osdl.org> <1163625058.5968.64.camel@twins> <20061115132340.3cbf4008.akpm@osdl.org> <1163626378.5968.74.camel@twins> <20061115140049.c835fbfd.akpm@osdl.org> <1163670745.5968.83.camel@twins> <20061116161636.aa210bf1.akpm@osdl.org> Content-Type: text/plain Date: Fri, 17 Nov 2006 09:31:51 +0100 Message-Id: <1163752311.5968.86.camel@twins> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: linux-mm List-ID: On Thu, 2006-11-16 at 16:16 -0800, Andrew Morton wrote: > hmm. > > > > > + /* We're already in reclaim */ > > + if (current->flags & PF_MEMALLOC) > > + return; > > + > > We're kinda dead if free_more_memory() does this. It'll go into an > infinite loop. > > Recurring back into try_to_free_pages() would actually be a better thing to > do.. > > Taking a nap might make some sense, not sure. > > It all needs more thought, no? I'm not much familiar with this filesystem thing, but I'll have me a look, worst thing that can happen is that I learn something new today :-) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org