From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: cleanup and document reclaim recursion
Date: Fri, 17 Nov 2006 09:31:51 +0100 [thread overview]
Message-ID: <1163752311.5968.86.camel@twins> (raw)
In-Reply-To: <20061116161636.aa210bf1.akpm@osdl.org>
On Thu, 2006-11-16 at 16:16 -0800, Andrew Morton wrote:
> hmm.
>
> >
> > + /* We're already in reclaim */
> > + if (current->flags & PF_MEMALLOC)
> > + return;
> > +
>
> We're kinda dead if free_more_memory() does this. It'll go into an
> infinite loop.
>
> Recurring back into try_to_free_pages() would actually be a better thing to
> do..
>
> Taking a nap might make some sense, not sure.
>
> It all needs more thought, no?
I'm not much familiar with this filesystem thing, but I'll have me a
look, worst thing that can happen is that I learn something new
today :-)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-11-17 8:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-15 19:25 mm: call into direct reclaim without PF_MEMALLOC set Peter Zijlstra
2006-11-15 20:42 ` Andrew Morton
2006-11-15 21:23 ` [PATCH] " Peter Zijlstra
2006-11-15 21:32 ` Andrew Morton
[not found] ` <1163625058.5968.64.camel@twins>
[not found] ` <20061115132340.3cbf4008.akpm@osdl.org>
2006-11-15 21:32 ` Peter Zijlstra
2006-11-15 22:00 ` Andrew Morton
2006-11-15 22:12 ` Arjan van de Ven
2006-11-15 22:24 ` Andrew Morton
2006-11-16 9:52 ` [PATCH] mm: cleanup and document reclaim recursion Peter Zijlstra
2006-11-17 0:16 ` Andrew Morton
2006-11-17 8:31 ` Peter Zijlstra [this message]
2006-11-17 12:18 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163752311.5968.86.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox