From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e33.co.us.ibm.com (8.13.8/8.12.11) with ESMTP id kADKYVZZ004356 for ; Mon, 13 Nov 2006 15:34:31 -0500 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay04.boulder.ibm.com (8.13.6/8.13.6/NCO v8.1.1) with ESMTP id kADKYVvY279270 for ; Mon, 13 Nov 2006 13:34:31 -0700 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id kADKYUa6018545 for ; Mon, 13 Nov 2006 13:34:31 -0700 Subject: RE: [hugepage] Fix unmap_and_free_vma backout path From: Adam Litke In-Reply-To: References: <000301c706f6$4ae26160$a081030a@amr.corp.intel.com> Content-Type: text/plain Date: Mon, 13 Nov 2006 14:34:29 -0600 Message-Id: <1163450069.17046.24.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Hugh Dickins Cc: "Chen, Kenneth W" , 'David Gibson' , 'Christoph Lameter' , 'Andrew Morton' , bill.irwin@oracle.com, linux-mm@kvack.org List-ID: Looks good to me, notwithstanding the nano-nit below. On Mon, 2006-11-13 at 17:00 +0000, Hugh Dickins wrote: > + /* > + * vma alignment has already been checked by prepare_hugepage_range. > + * If you add any error returns here, do so after setting VM_HUGETLB, > + * so is_vm_huge_tlb_page tests below unmap_region go the right way > + * when do_mmap_pgoff unwinds (may be important on powerpc and ia64). > + */ Sorry. This is hardly worth it, but the function referred to by this comment is actually is_vm_hugetlb_page() :-/ -- Adam Litke - (agl at us.ibm.com) IBM Linux Technology Center -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org