From: Ashwin Chaugule <ashwin.chaugule@celunite.com>
To: linux-mm@kvack.org
Subject: [RFC][PATCH 1/2] Swap token re-tuned
Date: Thu, 28 Sep 2006 22:28:03 +0530 [thread overview]
Message-ID: <1159462684.11855.8.camel@localhost.localdomain> (raw)
[-- Attachment #1: Type: text/plain, Size: 243 bytes --]
Sorry about that, I was'nt aware of the Thunderbird issue.
Sending the patches again.
Thanks Peter !
-Ashwin
Try to grab swap token before the VM selects pages for eviction.
Signed-off-by: Ashwin Chaugule <ashwin.chaugule@celunite.com>
[-- Attachment #2: swap-token-patch1 --]
[-- Type: text/x-patch, Size: 1150 bytes --]
diff --git a/mm/filemap.c b/mm/filemap.c
index afcdc72..190d2c1 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1478,8 +1478,8 @@ no_cached_page:
* We're only likely to ever get here if MADV_RANDOM is in
* effect.
*/
+ grab_swap_token(); /* Contend for token _before_ we read-in */
error = page_cache_read(file, pgoff);
- grab_swap_token();
/*
* The page we want has now been added to the page cache.
diff --git a/mm/memory.c b/mm/memory.c
index 92a3ebd..52eb9b8 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1974,6 +1974,7 @@ static int do_swap_page(struct mm_struct
delayacct_set_flag(DELAYACCT_PF_SWAPIN);
page = lookup_swap_cache(entry);
if (!page) {
+ grab_swap_token(); /* Contend for token _before_ we read-in */
swapin_readahead(entry, address, vma);
page = read_swap_cache_async(entry, vma, address);
if (!page) {
@@ -1991,7 +1992,6 @@ static int do_swap_page(struct mm_struct
/* Had to read the page from swap area: Major fault */
ret = VM_FAULT_MAJOR;
count_vm_event(PGMAJFAULT);
- grab_swap_token();
}
delayacct_clear_flag(DELAYACCT_PF_SWAPIN);
diff --git a/mm/thrash.c b/mm/thrash.c
next reply other threads:[~2006-09-28 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 16:58 Ashwin Chaugule [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-09-28 14:09 Ashwin Chaugule
2006-09-28 14:06 Ashwin Chaugule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1159462684.11855.8.camel@localhost.localdomain \
--to=ashwin.chaugule@celunite.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox